From: Dmitry Osipenko <digetx@gmail.com>
To: Joerg Roedel <joro@8bytes.org>,
Robin Murphy <robin.murphy@arm.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Rob Herring <robh+dt@kernel.org>
Cc: iommu@lists.linux-foundation.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 15/19] iommu/tegra: gart: Don't use managed resources
Date: Sat, 18 Aug 2018 18:54:26 +0300 [thread overview]
Message-ID: <20180818155430.5586-16-digetx@gmail.com> (raw)
In-Reply-To: <20180818155430.5586-1-digetx@gmail.com>
GART is a part of the Memory Controller driver that is always built-in,
hence there is no benefit from the use of managed resources.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/iommu/tegra-gart.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/iommu/tegra-gart.c b/drivers/iommu/tegra-gart.c
index 9f7d3afb686f..d019ae8ecfc9 100644
--- a/drivers/iommu/tegra-gart.c
+++ b/drivers/iommu/tegra-gart.c
@@ -171,7 +171,7 @@ static int gart_iommu_attach_dev(struct iommu_domain *domain,
struct gart_client *client, *c;
int err = 0;
- client = devm_kzalloc(gart->dev, sizeof(*c), GFP_KERNEL);
+ client = kzalloc(sizeof(*c), GFP_KERNEL);
if (!client)
return -ENOMEM;
client->dev = dev;
@@ -197,7 +197,7 @@ static int gart_iommu_attach_dev(struct iommu_domain *domain,
return 0;
fail:
- devm_kfree(gart->dev, client);
+ kfree(client);
spin_unlock(&gart->client_lock);
return err;
}
@@ -212,7 +212,7 @@ static void __gart_iommu_detach_dev(struct iommu_domain *domain,
list_for_each_entry(c, &gart->client, list) {
if (c->dev == dev) {
list_del(&c->list);
- devm_kfree(gart->dev, c);
+ kfree(c);
if (list_empty(&gart->client))
gart->active_domain = NULL;
dev_dbg(gart->dev, "Detached %s\n", dev_name(dev));
@@ -459,7 +459,7 @@ struct gart_device *tegra_gart_probe(struct device *dev,
return ERR_PTR(-ENXIO);
}
- gart = devm_kzalloc(dev, sizeof(*gart), GFP_KERNEL);
+ gart = kzalloc(sizeof(*gart), GFP_KERNEL);
if (!gart) {
dev_err(dev, "failed to allocate gart_device\n");
return ERR_PTR(-ENOMEM);
@@ -468,7 +468,7 @@ struct gart_device *tegra_gart_probe(struct device *dev,
ret = iommu_device_sysfs_add(&gart->iommu, dev, NULL, "gart");
if (ret) {
dev_err(dev, "Failed to register IOMMU in sysfs\n");
- return ERR_PTR(ret);
+ goto free_gart;
}
iommu_device_set_ops(&gart->iommu, &gart_iommu_ops);
@@ -506,6 +506,8 @@ struct gart_device *tegra_gart_probe(struct device *dev,
iommu_device_unregister(&gart->iommu);
remove_sysfs:
iommu_device_sysfs_remove(&gart->iommu);
+free_gart:
+ kfree(gart);
return ERR_PTR(ret);
}
--
2.18.0
next prev parent reply other threads:[~2018-08-18 15:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-18 15:54 [PATCH v3 00/19] IOMMU: Tegra GART driver clean up and optimization Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 01/19] iommu/tegra: gart: Remove pr_fmt and clean up includes Dmitry Osipenko
[not found] ` <20180818155430.5586-1-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-18 15:54 ` [PATCH v3 02/19] iommu/tegra: gart: Clean up driver probe errors handling Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 04/19] iommu: Introduce iotlb_sync_map callback Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 06/19] dt-bindings: memory: tegra: Squash tegra20-gart into tegra20-mc Dmitry Osipenko
2018-08-20 19:12 ` Rob Herring
2018-08-20 19:27 ` Dmitry Osipenko
[not found] ` <b46cac22-9b31-9aa7-7eca-4725156346bb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-20 19:35 ` Dmitry Osipenko
[not found] ` <4538309b-fcb3-73ee-04e3-6cefcedd376d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-28 10:47 ` Thierry Reding
2018-08-28 13:09 ` Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 07/19] ARM: dts: tegra20: Update Memory Controller node to the new binding Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 03/19] iommu/tegra: gart: Ignore devices without IOMMU phandle in DT Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 05/19] iommu/tegra: gart: Optimize mapping / unmapping performance Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 08/19] memory: tegra: Don't invoke Tegra30+ specific memory timing setup on Tegra20 Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 09/19] memory: tegra: Adapt to Tegra20 device-tree binding changes Dmitry Osipenko
2018-09-03 21:06 ` Marcel Ziswiler
2018-09-04 8:56 ` Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 10/19] memory: tegra: Read client ID on GART page fault Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 11/19] iommu/tegra: gart: Integrate with Memory Controller driver Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 12/19] iommu/tegra: gart: Fix spinlock recursion Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 13/19] iommu/tegra: gart: Fix NULL pointer dereference Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 14/19] iommu/tegra: gart: Allow only one active domain at a time Dmitry Osipenko
2018-08-18 15:54 ` Dmitry Osipenko [this message]
2018-08-18 15:54 ` [PATCH v3 16/19] iommu/tegra: gart: Prepend error/debug messages with "GART:" Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 17/19] iommu/tegra: gart: Don't detach devices from inactive domains Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 18/19] iommu/tegra: gart: Simplify clients-tracking code Dmitry Osipenko
2018-08-18 15:54 ` [PATCH v3 19/19] iommu/tegra: gart: Perform code refactoring Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180818155430.5586-16-digetx@gmail.com \
--to=digetx@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).