* [PATCH] mmc: tegra: fix inconsistent IS_ERR and PTR_ERR
@ 2018-09-04 2:59 YueHaibing
2018-09-04 10:13 ` Aapo Vienamo
2018-09-04 14:34 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2018-09-04 2:59 UTC (permalink / raw)
To: adrian.hunter, ulf.hansson, thierry.reding, jonathanh
Cc: linux-kernel, linux-mmc, linux-tegra, YueHaibing
Fix inconsistent IS_ERR and PTR_ERR in tegra_sdhci_init_pinctrl_info,
the proper pointer to be passed as argument is 'pinctrl_state_1v8'
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/mmc/host/sdhci-tegra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
index e80716c..c789158 100644
--- a/drivers/mmc/host/sdhci-tegra.c
+++ b/drivers/mmc/host/sdhci-tegra.c
@@ -724,7 +724,7 @@ static int tegra_sdhci_init_pinctrl_info(struct device *dev,
pinctrl_lookup_state(tegra_host->pinctrl_sdmmc, "sdmmc-1v8");
if (IS_ERR(tegra_host->pinctrl_state_1v8)) {
dev_warn(dev, "Missing 1.8V pad state, err: %ld\n",
- PTR_ERR(tegra_host->pinctrl_state_3v3));
+ PTR_ERR(tegra_host->pinctrl_state_1v8));
return -1;
}
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: tegra: fix inconsistent IS_ERR and PTR_ERR
2018-09-04 2:59 [PATCH] mmc: tegra: fix inconsistent IS_ERR and PTR_ERR YueHaibing
@ 2018-09-04 10:13 ` Aapo Vienamo
2018-09-04 14:34 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Aapo Vienamo @ 2018-09-04 10:13 UTC (permalink / raw)
To: YueHaibing; +Cc: linux-kernel, linux-mmc, linux-tegra
On Tue, 4 Sep 2018 10:59:09 +0800
YueHaibing <yuehaibing@huawei.com> wrote:
> Fix inconsistent IS_ERR and PTR_ERR in tegra_sdhci_init_pinctrl_info,
> the proper pointer to be passed as argument is 'pinctrl_state_1v8'
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Aapo Vienamo <aapo.vienamo@iki.fi>
> ---
> drivers/mmc/host/sdhci-tegra.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index e80716c..c789158 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -724,7 +724,7 @@ static int tegra_sdhci_init_pinctrl_info(struct device *dev,
> pinctrl_lookup_state(tegra_host->pinctrl_sdmmc, "sdmmc-1v8");
> if (IS_ERR(tegra_host->pinctrl_state_1v8)) {
> dev_warn(dev, "Missing 1.8V pad state, err: %ld\n",
> - PTR_ERR(tegra_host->pinctrl_state_3v3));
> + PTR_ERR(tegra_host->pinctrl_state_1v8));
> return -1;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: tegra: fix inconsistent IS_ERR and PTR_ERR
2018-09-04 2:59 [PATCH] mmc: tegra: fix inconsistent IS_ERR and PTR_ERR YueHaibing
2018-09-04 10:13 ` Aapo Vienamo
@ 2018-09-04 14:34 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2018-09-04 14:34 UTC (permalink / raw)
To: YueHaibing
Cc: Adrian Hunter, Thierry Reding, Jon Hunter,
Linux Kernel Mailing List, linux-mmc@vger.kernel.org, linux-tegra
On 4 September 2018 at 04:59, YueHaibing <yuehaibing@huawei.com> wrote:
> Fix inconsistent IS_ERR and PTR_ERR in tegra_sdhci_init_pinctrl_info,
> the proper pointer to be passed as argument is 'pinctrl_state_1v8'
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-tegra.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index e80716c..c789158 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -724,7 +724,7 @@ static int tegra_sdhci_init_pinctrl_info(struct device *dev,
> pinctrl_lookup_state(tegra_host->pinctrl_sdmmc, "sdmmc-1v8");
> if (IS_ERR(tegra_host->pinctrl_state_1v8)) {
> dev_warn(dev, "Missing 1.8V pad state, err: %ld\n",
> - PTR_ERR(tegra_host->pinctrl_state_3v3));
> + PTR_ERR(tegra_host->pinctrl_state_1v8));
> return -1;
> }
>
> --
> 2.7.0
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-04 14:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-04 2:59 [PATCH] mmc: tegra: fix inconsistent IS_ERR and PTR_ERR YueHaibing
2018-09-04 10:13 ` Aapo Vienamo
2018-09-04 14:34 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox