From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only Date: Fri, 12 Oct 2018 18:17:05 +0200 Message-ID: <20181012161705.GC2340@sirena.org.uk> References: <20180906122436.25610-1-linus.walleij@linaro.org> <20181011090112eucas1p286d8c1edfc1a2a207d8a11c5ad7eb20e~cglSx9qcr2394623946eucas1p2y@eucas1p2.samsung.com> <1539272073.18645.12.camel@toradex.com> <1539337415.30485.21.camel@toradex.com> <20181012104338.GS30658@n2100.armlinux.org.uk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kfjH4zxOES6UT95V" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Andy Shevchenko Cc: Russell King - ARM Linux , Jon Hunter , Marcel Ziswiler , Linus Walleij , Linux Kernel Mailing List , Robert Jarzmik , Aaro Koskinen , jmondi , Marek Szyprowski , Alexander Shiyan , Haojian Zhuang , Liam Girdwood , Mike Rapoport , Daniel Mack , Marc Zyngier , philipp.zabel@gmail.com, linux-tegra@vger.kernel.org, Janusz Krzysztofik , Geert Uytterhoeven List-Id: linux-tegra@vger.kernel.org --kfjH4zxOES6UT95V Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Oct 12, 2018 at 04:58:38PM +0300, Andy Shevchenko wrote: > On Fri, Oct 12, 2018 at 1:45 PM Russell King - ARM Linux > > Given that DT describes the hardware, not the software implementation, > > it must not change just because we move from GPIO numbers to GPIO > > descriptors. > > The existing DT description is reasonable, and introducing ficticious > > regulators in DT to work around the implementation is not reasonable. > If there is no way to detect shared use of GPIO line for regulators > (*) from current DT description, DT description should be updated to > reflect, yes, hardware. > (*) Not familiar with the guts of DT descriptive language, don't know > if there are some ways to do a such without additional flags or so. You can detect this via resolving the GPIOs and seeing if it points back to something that's already in use for an enable. This isn't ideal especially if you want to do it up front but it is doable. You could also just assume anything might end up being shared and rather than doing it up front which is easier and probably about as good. --kfjH4zxOES6UT95V Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlvAyQAACgkQJNaLcl1U h9AxNAf/dagFIggZW486itfhQDBJTefSA7vwmkxbzYKHZwodlcpEpGhwWUGxveyO 8kGuCjpCHU1knlsCL1q+8A9HwWnbCRp/aDYLXHpvSS/vghpCaKTdwo2ZBLg7PSjy AVd9f/+d4pxoL2eUNgyl6D+EjymXk/v0sgu+uXF6wnHyrAhvD7UAhzAs3EAB00UW 0pkTrYLtpfSJjM+BKurnp+uQ9H3W7GKp86NOE5coFK8rvGQ4J0Mx2VutuMC4VYeR 6RBFMAuXFhnd/bhR/is0giBumfxaHD3vX4QVfxk8vhXhJ5OsO+nzSeMBrG7mS8kO YXzCtuLAJGuQgrOkXMKYs2UJcZBBZQ== =7HRA -----END PGP SIGNATURE----- --kfjH4zxOES6UT95V--