From: Mark Brown <broonie@kernel.org>
To: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Cc: "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"jonathanh@nvidia.com" <jonathanh@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robert.jarzmik@free.fr" <robert.jarzmik@free.fr>,
"aaro.koskinen@iki.fi" <aaro.koskinen@iki.fi>,
"jacopo@jmondi.org" <jacopo@jmondi.org>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"m.szyprowski@samsung.com" <m.szyprowski@samsung.com>,
"shc_work@mail.ru" <shc_work@mail.ru>,
"haojian.zhuang@gmail.com" <haojian.zhuang@gmail.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"rppt@linux.vnet.ibm.com" <rppt@linux.vnet.ibm.com>,
"zonque@gmail.com" <zonque@gmail.com>,
"marc.zyngier@arm.com" <marc.zyngier@arm.com>,
"philipp.zabel@gmail.com"
<philipp.zabel@gmail.com>"linux-tegra@vger.kernel.org" <linux->
Subject: Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only
Date: Fri, 12 Oct 2018 18:57:51 +0200 [thread overview]
Message-ID: <20181012165751.GI2340@sirena.org.uk> (raw)
In-Reply-To: <1539344591.30485.28.camel@toradex.com>
[-- Attachment #1: Type: text/plain, Size: 993 bytes --]
On Fri, Oct 12, 2018 at 11:43:13AM +0000, Marcel Ziswiler wrote:
> On Fri, 2018-10-12 at 11:43 +0100, Russell King - ARM Linux wrote:
> > The existing DT description is reasonable, and introducing ficticious
> > regulators in DT to work around the implementation is not reasonable.
> I don't think it is that fictitious as it makes it crystal clear that
> there is something shared with all its pros and cons. E.g. what happens
> if one of them regulators wants to turn off while the other one still
> needs power? The regular regulator dependency tree would nicely make
> this all clear.
We already have code to handle that via refcounting on the GPIO once we
identify that it's the same GPIO. If we make a shared virtual parent
regulator that'll break other things where we're tracking what the
actual physical parent for voltage reasons like adjusting parent
voltages up and down to improve efficiency or handling things that are
just dumb power switches rather than actual regulators.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-10-12 16:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20181011090112eucas1p286d8c1edfc1a2a207d8a11c5ad7eb20e@eucas1p2.samsung.com>
[not found] ` <20180906122436.25610-1-linus.walleij@linaro.org>
[not found] ` <20181011090112eucas1p286d8c1edfc1a2a207d8a11c5ad7eb20e~cglSx9qcr2394623946eucas1p2y@eucas1p2.samsung.com>
[not found] ` <CACRpkdbTdmQQTg1D9jbcHGcT4kZermwVA+QEnUJGf+VYqoKRkg@mail.gmail.com>
2018-10-11 15:00 ` [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only Jon Hunter
2018-10-11 15:34 ` Marcel Ziswiler
2018-10-11 17:47 ` Linus Walleij
2018-10-12 9:43 ` Marcel Ziswiler
2018-10-12 10:39 ` Jon Hunter
2018-10-12 10:43 ` Russell King - ARM Linux
2018-10-12 11:03 ` Linus Walleij
2018-10-12 11:43 ` Marcel Ziswiler
2018-10-12 12:59 ` Russell King - ARM Linux
2018-10-12 13:13 ` Marcel Ziswiler
2018-10-12 16:57 ` Mark Brown [this message]
2018-10-12 13:58 ` Andy Shevchenko
2018-10-12 16:17 ` Mark Brown
2018-10-11 17:45 ` Linus Walleij
2018-10-12 10:25 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181012165751.GI2340@sirena.org.uk \
--to=broonie@kernel.org \
--cc=aaro.koskinen@iki.fi \
--cc=haojian.zhuang@gmail.com \
--cc=jacopo@jmondi.org \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=marc.zyngier@arm.com \
--cc=marcel.ziswiler@toradex.com \
--cc=philipp.zabel@gmail.com \
--cc=robert.jarzmik@free.fr \
--cc=rppt@linux.vnet.ibm.com \
--cc=shc_work@mail.ru \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox