public inbox for linux-tegra@vger.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Ville Syrjälä" <ville.syrjala-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	Ben Skeggs <bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/nouveau: tegra: Initialize mode configuration
Date: Wed, 7 Nov 2018 16:34:09 +0100	[thread overview]
Message-ID: <20181107153409.GA7155@ulmo> (raw)
In-Reply-To: <20181106164122.GB9144-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>


[-- Attachment #1.1: Type: text/plain, Size: 988 bytes --]

On Tue, Nov 06, 2018 at 06:41:22PM +0200, Ville Syrjälä wrote:
> On Tue, Nov 06, 2018 at 05:24:15PM +0100, Thierry Reding wrote:
> > From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> > 
> > Irrespective of whether or not the device has any usable outputs, the
> > modesetting helpers will try to register all the resources such as CRTCs
> > and planes. Unfortunately, the helpers rely on drm_mode_config_init() to
> > properly set up internal data structures. Since the Tegra GPU does not
> > have a display engine, the Nouveau driver doesn't set this up for Tegra,
> > which results in the following oops on driver probe:
> 
> Remove DRIVER_MODESET ?

Yeah, that works as well. Technically I suppose somebody could be
instantiating the IP in an SoC and include a display engine, in which
case we'd need the DRIVER_MODESET feature again, but I'm not aware of
anyone doing that, so it may not be worth planning for that at this
point.

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

  parent reply	other threads:[~2018-11-07 15:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-06 16:24 [PATCH] drm/nouveau: tegra: Initialize mode configuration Thierry Reding
2018-11-06 16:41 ` Ville Syrjälä
     [not found]   ` <20181106164122.GB9144-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2018-11-07 15:34     ` Thierry Reding [this message]
2018-11-07 15:52       ` Ilia Mirkin
2018-11-07 16:12         ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181107153409.GA7155@ulmo \
    --to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=ville.syrjala-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox