From: Nathan Chancellor <natechancellor@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>
Cc: Yangtao Li <tiny.windzz@gmail.com>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
Nick Desaulniers <ndesaulniers@google.com>,
Nathan Chancellor <natechancellor@gmail.com>
Subject: [PATCH] soc/tegra: Fix terminating condition
Date: Thu, 22 Nov 2018 00:52:44 -0700 [thread overview]
Message-ID: <20181122075244.3909-1-natechancellor@gmail.com> (raw)
Clang warns:
drivers/soc/tegra/common.c:27:16: error: address of array
'match->compatible' will always evaluate to 'true'
[-Werror,-Wpointer-bool-conversion]
while (match->compatible) {
~~~~~ ~~~~~~~^~~~~~~~~~
1 error generated.
Whoops, we have an infinite loop and QEMU no longer boots...
https://travis-ci.com/ClangBuiltLinux/continuous-integration/jobs/160242918
Check that the first character of the string isn't null so that the loop
properly terminates.
Fixes: c57eff9503a5 ("soc/tegra: refactor soc_is_tegra()")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
drivers/soc/tegra/common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/tegra/common.c b/drivers/soc/tegra/common.c
index 8a538b968fe9..54627ca957e8 100644
--- a/drivers/soc/tegra/common.c
+++ b/drivers/soc/tegra/common.c
@@ -24,7 +24,7 @@ bool soc_is_tegra(void)
{
const struct of_device_id *match = tegra_machine_match;
- while (match->compatible) {
+ while (match->compatible[0]) {
if (of_machine_is_compatible(match->compatible))
return true;
--
2.20.0.rc1
next reply other threads:[~2018-11-22 7:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 7:52 Nathan Chancellor [this message]
2018-11-22 8:16 ` [PATCH] soc/tegra: Fix terminating condition Frank Lee
2018-11-22 8:50 ` Thierry Reding
2018-11-22 8:58 ` Frank Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181122075244.3909-1-natechancellor@gmail.com \
--to=natechancellor@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=ndesaulniers@google.com \
--cc=thierry.reding@gmail.com \
--cc=tiny.windzz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox