From: Thierry Reding <thierry.reding@gmail.com>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>,
Yangtao Li <tiny.windzz@gmail.com>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH] soc/tegra: Fix terminating condition
Date: Thu, 22 Nov 2018 09:50:22 +0100 [thread overview]
Message-ID: <20181122085022.GB5741@ulmo> (raw)
In-Reply-To: <20181122075244.3909-1-natechancellor@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 943 bytes --]
On Thu, Nov 22, 2018 at 12:52:44AM -0700, Nathan Chancellor wrote:
> Clang warns:
>
> drivers/soc/tegra/common.c:27:16: error: address of array
> 'match->compatible' will always evaluate to 'true'
> [-Werror,-Wpointer-bool-conversion]
> while (match->compatible) {
> ~~~~~ ~~~~~~~^~~~~~~~~~
> 1 error generated.
>
> Whoops, we have an infinite loop and QEMU no longer boots...
>
> https://travis-ci.com/ClangBuiltLinux/continuous-integration/jobs/160242918
>
> Check that the first character of the string isn't null so that the loop
> properly terminates.
>
> Fixes: c57eff9503a5 ("soc/tegra: refactor soc_is_tegra()")
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> drivers/soc/tegra/common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Wow... that's what I get from not testing this properly. Apologies for
the inconvenience.
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-11-22 8:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 7:52 [PATCH] soc/tegra: Fix terminating condition Nathan Chancellor
2018-11-22 8:16 ` Frank Lee
2018-11-22 8:50 ` Thierry Reding [this message]
2018-11-22 8:58 ` Frank Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181122085022.GB5741@ulmo \
--to=thierry.reding@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=tiny.windzz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox