From: Mark Brown <broonie@kernel.org>
To: Mark Zhang <markz@nvidia.com>
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org,
Venkat Reddy Talla <vreddytalla@nvidia.com>
Subject: Re: [PATCH 2/2] regulator: max77620: disable notifier events for FPS rails
Date: Thu, 10 Jan 2019 12:07:07 +0000 [thread overview]
Message-ID: <20190110120707.GD9541@sirena.org.uk> (raw)
In-Reply-To: <20190110041117.8216-2-markz@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 509 bytes --]
On Thu, Jan 10, 2019 at 12:11:17PM +0800, Mark Zhang wrote:
> + /* there is no SW control for rails which are part of FPS
> + * set always no contraint to true to avoid regulator
> + * enable/disable notification
> + */
> + if (pmic->reg_pdata[id].active_fps_src != MAX77620_FPS_SRC_NONE)
> + rdev->constraints->always_on = true;
A driver should never modify the constraints, you should register a
different set of operations without an enable operation instead and let
the framework handle this.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-01-10 12:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 4:11 [PATCH 1/2] regulator: max77620: Initialize values for DT properties Mark Zhang
2019-01-10 4:11 ` [PATCH 2/2] regulator: max77620: disable notifier events for FPS rails Mark Zhang
2019-01-10 12:07 ` Mark Brown [this message]
2019-01-11 13:35 ` Mark Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110120707.GD9541@sirena.org.uk \
--to=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=markz@nvidia.com \
--cc=vreddytalla@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox