From: Thierry Reding <thierry.reding@gmail.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org,
Gregory Clement <gregory.clement@bootlin.com>
Subject: Re: [PATCH 3/3] mmc: sdhci-tegra: drop ->get_ro() implementation
Date: Wed, 16 Jan 2019 14:22:21 +0100 [thread overview]
Message-ID: <20190116132221.GA11050@ulmo> (raw)
In-Reply-To: <20190115162837.5399-4-thomas.petazzoni@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]
On Tue, Jan 15, 2019 at 05:28:37PM +0100, Thomas Petazzoni wrote:
> The SDHCI core is know properly checking for the state of a WP GPIO,
> so there is no longer any need for the sdhci-tegra code to implement
> ->get_ro() using mmc_gpio_get_ro().
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> Note: this patch has only been compiled tested, as I don't have the
> hardware to test it.
> ---
> drivers/mmc/host/sdhci-tegra.c | 9 ---------
> 1 file changed, 9 deletions(-)
So, if I apply this on top of next-20180116 I do get a BUG from
bio_split() on line 1833 in block/bio.c. However, that BUG also exists
without these patches.
More importantly, read-only detection with this applied still works on
for example Jetson TK1:
[ 28.547261] mmc1: new high speed SDHC card at address 59b4
[ 28.558814] mmcblk1: mmc1:59b4 SDC 14.7 GiB (ro)
So:
Tested-by: Thierry Reding <treding@nvidia.com>
and:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-01-16 13:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 16:28 [PATCH 0/3] Introduce support for WP GPIO in the core SDHCI Thomas Petazzoni
2019-01-15 16:28 ` [PATCH 1/3] mmc: sdhci: use WP GPIO in sdhci_check_ro() Thomas Petazzoni
2019-01-16 12:32 ` Thierry Reding
2019-01-16 12:59 ` Adrian Hunter
2019-01-16 13:20 ` Thomas Petazzoni
2019-01-15 16:28 ` [PATCH 2/3] mmc: sdhci-omap: drop ->get_ro() implementation Thomas Petazzoni
2019-01-16 13:27 ` Thierry Reding
2019-01-16 15:47 ` Tony Lindgren
2019-01-16 15:58 ` Thomas Petazzoni
2019-01-18 10:57 ` Faiz Abbas
2019-01-18 15:32 ` Tony Lindgren
2019-01-15 16:28 ` [PATCH 3/3] mmc: sdhci-tegra: " Thomas Petazzoni
2019-01-16 13:22 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190116132221.GA11050@ulmo \
--to=thierry.reding@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=gregory.clement@bootlin.com \
--cc=jonathanh@nvidia.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).