From: Thierry Reding <thierry.reding@gmail.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org,
Gregory Clement <gregory.clement@bootlin.com>,
Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/3] mmc: sdhci-omap: drop ->get_ro() implementation
Date: Wed, 16 Jan 2019 14:27:47 +0100 [thread overview]
Message-ID: <20190116132747.GB11050@ulmo> (raw)
In-Reply-To: <20190115162837.5399-3-thomas.petazzoni@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 1529 bytes --]
On Tue, Jan 15, 2019 at 05:28:36PM +0100, Thomas Petazzoni wrote:
> The SDHCI core is know properly checking for the state of a WP GPIO,
"know" -> "now"
> so there is no longer any need for the sdhci-omap code to implement
> ->get_ro() using mmc_gpio_get_ro().
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> Note: this patch has only been compiled tested, as I don't have the
> hardware to test it.
> ---
> drivers/mmc/host/sdhci-omap.c | 1 -
> 1 file changed, 1 deletion(-)
I can't runtime test this myself, but it certainly looks like this would
do the right thing because it calls the core now call the very same
function as this used to, so:
Reviewed-by: Thierry Reding <treding@nvidia.com>
Adding Tony and linux-omap for a slightly wider audience and hopefully
find someone to test this on. For reference, the whole series is here:
https://patchwork.kernel.org/project/linux-mmc/list/?series=66905
Thierry
>
> diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c
> index d264391616f9..c2a28930086f 100644
> --- a/drivers/mmc/host/sdhci-omap.c
> +++ b/drivers/mmc/host/sdhci-omap.c
> @@ -987,7 +987,6 @@ static int sdhci_omap_probe(struct platform_device *pdev)
> goto err_put_sync;
> }
>
> - host->mmc_host_ops.get_ro = mmc_gpio_get_ro;
> host->mmc_host_ops.start_signal_voltage_switch =
> sdhci_omap_start_signal_voltage_switch;
> host->mmc_host_ops.set_ios = sdhci_omap_set_ios;
> --
> 2.20.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-01-16 13:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 16:28 [PATCH 0/3] Introduce support for WP GPIO in the core SDHCI Thomas Petazzoni
2019-01-15 16:28 ` [PATCH 1/3] mmc: sdhci: use WP GPIO in sdhci_check_ro() Thomas Petazzoni
2019-01-16 12:32 ` Thierry Reding
2019-01-16 12:59 ` Adrian Hunter
2019-01-16 13:20 ` Thomas Petazzoni
2019-01-15 16:28 ` [PATCH 2/3] mmc: sdhci-omap: drop ->get_ro() implementation Thomas Petazzoni
2019-01-16 13:27 ` Thierry Reding [this message]
2019-01-16 15:47 ` Tony Lindgren
2019-01-16 15:58 ` Thomas Petazzoni
2019-01-18 10:57 ` Faiz Abbas
2019-01-18 15:32 ` Tony Lindgren
2019-01-15 16:28 ` [PATCH 3/3] mmc: sdhci-tegra: " Thomas Petazzoni
2019-01-16 13:22 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190116132747.GB11050@ulmo \
--to=thierry.reding@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=gregory.clement@bootlin.com \
--cc=jonathanh@nvidia.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=tony@atomide.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).