* [PATCH 22/26] drm/qxl: Use drm_fb_helper_fill_info [not found] <20190124165831.16427-1-daniel.vetter@ffwll.ch> @ 2019-01-24 16:58 ` Daniel Vetter 2019-01-25 15:14 ` Thierry Reding [not found] ` <20190124165831.16427-1-daniel.vetter-/w4YWyX8dFk@public.gmane.org> 1 sibling, 1 reply; 6+ messages in thread From: Daniel Vetter @ 2019-01-24 16:58 UTC (permalink / raw) To: DRI Development Cc: Daniel Vetter, Intel Graphics Development, Jonathan Hunter, linux-tegra, Daniel Vetter Another driver that didn't set fbinfo->fix.id before. Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: Jonathan Hunter <jonathanh@nvidia.com> Cc: linux-tegra@vger.kernel.org --- drivers/gpu/drm/tegra/fb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c index 5ee48a6bb3ad..82348ddd0b83 100644 --- a/drivers/gpu/drm/tegra/fb.c +++ b/drivers/gpu/drm/tegra/fb.c @@ -255,12 +255,10 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper, helper->fb = fb; helper->fbdev = info; - info->par = helper; info->flags = FBINFO_FLAG_DEFAULT; info->fbops = &tegra_fb_ops; - drm_fb_helper_fill_fix(info, fb->pitches[0], fb->format->depth); - drm_fb_helper_fill_var(info, helper, fb->width, fb->height); + drm_fb_helper_fill_info(info, helper); offset = info->var.xoffset * bytes_per_pixel + info->var.yoffset * fb->pitches[0]; -- 2.20.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 22/26] drm/qxl: Use drm_fb_helper_fill_info 2019-01-24 16:58 ` [PATCH 22/26] drm/qxl: Use drm_fb_helper_fill_info Daniel Vetter @ 2019-01-25 15:14 ` Thierry Reding 0 siblings, 0 replies; 6+ messages in thread From: Thierry Reding @ 2019-01-25 15:14 UTC (permalink / raw) To: Daniel Vetter Cc: linux-tegra, Daniel Vetter, Intel Graphics Development, DRI Development, Jonathan Hunter [-- Attachment #1.1: Type: text/plain, Size: 512 bytes --] On Thu, Jan 24, 2019 at 05:58:27PM +0100, Daniel Vetter wrote: > Another driver that didn't set fbinfo->fix.id before. > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Jonathan Hunter <jonathanh@nvidia.com> > Cc: linux-tegra@vger.kernel.org > --- > drivers/gpu/drm/tegra/fb.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) In the subject: drm/qxl -> drm/tegra, with that: Acked-by: Thierry Reding <treding@nvidia.com> [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <20190124165831.16427-1-daniel.vetter-/w4YWyX8dFk@public.gmane.org>]
* [PATCH 26/26] drm/<drivers>: Don't set FBINFO_(FLAG_)DEFAULT [not found] ` <20190124165831.16427-1-daniel.vetter-/w4YWyX8dFk@public.gmane.org> @ 2019-01-24 16:58 ` Daniel Vetter 2019-01-25 15:02 ` Emil Velikov 2019-01-25 15:14 ` Thierry Reding 0 siblings, 2 replies; 6+ messages in thread From: Daniel Vetter @ 2019-01-24 16:58 UTC (permalink / raw) To: DRI Development Cc: Heiko Stübner, Daniel Vetter, Thierry Reding, Patrik Jakobsson, Daniel Vetter, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, Joonyoung Shim, Krzysztof Kozlowski, Jonathan Hunter, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Kukjin Kim, Ben Skeggs, nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Alexander Kapshuk, Bartlomiej Zolnierkiewicz, Intel Graphics Development, Inki Dae, Hans de Goede, linux-tegra-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Greg Kroah-Hartman It's 0. Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: Inki Dae <inki.dae@samsung.com> Cc: Joonyoung Shim <jy0922.shim@samsung.com> Cc: Seung-Woo Kim <sw0312.kim@samsung.com> Cc: Kyungmin Park <kyungmin.park@samsung.com> Cc: Kukjin Kim <kgene@kernel.org> Cc: Krzysztof Kozlowski <krzk@kernel.org> Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> Cc: Ben Skeggs <bskeggs@redhat.com> Cc: Sandy Huang <hjc@rock-chips.com> Cc: "Heiko Stübner" <heiko@sntech.de> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: Jonathan Hunter <jonathanh@nvidia.com> Cc: Hans de Goede <hdegoede@redhat.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Cc: Alexander Kapshuk <alexander.kapshuk@gmail.com> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org Cc: nouveau@lists.freedesktop.org Cc: linux-rockchip@lists.infradead.org Cc: linux-tegra@vger.kernel.org --- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 1 - drivers/gpu/drm/gma500/framebuffer.c | 1 - drivers/gpu/drm/nouveau/nouveau_fbcon.c | 4 ++-- drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 1 - drivers/gpu/drm/tegra/fb.c | 1 - 5 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c index b2018961b9cf..00bfcd28e589 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c @@ -87,7 +87,6 @@ static int exynos_drm_fbdev_update(struct drm_fb_helper *helper, return PTR_ERR(fbi); } - fbi->flags = FBINFO_FLAG_DEFAULT; fbi->fbops = &exynos_drm_fb_ops; drm_fb_helper_fill_info(fbi, helper); diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c index c7a5c29f9a69..3b59dbadfa63 100644 --- a/drivers/gpu/drm/gma500/framebuffer.c +++ b/drivers/gpu/drm/gma500/framebuffer.c @@ -401,7 +401,6 @@ static int psbfb_create(struct psb_fbdev *fbdev, fbdev->psb_fb_helper.fb = fb; - info->flags = FBINFO_DEFAULT; if (dev_priv->ops->accel_2d && pitch_lines > 8) /* 2D engine */ info->fbops = &psbfb_ops; else if (gtt_roll) { /* GTT rolling seems best */ diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c b/drivers/gpu/drm/nouveau/nouveau_fbcon.c index 3a3d454b65e3..1136ee26005f 100644 --- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c +++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c @@ -370,9 +370,9 @@ nouveau_fbcon_create(struct drm_fb_helper *helper, fbcon->helper.fb = &fb->base; if (!chan) - info->flags = FBINFO_DEFAULT | FBINFO_HWACCEL_DISABLED; + info->flags = FBINFO_HWACCEL_DISABLED; else - info->flags = FBINFO_DEFAULT | FBINFO_HWACCEL_COPYAREA | + info->flags = FBINFO_HWACCEL_COPYAREA | FBINFO_HWACCEL_FILLRECT | FBINFO_HWACCEL_IMAGEBLIT; info->fbops = &nouveau_fbcon_sw_ops; diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c index d12164878e05..fed7d7698164 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c @@ -90,7 +90,6 @@ static int rockchip_drm_fbdev_create(struct drm_fb_helper *helper, goto out; } - fbi->flags = FBINFO_FLAG_DEFAULT; fbi->fbops = &rockchip_drm_fbdev_ops; fb = helper->fb; diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c index 82348ddd0b83..ea82184073bd 100644 --- a/drivers/gpu/drm/tegra/fb.c +++ b/drivers/gpu/drm/tegra/fb.c @@ -255,7 +255,6 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper, helper->fb = fb; helper->fbdev = info; - info->flags = FBINFO_FLAG_DEFAULT; info->fbops = &tegra_fb_ops; drm_fb_helper_fill_info(info, helper); -- 2.20.1 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 26/26] drm/<drivers>: Don't set FBINFO_(FLAG_)DEFAULT 2019-01-24 16:58 ` [PATCH 26/26] drm/<drivers>: Don't set FBINFO_(FLAG_)DEFAULT Daniel Vetter @ 2019-01-25 15:02 ` Emil Velikov 2019-01-29 9:58 ` [Intel-gfx] " Daniel Vetter 2019-01-25 15:14 ` Thierry Reding 1 sibling, 1 reply; 6+ messages in thread From: Emil Velikov @ 2019-01-25 15:02 UTC (permalink / raw) To: Daniel Vetter Cc: moderated list:ARM/S5P EXYNOS AR..., Heiko Stübner, Bartlomiej Zolnierkiewicz, ML nouveau, Intel Graphics Development, Seung-Woo Kim, Sandy Huang, Krzysztof Kozlowski, Jonathan Hunter, Inki Dae, linux-rockchip, Kyungmin Park, Kukjin Kim, DRI Development, Alexander Kapshuk, Greg Kroah-Hartman, linux-tegra, Daniel Vetter, Ben Skeggs, LAKML On Thu, 24 Jan 2019 at 17:00, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > > It's 0. > I'd add a bit more information here. Feel free to reuse as much/little of the following: Both macros evaluate to 0. At the same time flag is already set to zero since the struct is kzalloc'd in framebuffer_alloc(). As called by drm_fb_helper_alloc_fbi() in the DRM drivers. -Emil _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH 26/26] drm/<drivers>: Don't set FBINFO_(FLAG_)DEFAULT 2019-01-25 15:02 ` Emil Velikov @ 2019-01-29 9:58 ` Daniel Vetter 0 siblings, 0 replies; 6+ messages in thread From: Daniel Vetter @ 2019-01-29 9:58 UTC (permalink / raw) To: Emil Velikov Cc: Daniel Vetter, DRI Development, Daniel Vetter, moderated list:ARM/S5P EXYNOS AR..., Krzysztof Kozlowski, Jonathan Hunter, linux-rockchip, Kukjin Kim, Ben Skeggs, ML nouveau, Alexander Kapshuk, Bartlomiej Zolnierkiewicz, Intel Graphics Development, linux-tegra, LAKML, Greg Kroah-Hartman, Seung-Woo Kim, Kyungmin Park On Fri, Jan 25, 2019 at 03:02:46PM +0000, Emil Velikov wrote: > On Thu, 24 Jan 2019 at 17:00, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > > > > It's 0. > > > I'd add a bit more information here. Feel free to reuse as much/little > of the following: > > Both macros evaluate to 0. At the same time flag is already set to > zero since the struct is kzalloc'd in framebuffer_alloc(). > As called by drm_fb_helper_alloc_fbi() in the DRM drivers. Added&merged, thanks for your review. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 26/26] drm/<drivers>: Don't set FBINFO_(FLAG_)DEFAULT 2019-01-24 16:58 ` [PATCH 26/26] drm/<drivers>: Don't set FBINFO_(FLAG_)DEFAULT Daniel Vetter 2019-01-25 15:02 ` Emil Velikov @ 2019-01-25 15:14 ` Thierry Reding 1 sibling, 0 replies; 6+ messages in thread From: Thierry Reding @ 2019-01-25 15:14 UTC (permalink / raw) To: Daniel Vetter Cc: Heiko Stübner, nouveau, DRI Development, Krzysztof Kozlowski, Daniel Vetter, linux-samsung-soc, Joonyoung Shim, Jonathan Hunter, linux-rockchip, Kukjin Kim, Ben Skeggs, Alexander Kapshuk, Bartlomiej Zolnierkiewicz, Intel Graphics Development, Inki Dae, linux-tegra, linux-arm-kernel, Greg Kroah-Hartman, Seung-Woo Kim, Sandy Huang, Kyungmin Park [-- Attachment #1.1: Type: text/plain, Size: 1522 bytes --] On Thu, Jan 24, 2019 at 05:58:31PM +0100, Daniel Vetter wrote: > It's 0. > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > Cc: Inki Dae <inki.dae@samsung.com> > Cc: Joonyoung Shim <jy0922.shim@samsung.com> > Cc: Seung-Woo Kim <sw0312.kim@samsung.com> > Cc: Kyungmin Park <kyungmin.park@samsung.com> > Cc: Kukjin Kim <kgene@kernel.org> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> > Cc: Ben Skeggs <bskeggs@redhat.com> > Cc: Sandy Huang <hjc@rock-chips.com> > Cc: "Heiko Stübner" <heiko@sntech.de> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Jonathan Hunter <jonathanh@nvidia.com> > Cc: Hans de Goede <hdegoede@redhat.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > Cc: Alexander Kapshuk <alexander.kapshuk@gmail.com> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: nouveau@lists.freedesktop.org > Cc: linux-rockchip@lists.infradead.org > Cc: linux-tegra@vger.kernel.org > --- > drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 1 - > drivers/gpu/drm/gma500/framebuffer.c | 1 - > drivers/gpu/drm/nouveau/nouveau_fbcon.c | 4 ++-- > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 1 - > drivers/gpu/drm/tegra/fb.c | 1 - > 5 files changed, 2 insertions(+), 6 deletions(-) Acked-by: Thierry Reding <treding@nvidia.com> [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-01-29 9:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190124165831.16427-1-daniel.vetter@ffwll.ch>
2019-01-24 16:58 ` [PATCH 22/26] drm/qxl: Use drm_fb_helper_fill_info Daniel Vetter
2019-01-25 15:14 ` Thierry Reding
[not found] ` <20190124165831.16427-1-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2019-01-24 16:58 ` [PATCH 26/26] drm/<drivers>: Don't set FBINFO_(FLAG_)DEFAULT Daniel Vetter
2019-01-25 15:02 ` Emil Velikov
2019-01-29 9:58 ` [Intel-gfx] " Daniel Vetter
2019-01-25 15:14 ` Thierry Reding
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).