Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

Rafael J. Wysocki
2019-02-05T11:34:46Z

On Monday, February 4, 2019 11:04:50 AM CET Jon Hunter wrote:
>
> On 04/02/2019 08:16, Sameer Pujar wrote:
>
> ...
>
> > Objective is to have things working with or without CONFIG_PM enabled.
> > From previous comments and discussions it appears that there is mixed
> > response
> > for calling hda_tegra_runtime_resume() or runtime PM APIs in probe()
> > call. Need
> > to have consensus regarding the best practice to be followed, which
> > would eventually
> > can be used in other drivers too.
> >
> > Rafael is suggesting to use CONFIG_PM check to do manual setup or
> > runtime PM setup in probe,
> > which would bring back the earlier above mentioned concern.
> >
> > if (IS_ENABLED(CONFIG_PM)) {
> > do setup based on pm-runtime
> > } else {
> > do manual setup
> > }
> > Both if/else might end up doing the same here.
> > Do we really need CONFIG_PM check here?
> >
> > Instead does below proposal appear fine?
> >
> > probe() {
> > hda_tegra_enable_clock();
> > }
> >
> > probe_work() {
> > /* hda setup */
> > . . .
> > pm_runtime_set_active(); /* initial state as active */
> > pm_runtime_enable();
> > return;
> > }
>
> I believe that this still does not work, because if there is a
> power-domain that needs to be turned on, this does not guarantee this.
> So I think that you need to call pm_runtime_get ...
>
> probe() {
> if (!IS_ENABLED(CONFIG_PM))
> hda_tegra_enable_clock();
> }
>

But alas, there are no PM domains with CONFIG_PM unset.

CONFIG_PM unset means that the *driver* has to know how to turn on the
device and that has to be sufficient.

Which basically is my point when I'm saying that this information is
not available to the core and it cannot do anything to handle this
case without the extra knowledge.

Thanks,
Rafael