From: Wolfram Sang <wsa@the-dreams.de>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Tristan Bastian <tristan-c.bastian@gmx.de>,
Vlado Plaga <rechner@vlado-do.de>,
dri-devel@lists.freedesktop.org, Rob Herring <robh+dt@kernel.org>,
linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v2] i2c: of: Try to find an I2C adapter matching the parent
Date: Wed, 6 Feb 2019 10:49:12 +0100 [thread overview]
Message-ID: <20190206094912.nnfsfzivwbss4yye@ninjato> (raw)
In-Reply-To: <20190206093851.5sxretbl7ajizi5f@ninjato>
[-- Attachment #1.1: Type: text/plain, Size: 795 bytes --]
> And there is a regression! Good that I didn't push out before
> double-checking. No one noticed that this breaks registering child
> devices because of_i2c_register_devices() doesn't have a pointer to work
> with anymore?
Well, sorry, I forgot an important detail. There is no regression
because most drivers still populate adap->dev.of_data with the node
pointer of their parent. I experimentally removed this from my driver
under test motivated by this comment from the commit in the Fixes: tag:
"Linking it to the device node of the parent device is wrong, as it
leads to 2 devices sharing the same device node, which is bad practice,"
But removing this bad practice from I2C core is more work. I wonder now
if we are in some inconsistent in-between state if I apply this patch as
is?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-02-06 9:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 13:11 [PATCH v2] i2c: of: Try to find an I2C adapter matching the parent Thierry Reding
2019-01-26 12:37 ` Tristan Bastian
2019-01-28 8:08 ` Thierry Reding
2019-01-28 8:10 ` Thierry Reding
2019-01-28 9:19 ` Tristan Bastian
2019-01-28 9:26 ` Tristan Bastian
2019-02-05 12:44 ` Wolfram Sang
2019-02-06 9:38 ` Wolfram Sang
2019-02-06 9:49 ` Wolfram Sang [this message]
2019-02-06 12:07 ` Thierry Reding
2019-02-08 18:35 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190206094912.nnfsfzivwbss4yye@ninjato \
--to=wsa@the-dreams.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rechner@vlado-do.de \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tristan-c.bastian@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox