From: Wolfram Sang <wsa@the-dreams.de>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Peter Rosin <peda@axentia.se>,
Sowjanya Komatineni <skomatineni@nvidia.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"jonathanh@nvidia.com" <jonathanh@nvidia.com>,
"mkarthik@nvidia.com" <mkarthik@nvidia.com>,
"smohammed@nvidia.com" <smohammed@nvidia.com>,
"talho@nvidia.com" <talho@nvidia.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH V19 1/7] i2c: tegra: sort all the include headers alphabetically
Date: Wed, 13 Feb 2019 09:35:20 +0100 [thread overview]
Message-ID: <20190213083519.tynjs3ef6tnvvsms@ninjato> (raw)
In-Reply-To: <cdb66da2-4886-e3ba-e78e-264bd4b5b73c@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 673 bytes --]
> > "^ Header removal should be mentioned in the commit message, I think."
> > - Wolfram Sang [0]
> >
> > Cheers,
> > Peter
> >
> > [0] https://lkml.org/lkml/2019/2/11/375
> >
>
> It could make sense to adjust the comment only if there will be
> anything else worthwhile a new revision, otherwise it is
> not-so-important.
Not quite. Addressing review comments and proper commit messages are
both important. So, it needs to be fixed. Yes, I can fix this small
issue locally here (and I will do this, so no need to resend), but this
is ultimately my decision (which you can surely ask for but not
rely on).
I'll apply this series later today.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-02-13 8:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 19:06 [PATCH V19 1/7] i2c: tegra: sort all the include headers alphabetically Sowjanya Komatineni
2019-02-12 19:06 ` [PATCH V19 2/7] i2c: tegra: add bus clear Master Support Sowjanya Komatineni
2019-02-12 19:06 ` [PATCH V19 3/7] i2c: tegra: fix maximum transfer size Sowjanya Komatineni
2019-02-12 19:06 ` [PATCH V19 4/7] i2c: tegra: update " Sowjanya Komatineni
2019-02-12 19:06 ` [PATCH V19 5/7] i2c: tegra: Add DMA support Sowjanya Komatineni
2019-02-14 16:53 ` Wolfram Sang
2019-02-20 18:02 ` Jon Hunter
2019-02-20 18:05 ` Dmitry Osipenko
2019-02-12 19:06 ` [PATCH V19 6/7] i2c: tegra: update transfer timeout Sowjanya Komatineni
2019-02-12 19:06 ` [PATCH V19 7/7] i2c: tegra: add i2c interface timing support Sowjanya Komatineni
2019-02-12 21:00 ` [PATCH V19 1/7] i2c: tegra: sort all the include headers alphabetically Peter Rosin
2019-02-12 21:15 ` Dmitry Osipenko
2019-02-13 8:35 ` Wolfram Sang [this message]
2019-02-13 13:13 ` Dmitry Osipenko
2019-02-13 14:55 ` Wolfram Sang
2019-02-13 23:45 ` Sowjanya Komatineni
2019-02-14 16:51 ` Wolfram Sang
2019-02-14 16:51 ` Wolfram Sang
-- strict thread matches above, loose matches on Subject: below --
2019-02-12 18:28 Sowjanya Komatineni
2019-02-12 18:27 Sowjanya Komatineni
2019-02-12 18:32 ` Sowjanya Komatineni
2019-02-12 18:42 ` Dmitry Osipenko
2019-02-12 18:45 ` Sowjanya Komatineni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213083519.tynjs3ef6tnvvsms@ninjato \
--to=wsa@the-dreams.de \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkarthik@nvidia.com \
--cc=peda@axentia.se \
--cc=skomatineni@nvidia.com \
--cc=smohammed@nvidia.com \
--cc=talho@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox