* [PATCH][next] i2c: tegra: change phrasing, "fallbacking" to "falling back"
@ 2019-02-15 15:31 Colin King
2019-02-15 15:32 ` Thierry Reding
2019-02-15 21:42 ` Wolfram Sang
0 siblings, 2 replies; 5+ messages in thread
From: Colin King @ 2019-02-15 15:31 UTC (permalink / raw)
To: Laxman Dewangan, Thierry Reding, Jonathan Hunter, linux-i2c,
linux-tegra
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The phrasing in two dev_err messages is using fallbacking which
os less understandable than "falling back", so fix this up.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/i2c/busses/i2c-tegra.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index a4cd79c9f7a7..5a403c3ab66c 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -452,7 +452,7 @@ static int tegra_i2c_init_dma(struct tegra_i2c_dev *i2c_dev)
tegra_i2c_release_dma(i2c_dev);
if (err != -EPROBE_DEFER) {
dev_err(i2c_dev->dev, "cannot use DMA: %d\n", err);
- dev_err(i2c_dev->dev, "fallbacking to PIO\n");
+ dev_err(i2c_dev->dev, "falling back to PIO\n");
return 0;
}
@@ -965,7 +965,7 @@ static void tegra_i2c_config_fifo_trig(struct tegra_i2c_dev *i2c_dev,
if (ret < 0) {
dev_err(i2c_dev->dev, "DMA slave config failed: %d\n",
ret);
- dev_err(i2c_dev->dev, "fallbacking to PIO\n");
+ dev_err(i2c_dev->dev, "falling back to PIO\n");
tegra_i2c_release_dma(i2c_dev);
i2c_dev->is_curr_dma_xfer = false;
} else {
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH][next] i2c: tegra: change phrasing, "fallbacking" to "falling back"
2019-02-15 15:31 [PATCH][next] i2c: tegra: change phrasing, "fallbacking" to "falling back" Colin King
@ 2019-02-15 15:32 ` Thierry Reding
2019-02-15 15:33 ` Colin Ian King
2019-02-15 21:42 ` Wolfram Sang
1 sibling, 1 reply; 5+ messages in thread
From: Thierry Reding @ 2019-02-15 15:32 UTC (permalink / raw)
To: Colin King
Cc: Laxman Dewangan, Jonathan Hunter, linux-i2c, linux-tegra,
kernel-janitors, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 319 bytes --]
On Fri, Feb 15, 2019 at 03:31:26PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The phrasing in two dev_err messages is using fallbacking which
> os less understandable than "falling back", so fix this up.
os -> is, otherwise:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][next] i2c: tegra: change phrasing, "fallbacking" to "falling back"
2019-02-15 15:32 ` Thierry Reding
@ 2019-02-15 15:33 ` Colin Ian King
2019-02-15 15:38 ` Wolfram Sang
0 siblings, 1 reply; 5+ messages in thread
From: Colin Ian King @ 2019-02-15 15:33 UTC (permalink / raw)
To: Thierry Reding
Cc: Laxman Dewangan, Jonathan Hunter, linux-i2c, linux-tegra,
kernel-janitors, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 435 bytes --]
On 15/02/2019 15:32, Thierry Reding wrote:
> On Fri, Feb 15, 2019 at 03:31:26PM +0000, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The phrasing in two dev_err messages is using fallbacking which
>> os less understandable than "falling back", so fix this up.
>
> os -> is, otherwise:
Oops, can that be fixed up when it's applied.
>
> Acked-by: Thierry Reding <treding@nvidia.com>
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][next] i2c: tegra: change phrasing, "fallbacking" to "falling back"
2019-02-15 15:33 ` Colin Ian King
@ 2019-02-15 15:38 ` Wolfram Sang
0 siblings, 0 replies; 5+ messages in thread
From: Wolfram Sang @ 2019-02-15 15:38 UTC (permalink / raw)
To: Colin Ian King
Cc: Thierry Reding, Laxman Dewangan, Jonathan Hunter, linux-i2c,
linux-tegra, kernel-janitors, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 467 bytes --]
On Fri, Feb 15, 2019 at 03:33:58PM +0000, Colin Ian King wrote:
> On 15/02/2019 15:32, Thierry Reding wrote:
> > On Fri, Feb 15, 2019 at 03:31:26PM +0000, Colin King wrote:
> >> From: Colin Ian King <colin.king@canonical.com>
> >>
> >> The phrasing in two dev_err messages is using fallbacking which
> >> os less understandable than "falling back", so fix this up.
> >
> > os -> is, otherwise:
>
> Oops, can that be fixed up when it's applied.
Yes.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][next] i2c: tegra: change phrasing, "fallbacking" to "falling back"
2019-02-15 15:31 [PATCH][next] i2c: tegra: change phrasing, "fallbacking" to "falling back" Colin King
2019-02-15 15:32 ` Thierry Reding
@ 2019-02-15 21:42 ` Wolfram Sang
1 sibling, 0 replies; 5+ messages in thread
From: Wolfram Sang @ 2019-02-15 21:42 UTC (permalink / raw)
To: Colin King
Cc: Laxman Dewangan, Thierry Reding, Jonathan Hunter, linux-i2c,
linux-tegra, kernel-janitors, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 344 bytes --]
On Fri, Feb 15, 2019 at 03:31:26PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The phrasing in two dev_err messages is using fallbacking which
> os less understandable than "falling back", so fix this up.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-02-15 21:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-15 15:31 [PATCH][next] i2c: tegra: change phrasing, "fallbacking" to "falling back" Colin King
2019-02-15 15:32 ` Thierry Reding
2019-02-15 15:33 ` Colin Ian King
2019-02-15 15:38 ` Wolfram Sang
2019-02-15 21:42 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox