From: Peter Zijlstra <peterz@infradead.org>
To: Ketan Patil <ketanp@nvidia.com>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org, snikam@nvidia.com,
bnihalani@nvidia.com, byan@nvidia.com, sgurrappadi@nvidia.com,
treding@nvidia.com, talho@nvidia.com
Subject: Re: [PATCH] sched/cputime: Remove unnecessary assignment statement
Date: Thu, 28 Feb 2019 10:47:33 +0100 [thread overview]
Message-ID: <20190228094733.GY32494@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <9bce6378-2221-f358-dc97-f15ee7ab546b@nvidia.com>
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
On Thu, Feb 28, 2019 at 03:12:13PM +0530, Ketan Patil wrote:
> The coverity tool has detected this issue as an unused value, since
> the code assigns the value to utime variable and then after the jump, the
> value of utime again gets updated, hence the previous value is not at all
> useful and this patch removes that first assignment.
Not a security issue then; just tell coverity to shut up.
next prev parent reply other threads:[~2019-02-28 9:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 6:13 [PATCH] sched/cputime: Remove unnecessary assignment statement Ketan Patil
2019-02-27 10:32 ` Peter Zijlstra
2019-02-28 9:42 ` Ketan Patil
2019-02-28 9:47 ` Peter Zijlstra [this message]
2019-02-28 12:14 ` Sachin Nikam
2019-02-28 12:31 ` Peter Zijlstra
2019-02-28 13:53 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190228094733.GY32494@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bnihalani@nvidia.com \
--cc=byan@nvidia.com \
--cc=ketanp@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sgurrappadi@nvidia.com \
--cc=snikam@nvidia.com \
--cc=talho@nvidia.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox