From: Peter Zijlstra <peterz@infradead.org>
To: Sachin Nikam <Snikam@nvidia.com>
Cc: Ketan Patil <ketanp@nvidia.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
Bharat Nihalani <bnihalani@nvidia.com>, Bo Yan <byan@nvidia.com>,
Sai Gurrappadi <sgurrappadi@nvidia.com>,
Thierry Reding <treding@nvidia.com>, Timo Alho <talho@nvidia.com>
Subject: Re: [PATCH] sched/cputime: Remove unnecessary assignment statement
Date: Thu, 28 Feb 2019 13:31:20 +0100 [thread overview]
Message-ID: <20190228123120.GA32494@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <MN2PR12MB3278E52D04119DC55597A293BB750@MN2PR12MB3278.namprd12.prod.outlook.com>
Clearly, because reading comprehension isn't your strong point:
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
On Thu, Feb 28, 2019 at 12:14:09PM +0000, Sachin Nikam wrote:
> This isn't a security fix.
> However, I see this is kind of code cleanup.
As I've explained previously, it makes conceptual sense to have it in
the code, and any halfway sane compiler will observe the same double
store and eliminate it in its DCE pass.
next prev parent reply other threads:[~2019-02-28 12:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 6:13 [PATCH] sched/cputime: Remove unnecessary assignment statement Ketan Patil
2019-02-27 10:32 ` Peter Zijlstra
2019-02-28 9:42 ` Ketan Patil
2019-02-28 9:47 ` Peter Zijlstra
2019-02-28 12:14 ` Sachin Nikam
2019-02-28 12:31 ` Peter Zijlstra [this message]
2019-02-28 13:53 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190228123120.GA32494@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Snikam@nvidia.com \
--cc=bnihalani@nvidia.com \
--cc=byan@nvidia.com \
--cc=ketanp@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sgurrappadi@nvidia.com \
--cc=talho@nvidia.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox