From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH] sched/cputime: Remove unnecessary assignment statement Date: Thu, 28 Feb 2019 13:31:20 +0100 Message-ID: <20190228123120.GA32494@hirez.programming.kicks-ass.net> References: <1551248002-27303-1-git-send-email-ketanp@nvidia.com> <20190227103230.GM32494@hirez.programming.kicks-ass.net> <9bce6378-2221-f358-dc97-f15ee7ab546b@nvidia.com> <20190228094733.GY32494@hirez.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Sachin Nikam Cc: Ketan Patil , "mingo@redhat.com" , "linux-kernel@vger.kernel.org" , "linux-tegra@vger.kernel.org" , Bharat Nihalani , Bo Yan , Sai Gurrappadi , Thierry Reding , Timo Alho List-Id: linux-tegra@vger.kernel.org Clearly, because reading comprehension isn't your strong point: A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? On Thu, Feb 28, 2019 at 12:14:09PM +0000, Sachin Nikam wrote: > This isn't a security fix. > However, I see this is kind of code cleanup. As I've explained previously, it makes conceptual sense to have it in the code, and any halfway sane compiler will observe the same double store and eliminate it in its DCE pass.