From: Thierry Reding <thierry.reding@gmail.com>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: JC Kuo <jckuo@nvidia.com>, Kishon Vijay Abraham I <kishon@ti.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] phy: tegra: xusb: fix typo in tegra186_usb2_pad_probe()
Date: Thu, 21 Mar 2019 16:05:37 +0100 [thread overview]
Message-ID: <20190321150537.GB8939@ulmo> (raw)
In-Reply-To: <20190321085436.94975-1-weiyongjun1@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]
On Thu, Mar 21, 2019 at 08:54:36AM +0000, Wei Yongjun wrote:
> Fix a typo in tegra186_usb2_pad_probe(), 'usb2->clk' should be
> 'priv->usb2_trk_clk'.
>
> Fixes: b8998e928030 ("phy: tegra: xusb: Add Tegra186 support")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/phy/tegra/xusb-tegra186.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Good catch!
Acked-by: Thierry Reding <treding@nvidia.com>
>
> diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/xusb-tegra186.c
> index 11ad6e4e4711..a627fe0b8e54 100644
> --- a/drivers/phy/tegra/xusb-tegra186.c
> +++ b/drivers/phy/tegra/xusb-tegra186.c
> @@ -467,8 +467,8 @@ tegra186_usb2_pad_probe(struct tegra_xusb_padctl *padctl,
> }
>
> priv->usb2_trk_clk = devm_clk_get(&pad->dev, "trk");
> - if (IS_ERR(usb2->clk)) {
> - err = PTR_ERR(usb2->clk);
> + if (IS_ERR(priv->usb2_trk_clk)) {
> + err = PTR_ERR(priv->usb2_trk_clk);
> dev_dbg(&pad->dev, "failed to get usb2 trk clock: %d\n", err);
> goto unregister;
> }
>
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-03-21 15:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 8:54 [PATCH -next] phy: tegra: xusb: fix typo in tegra186_usb2_pad_probe() Wei Yongjun
2019-03-21 15:05 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321150537.GB8939@ulmo \
--to=thierry.reding@gmail.com \
--cc=jckuo@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox