* [PATCH -next] phy: tegra: xusb: fix typo in tegra186_usb2_pad_probe()
@ 2019-03-21 8:54 Wei Yongjun
2019-03-21 15:05 ` Thierry Reding
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2019-03-21 8:54 UTC (permalink / raw)
To: JC Kuo, Kishon Vijay Abraham I, Thierry Reding, Jonathan Hunter
Cc: Wei Yongjun, linux-kernel, linux-tegra, kernel-janitors
Fix a typo in tegra186_usb2_pad_probe(), 'usb2->clk' should be
'priv->usb2_trk_clk'.
Fixes: b8998e928030 ("phy: tegra: xusb: Add Tegra186 support")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/phy/tegra/xusb-tegra186.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/xusb-tegra186.c
index 11ad6e4e4711..a627fe0b8e54 100644
--- a/drivers/phy/tegra/xusb-tegra186.c
+++ b/drivers/phy/tegra/xusb-tegra186.c
@@ -467,8 +467,8 @@ tegra186_usb2_pad_probe(struct tegra_xusb_padctl *padctl,
}
priv->usb2_trk_clk = devm_clk_get(&pad->dev, "trk");
- if (IS_ERR(usb2->clk)) {
- err = PTR_ERR(usb2->clk);
+ if (IS_ERR(priv->usb2_trk_clk)) {
+ err = PTR_ERR(priv->usb2_trk_clk);
dev_dbg(&pad->dev, "failed to get usb2 trk clock: %d\n", err);
goto unregister;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] phy: tegra: xusb: fix typo in tegra186_usb2_pad_probe()
2019-03-21 8:54 [PATCH -next] phy: tegra: xusb: fix typo in tegra186_usb2_pad_probe() Wei Yongjun
@ 2019-03-21 15:05 ` Thierry Reding
0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2019-03-21 15:05 UTC (permalink / raw)
To: Wei Yongjun
Cc: JC Kuo, Kishon Vijay Abraham I, Jonathan Hunter, linux-kernel,
linux-tegra, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]
On Thu, Mar 21, 2019 at 08:54:36AM +0000, Wei Yongjun wrote:
> Fix a typo in tegra186_usb2_pad_probe(), 'usb2->clk' should be
> 'priv->usb2_trk_clk'.
>
> Fixes: b8998e928030 ("phy: tegra: xusb: Add Tegra186 support")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/phy/tegra/xusb-tegra186.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Good catch!
Acked-by: Thierry Reding <treding@nvidia.com>
>
> diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/xusb-tegra186.c
> index 11ad6e4e4711..a627fe0b8e54 100644
> --- a/drivers/phy/tegra/xusb-tegra186.c
> +++ b/drivers/phy/tegra/xusb-tegra186.c
> @@ -467,8 +467,8 @@ tegra186_usb2_pad_probe(struct tegra_xusb_padctl *padctl,
> }
>
> priv->usb2_trk_clk = devm_clk_get(&pad->dev, "trk");
> - if (IS_ERR(usb2->clk)) {
> - err = PTR_ERR(usb2->clk);
> + if (IS_ERR(priv->usb2_trk_clk)) {
> + err = PTR_ERR(priv->usb2_trk_clk);
> dev_dbg(&pad->dev, "failed to get usb2 trk clock: %d\n", err);
> goto unregister;
> }
>
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-21 15:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-21 8:54 [PATCH -next] phy: tegra: xusb: fix typo in tegra186_usb2_pad_probe() Wei Yongjun
2019-03-21 15:05 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).