From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: [PATCH v1 3/8] PM / devfreq: tegra: Don't ignore clk errors
Date: Fri, 12 Apr 2019 01:29:09 +0300 [thread overview]
Message-ID: <20190411222914.25539-4-digetx@gmail.com> (raw)
In-Reply-To: <20190411222914.25539-1-digetx@gmail.com>
The clk_set_min_rate() could fail and in this case clk_set_rate() sets
rate to 0, which may drop EMC rate to minimum and make machine very
difficult to use.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/devfreq/tegra-devfreq.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c
index d749399f67ae..6185e7ab20a8 100644
--- a/drivers/devfreq/tegra-devfreq.c
+++ b/drivers/devfreq/tegra-devfreq.c
@@ -487,6 +487,7 @@ static int tegra_devfreq_target(struct device *dev, unsigned long *freq,
struct tegra_devfreq *tegra = dev_get_drvdata(dev);
struct dev_pm_opp *opp;
unsigned long rate;
+ int err;
opp = devfreq_recommended_opp(dev, freq, flags);
if (IS_ERR(opp)) {
@@ -496,8 +497,13 @@ static int tegra_devfreq_target(struct device *dev, unsigned long *freq,
rate = dev_pm_opp_get_freq(opp) * KHZ;
dev_pm_opp_put(opp);
- clk_set_min_rate(tegra->emc_clock, rate);
- clk_set_rate(tegra->emc_clock, 0);
+ err = clk_set_min_rate(tegra->emc_clock, rate);
+ if (err)
+ return err;
+
+ err = clk_set_rate(tegra->emc_clock, 0);
+ if (err)
+ return err;
return 0;
}
--
2.21.0
next prev parent reply other threads:[~2019-04-11 22:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 22:29 [PATCH v1 0/8] devfreq: Tegra devfreq fixes / improvements and Tegra30 support Dmitry Osipenko
2019-04-11 22:29 ` [PATCH v1 1/8] PM / devfreq: tegra: Fix kHz to Hz conversion Dmitry Osipenko
[not found] ` <20190412013413.4D52D20818@mail.kernel.org>
2019-04-12 10:14 ` Dmitry Osipenko
2019-04-12 16:56 ` Dmitry Osipenko
2019-04-11 22:29 ` [PATCH v1 2/8] PM / devfreq: tegra: Replace readl-writel with relaxed versions Dmitry Osipenko
2019-04-11 22:29 ` Dmitry Osipenko [this message]
2019-04-11 22:29 ` [PATCH v1 4/8] PM / devfreq: tegra: Don't release IRQ manually on driver removal Dmitry Osipenko
2019-04-11 22:29 ` [PATCH v1 5/8] PM / devfreq: tegra: Don't set EMC clock rate to maximum on probe Dmitry Osipenko
2019-04-11 22:29 ` [PATCH v1 6/8] PM / devfreq: tegra: Drop spinlock Dmitry Osipenko
2019-04-11 22:29 ` [PATCH v1 7/8] PM / devfreq: tegra: Remove OPP entries on driver removal Dmitry Osipenko
2019-04-11 22:29 ` [PATCH v1 8/8] PM / devfreq: tegra: Support Tegra30 Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411222914.25539-4-digetx@gmail.com \
--to=digetx@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=jonathanh@nvidia.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).