From: Dmitry Osipenko <digetx@gmail.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Joseph Lo <josephl@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 5/7] clocksource/drivers/tegra: Release all IRQ's on request_irq() error
Date: Sun, 5 May 2019 19:24:34 +0300 [thread overview]
Message-ID: <20190505162436.23125-6-digetx@gmail.com> (raw)
In-Reply-To: <20190505162436.23125-1-digetx@gmail.com>
Release all requested IRQ's on the request error to properly clean up
allocated resources.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/clocksource/timer-tegra20.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/clocksource/timer-tegra20.c b/drivers/clocksource/timer-tegra20.c
index cdac9e240714..7c06c0335fe3 100644
--- a/drivers/clocksource/timer-tegra20.c
+++ b/drivers/clocksource/timer-tegra20.c
@@ -291,7 +291,7 @@ static int __init tegra_init_timer(struct device_node *np, bool tegra20)
pr_err("%s: can't map IRQ for CPU%d\n",
__func__, cpu);
ret = -EINVAL;
- goto out;
+ goto out_irq;
}
irq_set_status_flags(cpu_to->clkevt.irq, IRQ_NOAUTOEN);
@@ -301,7 +301,8 @@ static int __init tegra_init_timer(struct device_node *np, bool tegra20)
if (ret) {
pr_err("%s: cannot setup irq %d for CPU%d\n",
__func__, cpu_to->clkevt.irq, cpu);
- ret = -EINVAL;
+ irq_dispose_mapping(cpu_to->clkevt.irq);
+ cpu_to->clkevt.irq = 0;
goto out_irq;
}
}
--
2.21.0
next prev parent reply other threads:[~2019-05-05 16:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-05 16:24 [PATCH v2 0/7] NVIDIA Tegra clocksource improvements and clean up Dmitry Osipenko
2019-05-05 16:24 ` [PATCH v2 1/7] clocksource/drivers/tegra: Support per-CPU timers on all Tegra's Dmitry Osipenko
2019-05-05 16:24 ` [PATCH v2 2/7] clocksource/drivers/tegra: Unify timer code Dmitry Osipenko
2019-05-05 16:24 ` [PATCH v2 3/7] clocksource/drivers/tegra: Reset hardware state on init Dmitry Osipenko
2019-05-05 16:24 ` [PATCH v2 4/7] clocksource/drivers/tegra: Replace readl/writel with relaxed versions Dmitry Osipenko
2019-05-05 16:24 ` Dmitry Osipenko [this message]
2019-05-05 16:24 ` [PATCH v2 6/7] clocksource/drivers/tegra: Minor code clean up Dmitry Osipenko
2019-05-05 16:24 ` [PATCH v2 7/7] clocksource/drivers/tegra: Use SPDX identifier Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190505162436.23125-6-digetx@gmail.com \
--to=digetx@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=jonathanh@nvidia.com \
--cc=josephl@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pdeschrijver@nvidia.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).