Re: [PATCH V3 5/8] memory: tegra: Add EMC scaling support code for Tegra210

Joseph Lo
2019-05-14T08:47:37Z

On 5/14/19 1:02 AM, Dmitry Osipenko wrote:
> 10.05.2019 11:47, Joseph Lo пишет:
>> This patch adds the required APIs and variables for the EMC scaling
>> sequence code on Tegra210.
>>
>> Based on the work of Peter De Schrijver <pdeschrijver@nvidia.com>.
>>
>> Signed-off-by: Joseph Lo <josephl@nvidia.com>
>> ---
snip.
>> +void do_clock_change(struct tegra_emc *emc, u32 clksrc)
>> +{
>> + int err;
>> +
>> + mc_readl(emc->mc, MC_EMEM_ADR_CFG);
>> + emc_readl(emc, EMC_INTSTATUS);
>> +
>> + tegra210_clk_emc_update_setting(clksrc);
>> +
>> + err = wait_for_update(emc, EMC_INTSTATUS,
>> + EMC_INTSTATUS_CLKCHANGE_COMPLETE, true, REG_EMC);
>> + if (err) {
>> + pr_err("%s: clock change completion error: %d", __func__, err);
>> + WARN_ON(1);
>> + }
>> +}
>> +
>> +struct emc_table *get_timing_from_freq(struct tegra_emc *emc,
>> + unsigned long rate)
>> +{
>> + int i;
>> +
>> + for (i = 0; i < emc->emc_table_size; i++)
>> + if (emc->emc_table[i].rate == rate)
>> + return &emc->emc_table[i];
>> +
>> + return NULL;
>> +}
>> +
>> +int wait_for_update(struct tegra_emc *emc, u32 status_reg, u32 bit_mask,
>> + bool updated_state, int chan)
>> +{
>
> This and all other global functions have very generic names. Either
> squash it all into a single source file and make all functions static,
> or change the names to something more unique.
>

Okay, will fix it.

Thanks,
Joseph