Re: [PATCH V3 5/8] memory: tegra: Add EMC scaling support code for Tegra210

Dmitry Osipenko
2019-05-15T15:26:50Z

10.05.2019 11:47, Joseph Lo пишет:
> This patch adds the required APIs and variables for the EMC scaling
> sequence code on Tegra210.
>
> Based on the work of Peter De Schrijver <pdeschrijver@nvidia.com>.
>
> Signed-off-by: Joseph Lo <josephl@nvidia.com>
> ---

> +
> +void do_clock_change(struct tegra_emc *emc, u32 clksrc)
> +{
> + int err;
> +
> + mc_readl(emc->mc, MC_EMEM_ADR_CFG);
> + emc_readl(emc, EMC_INTSTATUS);
> +
> + tegra210_clk_emc_update_setting(clksrc);
> +
> + err = wait_for_update(emc, EMC_INTSTATUS,
> + EMC_INTSTATUS_CLKCHANGE_COMPLETE, true, REG_EMC);
> + if (err) {
> + pr_err("%s: clock change completion error: %d", __func__, err);
> + WARN_ON(1);
> + }

Ether WARN(err, ...) or dev_warn, or just dev_err.

--
Dmitry