From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gen Zhang Subject: Re: [PATCH] tegra-hsp: fix a missing-check bug in tegra_hsp_doorbell_create() Date: Sun, 9 Jun 2019 00:11:44 +0800 Message-ID: <20190608161144.GA4090@zhanggen-UX430UQ> References: <20190530011920.GA6490@zhanggen-UX430UQ> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190530011920.GA6490@zhanggen-UX430UQ> Sender: linux-kernel-owner@vger.kernel.org To: jassisinghbrar@gmail.com Cc: thierry.reding@gmail.com, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org List-Id: linux-tegra@vger.kernel.org On Thu, May 30, 2019 at 09:19:20AM +0800, Gen Zhang wrote: > In tegra_hsp_doorbell_create(), 'db->name' is allocated by > devm_kstrdup_const(). It returns NULL when fails. So 'db->name' should > be checked. > > Signed-off-by: Gen Zhang > Acked-by: Thierry Reding > --- > diff --git a/drivers/mailbox/tegra-hsp.c b/drivers/mailbox/tegra-hsp.c > index 11fc9fd..b613c46 100644 > --- a/drivers/mailbox/tegra-hsp.c > +++ b/drivers/mailbox/tegra-hsp.c > @@ -292,6 +292,8 @@ tegra_hsp_doorbell_create(struct tegra_hsp *hsp, const char *name, > db->channel.hsp = hsp; > > db->name = devm_kstrdup_const(hsp->dev, name, GFP_KERNEL); > + if (!db->name) > + return ERR_PTR(-ENOMEM); > db->master = master; > db->index = index; > > --- Can anyone look into this patch? It's acked by Thierry Reding . Thanks Gen