From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nathan Huckleberry Subject: [PATCH] memory: tegra: Fix -Wunused-const-variable Date: Thu, 13 Jun 2019 10:27:46 -0700 Message-ID: <20190613172746.216819-1-nhuck@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Sender: linux-kernel-owner@vger.kernel.org To: thierry.reding@gmail.com, jonathanh@nvidia.com Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, Nathan Huckleberry , clang-built-linux@googlegroups.com List-Id: linux-tegra@vger.kernel.org Clang produces the following warning drivers/memory/tegra/tegra124.c:36:28: warning: unused variable 'tegra124_mc_emem_regs' [-Wunused-const-variable] static const unsigned long tegra124_mc_emem_regs[] = { ^ The only usage of this variable is from within an ifdef. It seems logical to move the variable into the ifdef as well. Cc: clang-built-linux@googlegroups.com Link: https://github.com/ClangBuiltLinux/linux/issues/526 Signed-off-by: Nathan Huckleberry --- drivers/memory/tegra/tegra124.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/memory/tegra/tegra124.c b/drivers/memory/tegra/tegra124.c index 8f8487bda642..8f2af5614595 100644 --- a/drivers/memory/tegra/tegra124.c +++ b/drivers/memory/tegra/tegra124.c @@ -33,6 +33,7 @@ #define MC_EMEM_ARB_MISC1 0xdc #define MC_EMEM_ARB_RING1_THROTTLE 0xe0 +#ifdef CONFIG_ARCH_TEGRA_124_SOC static const unsigned long tegra124_mc_emem_regs[] = { MC_EMEM_ARB_CFG, MC_EMEM_ARB_OUTSTANDING_REQ, @@ -54,6 +55,7 @@ static const unsigned long tegra124_mc_emem_regs[] = { MC_EMEM_ARB_MISC1, MC_EMEM_ARB_RING1_THROTTLE }; +#endif static const struct tegra_mc_client tegra124_mc_clients[] = { { -- 2.22.0.rc2.383.gf4fbbf30c2-goog