* Cleanup of -Wunused-const-variable in drivers/usb/host/xhci-tegra.c
@ 2019-06-13 18:38 Nathan Huckleberry
2019-06-13 18:44 ` Greg KH
2019-06-14 9:09 ` Thierry Reding
0 siblings, 2 replies; 3+ messages in thread
From: Nathan Huckleberry @ 2019-06-13 18:38 UTC (permalink / raw)
To: treding, mathias.nyman, gregkh, thierry.reding, jonathanh
Cc: linux-usb, linux-tegra, linux-kernel, clang-built-linux
Hey all,
I'm looking into cleaning up ignored warnings in the kernel so we can
remove compiler flags to ignore warnings.
There's an unused variable ('mbox_cmd_name') in xhci-tegra.c. Looks
like it was intended for logging or debugging, but never used. Just
wanted to reach out to ask the best steps for cleaning this up.
If the variable is no longer needed I'd like to send a patch to remove it.
https://github.com/ClangBuiltLinux/linux/issues/533
Thanks,
Nathan Huckleberry
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Cleanup of -Wunused-const-variable in drivers/usb/host/xhci-tegra.c
2019-06-13 18:38 Cleanup of -Wunused-const-variable in drivers/usb/host/xhci-tegra.c Nathan Huckleberry
@ 2019-06-13 18:44 ` Greg KH
2019-06-14 9:09 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2019-06-13 18:44 UTC (permalink / raw)
To: Nathan Huckleberry
Cc: treding, mathias.nyman, thierry.reding, jonathanh, linux-usb,
linux-tegra, linux-kernel, clang-built-linux
On Thu, Jun 13, 2019 at 11:38:38AM -0700, Nathan Huckleberry wrote:
> Hey all,
>
> I'm looking into cleaning up ignored warnings in the kernel so we can
> remove compiler flags to ignore warnings.
>
> There's an unused variable ('mbox_cmd_name') in xhci-tegra.c. Looks
> like it was intended for logging or debugging, but never used. Just
> wanted to reach out to ask the best steps for cleaning this up.
>
> If the variable is no longer needed I'd like to send a patch to remove it.
You never have to ask permission to send a patch :)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Cleanup of -Wunused-const-variable in drivers/usb/host/xhci-tegra.c
2019-06-13 18:38 Cleanup of -Wunused-const-variable in drivers/usb/host/xhci-tegra.c Nathan Huckleberry
2019-06-13 18:44 ` Greg KH
@ 2019-06-14 9:09 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2019-06-14 9:09 UTC (permalink / raw)
To: Nathan Huckleberry
Cc: mathias.nyman, gregkh, thierry.reding, jonathanh, linux-usb,
linux-tegra, linux-kernel, clang-built-linux
[-- Attachment #1: Type: text/plain, Size: 687 bytes --]
On Thu, Jun 13, 2019 at 11:38:38AM -0700, Nathan Huckleberry wrote:
> Hey all,
>
> I'm looking into cleaning up ignored warnings in the kernel so we can
> remove compiler flags to ignore warnings.
>
> There's an unused variable ('mbox_cmd_name') in xhci-tegra.c. Looks
> like it was intended for logging or debugging, but never used. Just
> wanted to reach out to ask the best steps for cleaning this up.
>
> If the variable is no longer needed I'd like to send a patch to remove it.
>
> https://github.com/ClangBuiltLinux/linux/issues/533
Feel free to send that patch. If we ever need this debug information
again we can easily add it back by reverting.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-14 9:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-13 18:38 Cleanup of -Wunused-const-variable in drivers/usb/host/xhci-tegra.c Nathan Huckleberry
2019-06-13 18:44 ` Greg KH
2019-06-14 9:09 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox