From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lorenzo Pieralisi Subject: Re: [PATCH] pci: tegra: use correct gpio/consumer.h header Date: Fri, 28 Jun 2019 11:46:30 +0100 Message-ID: <20190628104630.GA19883@e121166-lin.cambridge.arm.com> References: <20190628102953.2369879-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190628102953.2369879-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: Thierry Reding , Bjorn Helgaas , Jonathan Hunter , Manikanta Maddireddy , Thierry Reding , Vidya Sagar , linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-tegra@vger.kernel.org On Fri, Jun 28, 2019 at 12:29:45PM +0200, Arnd Bergmann wrote: > linux/gpio.h is not the correct header for modern interfaces and > causes a build failure without CONFIG_GPIOLIB: > > drivers/pci/controller/pci-tegra.c: In function 'tegra_pcie_port_reset': > drivers/pci/controller/pci-tegra.c:551:3: error: implicit declaration of function 'gpiod_set_value'; did you mean 'gpio_set_value'? [-Werror=implicit-function-declaration] > gpiod_set_value(port->reset_gpio, 1); > ^~~~~~~~~~~~~~~ > > Use linux/gpio/consumer.h instead. > > Fixes: 5e5e9c23f82a ("PCI: tegra: Add support for GPIO based PERST#") > Signed-off-by: Arnd Bergmann > --- > drivers/pci/controller/pci-tegra.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Squashed in the respective commit in pci/tegra, thanks for the fix Arnd. Lorenzo > diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c > index 9cc03a2549c0..1775b88c0aec 100644 > --- a/drivers/pci/controller/pci-tegra.c > +++ b/drivers/pci/controller/pci-tegra.c > @@ -17,7 +17,7 @@ > #include > #include > #include > -#include > +#include > #include > #include > #include > -- > 2.20.0 >