Re: [PATCH v4 13/24] PM / devfreq: tegra30: Constify structs

Chanwoo Choi
2019-07-16T12:26:34Z

On 19. 7. 8. 오전 7:32, Dmitry Osipenko wrote:
> Constify unmodifiable structs for consistency.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> drivers/devfreq/tegra30-devfreq.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
> index 1a10df5dbbed..2f59c78930bd 100644
> --- a/drivers/devfreq/tegra30-devfreq.c
> +++ b/drivers/devfreq/tegra30-devfreq.c
> @@ -106,7 +106,7 @@ enum tegra_actmon_device {
> MCCPU,
> };
>
> -static struct tegra_devfreq_device_config actmon_device_configs[] = {
> +static const struct tegra_devfreq_device_config actmon_device_configs[] = {
> {
> /* MCALL: All memory accesses (including from the CPUs) */
> .offset = 0x1c0,
> @@ -171,7 +171,7 @@ struct tegra_actmon_emc_ratio {
> unsigned long emc_freq;
> };
>
> -static struct tegra_actmon_emc_ratio actmon_emc_ratios[] = {
> +static const struct tegra_actmon_emc_ratio actmon_emc_ratios[] = {
> { 1400000, ULONG_MAX },
> { 1200000, 750000 },
> { 1100000, 600000 },
> @@ -210,7 +210,7 @@ static inline unsigned long do_percent(unsigned long val, unsigned int pct)
>
> static unsigned long actmon_cpu_to_emc_rate(struct tegra_devfreq *tegra)
> {
> - struct tegra_actmon_emc_ratio *ratio = actmon_emc_ratios;
> + const struct tegra_actmon_emc_ratio *ratio = actmon_emc_ratios;
> unsigned int cpu_freq = cpufreq_get(0);
> unsigned int i;
>
>

Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

--
Best Regards,
Chanwoo Choi
Samsung Electronics