Re: [PATCH v4 12/24] PM / devfreq: tegra30: Inline all one-line functions

Chanwoo Choi
2019-07-16T12:26:11Z

Hi Dmitry,

I'm not sure that it is necessary.
As I knew, usally, the 'inline' is used on header file
to define the empty functions.

Do we have to change it with 'inline' keyword?

On 19. 7. 8. 오전 7:32, Dmitry Osipenko wrote:
> Depending on a kernel's configuration, a single line functions may not be
> inlined by compiler (like enabled ftracing for example). Let's inline such
> functions explicitly for consistency.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> drivers/devfreq/tegra30-devfreq.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
> index c6c4a07d3e07..1a10df5dbbed 100644
> --- a/drivers/devfreq/tegra30-devfreq.c
> +++ b/drivers/devfreq/tegra30-devfreq.c
> @@ -181,28 +181,29 @@ static struct tegra_actmon_emc_ratio actmon_emc_ratios[] = {
> { 250000, 100000 },
> };
>
> -static u32 actmon_readl(struct tegra_devfreq *tegra, u32 offset)
> +static inline u32 actmon_readl(struct tegra_devfreq *tegra, u32 offset)
> {
> return readl_relaxed(tegra->regs + offset);
> }
>
> -static void actmon_writel(struct tegra_devfreq *tegra, u32 val, u32 offset)
> +static inline void actmon_writel(struct tegra_devfreq *tegra,
> + u32 val, u32 offset)
> {
> writel_relaxed(val, tegra->regs + offset);
> }
>
> -static u32 device_readl(struct tegra_devfreq_device *dev, u32 offset)
> +static inline u32 device_readl(struct tegra_devfreq_device *dev, u32 offset)
> {
> return readl_relaxed(dev->regs + offset);
> }
>
> -static void device_writel(struct tegra_devfreq_device *dev, u32 val,
> - u32 offset)
> +static inline void device_writel(struct tegra_devfreq_device *dev,
> + u32 val, u32 offset)
> {
> writel_relaxed(val, dev->regs + offset);
> }
>
> -static unsigned long do_percent(unsigned long val, unsigned int pct)
> +static inline unsigned long do_percent(unsigned long val, unsigned int pct)
> {
> return val * pct / 100;
> }
>

--
Best Regards,
Chanwoo Choi
Samsung Electronics