From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH v4 16/23] drm/mgag200: Provide ddc symlink in connector sysfs directory Date: Tue, 23 Jul 2019 11:07:52 +0200 Message-ID: <20190723090752.GB787@ravnborg.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Andrzej Pietrasiewicz Cc: dri-devel@lists.freedesktop.org, Neil Armstrong , Maxime Ripard , Douglas Anderson , Thierry Reding , Laurent Pinchart , kernel@collabora.com, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Vincent Abriou , Krzysztof Kozlowski , Jonathan Hunter , David Airlie , Chen-Yu Tsai , Kukjin Kim , NXP Linux Team , Dave Airlie , intel-gfx@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, Jonas Karlman List-Id: linux-tegra@vger.kernel.org Hi Andrzej. On Thu, Jul 11, 2019 at 01:26:43PM +0200, Andrzej Pietrasiewicz wrote: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/gpu/drm/mgag200/mgag200_mode.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c > index a25054015e8c..8fb9444b2142 100644 > --- a/drivers/gpu/drm/mgag200/mgag200_mode.c > +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c > @@ -1703,6 +1703,11 @@ static struct drm_connector *mga_vga_init(struct drm_device *dev) > return NULL; > > connector = &mga_connector->base; > + mga_connector->i2c = mgag200_i2c_create(dev); > + if (!mga_connector->i2c) > + DRM_ERROR("failed to add ddc bus\n"); > + > + connector->ddc = &mga_connector->i2c->adapter; > > drm_connector_init(dev, connector, > &mga_vga_connector_funcs, DRM_MODE_CONNECTOR_VGA); Like on other patch, assigning connector->ddc before drm_connector_init() looks wrong. Sam