From: Thierry Reding <thierry.reding@gmail.com>
To: Jon Hunter <jonathanh@nvidia.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] mailbox: tegra: Fix superfluous IRQ error message
Date: Mon, 14 Oct 2019 15:24:58 +0200 [thread overview]
Message-ID: <20191014132458.GG422231@ulmo> (raw)
In-Reply-To: <20191011083459.11551-1-jonathanh@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1514 bytes --]
On Fri, Oct 11, 2019 at 09:34:59AM +0100, Jon Hunter wrote:
> Commit 7723f4c5ecdb ("driver core: platform: Add an error message to
> platform_get_irq*()") added an error message to avoid drivers having
> to print an error message when IRQ lookup fails. However, there are
> some cases where IRQs are optional and so new optional versions of
> the platform_get_irq*() APIs have been added for these cases.
>
> The IRQs for Tegra HSP module are optional because not all instances
> of the module have the doorbell and all of the shared interrupts.
> Hence, since the above commit was applied the following error messages
> are now seen on Tegra194 ...
>
> ERR KERN tegra-hsp c150000.hsp: IRQ doorbell not found
> ERR KERN tegra-hsp c150000.hsp: IRQ shared0 not found
>
> The Tegra HSP driver deliberately does not fail if these are not found
> and so fix the above errors by updating the Tegra HSP driver to use
> the platform_get_irq_byname_optional() API.
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> drivers/mailbox/tegra-hsp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Perhaps Greg should pick up this patch because he's carrying the patch
that adds the platform_get_irq_byname_optional() patch for v5.5.
Greg, would you prefer a copy of this in your mailbox, or does the
following patchwork link suffice:
http://patchwork.ozlabs.org/patch/1175012/
Either way, this patch:
Acked-by: Thierry Reding <treding@nvidia.com>
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-10-14 13:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 8:34 [PATCH] mailbox: tegra: Fix superfluous IRQ error message Jon Hunter
2019-10-14 8:14 ` kbuild test robot
2019-10-14 13:24 ` Thierry Reding [this message]
2019-11-12 12:02 ` Jon Hunter
2019-11-12 14:07 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014132458.GG422231@ulmo \
--to=thierry.reding@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jassisinghbrar@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox