From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manivannan Sadhasivam Subject: Re: [PATCH -next 26/30] pinctrl: bm1880: use devm_platform_ioremap_resource() to simplify code Date: Thu, 17 Oct 2019 18:30:44 +0530 Message-ID: <20191017130044.GB25046@mani> References: <20191017122640.22976-1-yuehaibing@huawei.com> <20191017122640.22976-27-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20191017122640.22976-27-yuehaibing@huawei.com> Sender: linux-kernel-owner@vger.kernel.org To: YueHaibing Cc: linus.walleij@linaro.org, afaerber@suse.de, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, jesper.nilsson@axis.com, lars.persson@axis.com, ludovic.desroches@microchip.com, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, baruch@tkos.co.il, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@axis.com, linux-oxnas@groups.io, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, vz@mleia.com, narmstrong@baylibre.com, geert+renesas@glider.be, daniel@zonque.org, haojian.zhuang@gmail.com, wens@csie.org, thierry.reding@gmail.com, jonathanh@nvidia.com, agross@kernel.org List-Id: linux-tegra@vger.kernel.org On Thu, Oct 17, 2019 at 08:26:36PM +0800, YueHaibing wrote: > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Signed-off-by: YueHaibing Acked-by: Manivannan Sadhasivam Thanks, Mani > --- > drivers/pinctrl/pinctrl-bm1880.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-bm1880.c b/drivers/pinctrl/pinctrl-bm1880.c > index 63b130c..f7dff4f 100644 > --- a/drivers/pinctrl/pinctrl-bm1880.c > +++ b/drivers/pinctrl/pinctrl-bm1880.c > @@ -1308,15 +1308,13 @@ static struct pinctrl_desc bm1880_desc = { > static int bm1880_pinctrl_probe(struct platform_device *pdev) > > { > - struct resource *res; > struct bm1880_pinctrl *pctrl; > > pctrl = devm_kzalloc(&pdev->dev, sizeof(*pctrl), GFP_KERNEL); > if (!pctrl) > return -ENOMEM; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - pctrl->base = devm_ioremap_resource(&pdev->dev, res); > + pctrl->base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(pctrl->base)) > return PTR_ERR(pctrl->base); > > -- > 2.7.4 > >