From: Thierry Reding <thierry.reding@gmail.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: pdeschrijver@nvidia.com, pgaikwad@nvidia.com,
mturquette@baylibre.com, sboyd@kernel.org, treding@nvidia.com,
jonathanh@nvidia.com, skomatineni@nvidia.com, digetx@gmail.com,
linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] clk: tegra: Fix build error without CONFIG_PM_SLEEP
Date: Fri, 1 Nov 2019 10:50:08 +0100 [thread overview]
Message-ID: <20191101095008.GB1167505@ulmo> (raw)
In-Reply-To: <20191030125650.36776-1-yuehaibing@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 896 bytes --]
On Wed, Oct 30, 2019 at 08:56:50PM +0800, YueHaibing wrote:
> If CONFIG_PM_SLEEP is n, build fails:
>
> drivers/clk/tegra/clk-tegra210.c:3426:13: error:
> tegra210_clk_suspend undeclared here (not in a function); did you mean tegra_clk_ndspeed?
> .suspend = tegra210_clk_suspend,
> ^~~~~~~~~~~~~~~~~~~~
> tegra_clk_ndspeed
> drivers/clk/tegra/clk-tegra210.c:3427:12: error:
> tegra210_clk_resume undeclared here (not in a function); did you mean tegra210_clk_suspend?
> .resume = tegra210_clk_resume,
>
> Use ifdef to guard this.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 27d10d548c04 ("clk: tegra: Add suspend and resume support on Tegra210")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/clk/tegra/clk-tegra210.c | 2 ++
> 1 file changed, 2 insertions(+)
Applied to for-5.5/clk, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-11-01 9:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 12:56 [PATCH -next] clk: tegra: Fix build error without CONFIG_PM_SLEEP YueHaibing
2019-11-01 9:50 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191101095008.GB1167505@ulmo \
--to=thierry.reding@gmail.com \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=sboyd@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=treding@nvidia.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox