From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 01/12] memory: tegra: Add gr2d and gr3d to DRM IOMMU group Date: Fri, 1 Nov 2019 10:56:53 +0100 Message-ID: <20191101095653.GC1167505@ulmo> References: <20191028123718.3890217-1-thierry.reding@gmail.com> <20191028123718.3890217-2-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0889760758==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dmitry Osipenko Cc: linux-tegra@vger.kernel.org, Sachin Nikam , Puneet Saxena , dri-devel@lists.freedesktop.org List-Id: linux-tegra@vger.kernel.org --===============0889760758== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="c3bfwLpm8qysLVxt" Content-Disposition: inline --c3bfwLpm8qysLVxt Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 30, 2019 at 06:05:48PM +0300, Dmitry Osipenko wrote: > 28.10.2019 15:37, Thierry Reding =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > From: Thierry Reding > >=20 > > All of the devices making up the Tegra DRM device want to share a single > > IOMMU domain. Put them into a single group to allow them to do that. > >=20 > > Signed-off-by: Thierry Reding > > --- > > drivers/memory/tegra/tegra114.c | 10 ++++++---- > > drivers/memory/tegra/tegra124.c | 8 +++++--- > > drivers/memory/tegra/tegra30.c | 11 +++++++---- > > 3 files changed, 18 insertions(+), 11 deletions(-) > >=20 > > diff --git a/drivers/memory/tegra/tegra114.c b/drivers/memory/tegra/teg= ra114.c > > index ac8351b5beeb..48ef01c3ff90 100644 > > --- a/drivers/memory/tegra/tegra114.c > > +++ b/drivers/memory/tegra/tegra114.c > > @@ -909,16 +909,18 @@ static const struct tegra_smmu_swgroup tegra114_s= wgroups[] =3D { > > { .name =3D "tsec", .swgroup =3D TEGRA_SWGROUP_TSEC, .reg = =3D 0x294 }, > > }; > > =20 > > -static const unsigned int tegra114_group_display[] =3D { > > +static const unsigned int tegra114_group_drm[] =3D { > > TEGRA_SWGROUP_DC, > > TEGRA_SWGROUP_DCB, > > + TEGRA_SWGROUP_G2, > > + TEGRA_SWGROUP_NV, > > }; > > =20 > > static const struct tegra_smmu_group_soc tegra114_groups[] =3D { > > { > > - .name =3D "display", > > - .swgroups =3D tegra114_group_display, > > - .num_swgroups =3D ARRAY_SIZE(tegra114_group_display), > > + .name =3D "drm", > > + .swgroups =3D tegra114_group_drm, > > + .num_swgroups =3D ARRAY_SIZE(tegra114_group_drm), > > }, > > }; > > =20 > > diff --git a/drivers/memory/tegra/tegra124.c b/drivers/memory/tegra/teg= ra124.c > > index 5d0ccb2be206..62b30b1b9677 100644 > > --- a/drivers/memory/tegra/tegra124.c > > +++ b/drivers/memory/tegra/tegra124.c > > @@ -974,16 +974,18 @@ static const struct tegra_smmu_swgroup tegra124_s= wgroups[] =3D { > > { .name =3D "vi", .swgroup =3D TEGRA_SWGROUP_VI, .reg = =3D 0x280 }, > > }; > > =20 > > -static const unsigned int tegra124_group_display[] =3D { > > +static const unsigned int tegra124_group_drm[] =3D { > > TEGRA_SWGROUP_DC, > > TEGRA_SWGROUP_DCB, > > + TEGRA_SWGROUP_GPU, > > + TEGRA_SWGROUP_VIC, > > }; > > =20 > > static const struct tegra_smmu_group_soc tegra124_groups[] =3D { > > { > > .name =3D "display", > > - .swgroups =3D tegra124_group_display, > > - .num_swgroups =3D ARRAY_SIZE(tegra124_group_display), > > + .swgroups =3D tegra124_group_drm, > > + .num_swgroups =3D ARRAY_SIZE(tegra124_group_drm), > > }, >=20 > The "display" -> "drm" group's renaming is missed for T124. Good catch! Fixed now. Thanks, Thierry --c3bfwLpm8qysLVxt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl28AWUACgkQ3SOs138+ s6Hgeg//cE3dME4iIyDtptvAGYmKg/XaVbnA2XacCB42XLQuejaNf+Py0656pl9S HyvF4syLPuA5yP4gZk3LnTU+iaEk6FEFK4W7fJ4ymQUfVkfIY+BrHYcygNbAQTk5 WvrvUhct8FrswisLeCbmMBaJWSv3tybQRTTU97RQVltj90+EhdY8I6F4Wz5bRlP8 ED3qAJPigoYlok9VCQh8iS2Ji1chle8/tcqWjZpP+hBawoIZ8Lt7KGe+OUVNJ8DG m/9e8OXr00NhTIwlKgjxAr9qRUJN2Yi6cWcZtzkWRTajV4fjpUNEQZvM6MBi2D+S Fb6dt8tLK7ujr0Cp/cmUcejxhTO8bOBF1uNUGbY1EU4QCseqgBp0noivhpNginPO Y2/cIurgJ2IQpj736gD0utRyDRJw5Hmdta4KLTURFCGY9bJYv9/2XXxrHmKAjHP6 aWA6xWQkprTXI25FtCTcFTLHMRoGFbUWQLpTs0V8SSTrsQ62kROQVlnN8JMMT829 pUNsHYGm6o9kCpCvBJa1N+n8f4L4L7rWw05vktZj9r0iyry6lLeM2qdjw8Y8MEr5 gvwS6LSljib3qXsi4suDUFzuT75FwYdVM6GwwyeIDTc7ey4//1c+QH71OVp2m0/D 8jf78o6yw5sHvF81xEXT2lVjH1xIZkpb6jKqedeUa+NvsQyLT+k= =Fin/ -----END PGP SIGNATURE----- --c3bfwLpm8qysLVxt-- --===============0889760758== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0889760758==--