From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Shyti Subject: Re: [PATCH 7/9] spi: s3c64xx: Use dma_request_chan() directly for channel request Date: Thu, 14 Nov 2019 11:12:30 +0200 Message-ID: <20191114091230.GB1249@jack.zhora.eu> References: <20191113094256.1108-1-peter.ujfalusi@ti.com> <20191113094256.1108-8-peter.ujfalusi@ti.com> <20191113234049.GA1249@jack.zhora.eu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Peter Ujfalusi Cc: jonathanh@nvidia.com, alexandre.belloni@bootlin.com, s.hauer@pengutronix.de, linux-arm-msm@vger.kernel.org, radu_nicolae.pirea@upb.ro, broonie@kernel.org, linux-kernel@vger.kernel.org, krzk@kernel.org, linux-spi@vger.kernel.org, vkoul@kernel.org, kgene@kernel.org, ldewangan@nvidia.com, agross@kernel.org, Andi Shyti , linux-tegra@vger.kernel.org, thierry.reding@gmail.com, bjorn.andersson@linaro.org, shawnguo@kernel.org, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org List-Id: linux-tegra@vger.kernel.org Hi Peter, > >> if (!is_polling(sdd)) { > >> /* Acquire DMA channels */ > >> - sdd->rx_dma.ch = dma_request_slave_channel_reason(&pdev->dev, > >> - "rx"); > >> + sdd->rx_dma.ch = dma_request_chan(&pdev->dev, "rx"); > > > > I have a little concern here. We have two funcions > > 'dma_request_chan' and 'dma_request_channel' don't we end up > > making some confusion here? > > > > Wouldn't it make more sense renaming 'dma_request_chan' to > > 'dma_request_slave_channel_reason'? > > The dma_request_channel() should go away. It was the old API before we > got the dma_slave_map for non DT (and non ACPI) platforms so we can get > rid of the filter function exports from DMA drivers to clients all over > the place. Yes, I agree... thanks! Acked-by: Andi Shyti Thanks, Andi