Re: [PATCH 4.4 000/159] 4.4.203-stable review

Re: [PATCH 4.4 000/159] 4.4.203-stable review

[Jon Hunter]

On 22/11/2019 10:26, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.4.203 release.
> There are 159 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Sun, 24 Nov 2019 09:59:19 +0000.
> Anything received after that time might be too late.
> 
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.203-rc1.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y
> and the diffstat can be found below.
> 
> thanks,
> 
> greg k-h
> 
> -------------
> Pseudo-Shortlog of commits:

...

> Marek Szyprowski <m.szyprowski@samsung.com>
>     ARM: dts: exynos: Disable pull control for S5M8767 PMIC

The above commit is causing the following build error for ARM ...

Error: /dvs/git/dirty/git-master_l4t-upstream/kernel/arch/arm/boot/dts/exynos5250-arndale.dts:560.22-23 syntax error
FATAL ERROR: Unable to parse input tree
scripts/Makefile.lib:293: recipe for target 'arch/arm/boot/dts/exynos5250-arndale.dtb' failed
make[2]: *** [arch/arm/boot/dts/exynos5250-arndale.dtb] Error 1

Cheers
Jon

-- 
nvpublic

Re: [PATCH 4.4 000/159] 4.4.203-stable review

[Jon Hunter]

On 22/11/2019 13:14, Jon Hunter wrote:
> 
> On 22/11/2019 10:26, Greg Kroah-Hartman wrote:
>> This is the start of the stable review cycle for the 4.4.203 release.
>> There are 159 patches in this series, all will be posted as a response
>> to this one.  If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Sun, 24 Nov 2019 09:59:19 +0000.
>> Anything received after that time might be too late.
>>
>> The whole patch series can be found in one patch at:
>> 	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.203-rc1.gz
>> or in the git tree and branch at:
>> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y
>> and the diffstat can be found below.
>>
>> thanks,
>>
>> greg k-h
>>
>> -------------
>> Pseudo-Shortlog of commits:
> 
> ...
> 
>> Marek Szyprowski <m.szyprowski@samsung.com>
>>     ARM: dts: exynos: Disable pull control for S5M8767 PMIC
> 
> The above commit is causing the following build error for ARM ...
> 
> Error: /dvs/git/dirty/git-master_l4t-upstream/kernel/arch/arm/boot/dts/exynos5250-arndale.dts:560.22-23 syntax error
> FATAL ERROR: Unable to parse input tree
> scripts/Makefile.lib:293: recipe for target 'arch/arm/boot/dts/exynos5250-arndale.dtb' failed
> make[2]: *** [arch/arm/boot/dts/exynos5250-arndale.dtb] Error 1

FYI ... after reverting the above all the tests are passing for Tegra.

Jon

-- 
nvpublic

Re: [PATCH 4.4 000/159] 4.4.203-stable review

[Greg Kroah-Hartman]

On Fri, Nov 22, 2019 at 01:14:28PM +0000, Jon Hunter wrote:
> 
> On 22/11/2019 10:26, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 4.4.203 release.
> > There are 159 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> > 
> > Responses should be made by Sun, 24 Nov 2019 09:59:19 +0000.
> > Anything received after that time might be too late.
> > 
> > The whole patch series can be found in one patch at:
> > 	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.203-rc1.gz
> > or in the git tree and branch at:
> > 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y
> > and the diffstat can be found below.
> > 
> > thanks,
> > 
> > greg k-h
> > 
> > -------------
> > Pseudo-Shortlog of commits:
> 
> ...
> 
> > Marek Szyprowski <m.szyprowski@samsung.com>
> >     ARM: dts: exynos: Disable pull control for S5M8767 PMIC
> 
> The above commit is causing the following build error for ARM ...
> 
> Error: /dvs/git/dirty/git-master_l4t-upstream/kernel/arch/arm/boot/dts/exynos5250-arndale.dts:560.22-23 syntax error
> FATAL ERROR: Unable to parse input tree
> scripts/Makefile.lib:293: recipe for target 'arch/arm/boot/dts/exynos5250-arndale.dtb' failed
> make[2]: *** [arch/arm/boot/dts/exynos5250-arndale.dtb] Error 1

Ugh. I'll go drop this from 4.4.y, is it also an issue in the 4.9.y
tree?

thanks,

greg k-h

Re: [PATCH 4.4 000/159] 4.4.203-stable review

[Greg Kroah-Hartman]

On Fri, Nov 22, 2019 at 02:39:31PM +0100, Greg Kroah-Hartman wrote:
> On Fri, Nov 22, 2019 at 01:14:28PM +0000, Jon Hunter wrote:
> > 
> > On 22/11/2019 10:26, Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 4.4.203 release.
> > > There are 159 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> > > 
> > > Responses should be made by Sun, 24 Nov 2019 09:59:19 +0000.
> > > Anything received after that time might be too late.
> > > 
> > > The whole patch series can be found in one patch at:
> > > 	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.203-rc1.gz
> > > or in the git tree and branch at:
> > > 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y
> > > and the diffstat can be found below.
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > > 
> > > -------------
> > > Pseudo-Shortlog of commits:
> > 
> > ...
> > 
> > > Marek Szyprowski <m.szyprowski@samsung.com>
> > >     ARM: dts: exynos: Disable pull control for S5M8767 PMIC
> > 
> > The above commit is causing the following build error for ARM ...
> > 
> > Error: /dvs/git/dirty/git-master_l4t-upstream/kernel/arch/arm/boot/dts/exynos5250-arndale.dts:560.22-23 syntax error
> > FATAL ERROR: Unable to parse input tree
> > scripts/Makefile.lib:293: recipe for target 'arch/arm/boot/dts/exynos5250-arndale.dtb' failed
> > make[2]: *** [arch/arm/boot/dts/exynos5250-arndale.dtb] Error 1
> 
> Ugh. I'll go drop this from 4.4.y, is it also an issue in the 4.9.y
> tree?

Ah, I see your other email now, so I'll leave it in 4.9.y and push out a
new 4.4.y tree now.

thanks,

greg k-h

Re: [PATCH 4.4 000/159] 4.4.203-stable review

[Greg Kroah-Hartman]

On Fri, Nov 22, 2019 at 02:41:31PM +0100, Greg Kroah-Hartman wrote:
> On Fri, Nov 22, 2019 at 02:39:31PM +0100, Greg Kroah-Hartman wrote:
> > On Fri, Nov 22, 2019 at 01:14:28PM +0000, Jon Hunter wrote:
> > > 
> > > On 22/11/2019 10:26, Greg Kroah-Hartman wrote:
> > > > This is the start of the stable review cycle for the 4.4.203 release.
> > > > There are 159 patches in this series, all will be posted as a response
> > > > to this one.  If anyone has any issues with these being applied, please
> > > > let me know.
> > > > 
> > > > Responses should be made by Sun, 24 Nov 2019 09:59:19 +0000.
> > > > Anything received after that time might be too late.
> > > > 
> > > > The whole patch series can be found in one patch at:
> > > > 	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.203-rc1.gz
> > > > or in the git tree and branch at:
> > > > 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y
> > > > and the diffstat can be found below.
> > > > 
> > > > thanks,
> > > > 
> > > > greg k-h
> > > > 
> > > > -------------
> > > > Pseudo-Shortlog of commits:
> > > 
> > > ...
> > > 
> > > > Marek Szyprowski <m.szyprowski@samsung.com>
> > > >     ARM: dts: exynos: Disable pull control for S5M8767 PMIC
> > > 
> > > The above commit is causing the following build error for ARM ...
> > > 
> > > Error: /dvs/git/dirty/git-master_l4t-upstream/kernel/arch/arm/boot/dts/exynos5250-arndale.dts:560.22-23 syntax error
> > > FATAL ERROR: Unable to parse input tree
> > > scripts/Makefile.lib:293: recipe for target 'arch/arm/boot/dts/exynos5250-arndale.dtb' failed
> > > make[2]: *** [arch/arm/boot/dts/exynos5250-arndale.dtb] Error 1
> > 
> > Ugh. I'll go drop this from 4.4.y, is it also an issue in the 4.9.y
> > tree?
> 
> Ah, I see your other email now, so I'll leave it in 4.9.y and push out a
> new 4.4.y tree now.

-rc2 is out now, with that patch removed, thanks.

greg k-h

Re: [PATCH 4.4 000/159] 4.4.203-stable review

[Jon Hunter]

On 22/11/2019 13:46, Greg Kroah-Hartman wrote:
> On Fri, Nov 22, 2019 at 02:41:31PM +0100, Greg Kroah-Hartman wrote:
>> On Fri, Nov 22, 2019 at 02:39:31PM +0100, Greg Kroah-Hartman wrote:
>>> On Fri, Nov 22, 2019 at 01:14:28PM +0000, Jon Hunter wrote:
>>>>
>>>> On 22/11/2019 10:26, Greg Kroah-Hartman wrote:
>>>>> This is the start of the stable review cycle for the 4.4.203 release.
>>>>> There are 159 patches in this series, all will be posted as a response
>>>>> to this one.  If anyone has any issues with these being applied, please
>>>>> let me know.
>>>>>
>>>>> Responses should be made by Sun, 24 Nov 2019 09:59:19 +0000.
>>>>> Anything received after that time might be too late.
>>>>>
>>>>> The whole patch series can be found in one patch at:
>>>>> 	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.203-rc1.gz
>>>>> or in the git tree and branch at:
>>>>> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y
>>>>> and the diffstat can be found below.
>>>>>
>>>>> thanks,
>>>>>
>>>>> greg k-h
>>>>>
>>>>> -------------
>>>>> Pseudo-Shortlog of commits:
>>>>
>>>> ...
>>>>
>>>>> Marek Szyprowski <m.szyprowski@samsung.com>
>>>>>     ARM: dts: exynos: Disable pull control for S5M8767 PMIC
>>>>
>>>> The above commit is causing the following build error for ARM ...
>>>>
>>>> Error: /dvs/git/dirty/git-master_l4t-upstream/kernel/arch/arm/boot/dts/exynos5250-arndale.dts:560.22-23 syntax error
>>>> FATAL ERROR: Unable to parse input tree
>>>> scripts/Makefile.lib:293: recipe for target 'arch/arm/boot/dts/exynos5250-arndale.dtb' failed
>>>> make[2]: *** [arch/arm/boot/dts/exynos5250-arndale.dtb] Error 1
>>>
>>> Ugh. I'll go drop this from 4.4.y, is it also an issue in the 4.9.y
>>> tree?
>>
>> Ah, I see your other email now, so I'll leave it in 4.9.y and push out a
>> new 4.4.y tree now.
> 
> -rc2 is out now, with that patch removed, thanks.

Thanks. Well this is odd, now I see ...

Error: arch/arm/boot/dts/omap5-board-common.dtsi:636.1-6 Label or path dwc3 not found
FATAL ERROR: Syntax error parsing input tree
scripts/Makefile.lib:293: recipe for target 'arch/arm/boot/dts/omap5-igep0050.dtb' failed
make[1]: *** [arch/arm/boot/dts/omap5-igep0050.dtb] Error 1
arch/arm/Makefile:338: recipe for target 'dtbs' failed
make: *** [dtbs] Error 2


This is caused by the following commit ...

commit d0abc07b3d752cbe2a8d315f662c53c772caed0f
Author: H. Nikolaus Schaller <hns@goldelico.com>
Date:   Fri Sep 28 17:54:00 2018 +0200

    ARM: dts: omap5: enable OTG role for DWC3 controller


I was wondering why I did not see this before as it was listed
in the original email but looking back at the git log of what I
tested before, I don't see it ...

$ git log --oneline bc69c961f595..7bbe76363f8f arch/arm/boot
b883613d6f68 ARM: tegra: apalis_t30: fix mmc1 cmd pull-up
a1496418067c ARM: dts: tegra30: fix xcvr-setup-use-fuses
e3c8a2e4d6b6 ARM: dts: ste: Fix SPI controller node names
1c9e00b657ad ARM: dts: ux500: Fix LCDA clock line muxing
ec144e236880 ARM: dts: ux500: Correct SCU unit address
98c94b7bce20 ARM: dts: am335x-evm: fix number of cpsw
13b662ab1602 libfdt: Ensure INT_MAX is defined in libfdt_env.h
2b6e4587d0f5 ARM: dts: socfpga: Fix I2C bus unit-address error
1c4b78b0c003 ARM: dts: omap3-gta04: keep vpll2 always on
0c7dc0f3b2c3 ARM: dts: omap3-gta04: make NAND partitions compatible with recent U-Boot
3ecbffc9b6e4 ARM: dts: omap3-gta04: tvout: enable as display1 alias
a787cf8ff717 ARM: dts: omap3-gta04: give spi_lcd node a label so that we can overwrite in other DTS files
83264404b9c9 ARM: dts: exynos: Disable pull control for S5M8767 PMIC
dbe192b499b7 ARM: dts: pxa: fix power i2c base address
f1a2904901ad ARM: dts: exynos: Fix sound in Snow-rev5 Chromebook
9742b4c1d281 ARM: dts: at91/trivial: Fix USART1 definition for at91sam9g45

Anyway, not sure what happen there, but looks like the above
omap5 commit also needs to be dropped. I think you also need
to drop the following as there is a dependency between the two
...

commit 56bfbfd3fd46d250749fa4d5974147eb1e456a5b
Author: Roger Quadros <rogerq@ti.com>
Date:   Wed Dec 5 19:27:44 2018 +0200

    ARM: dts: omap5: Fix dual-role mode on Super-Speed port

Cheers
Jon

-- 
nvpublic

Re: [PATCH 4.4 000/159] 4.4.203-stable review

[Guenter Roeck]

On 11/22/19 6:48 AM, Jon Hunter wrote:

[ ... ]

> Error: arch/arm/boot/dts/omap5-board-common.dtsi:636.1-6 Label or path dwc3 not found
> FATAL ERROR: Syntax error parsing input tree
> scripts/Makefile.lib:293: recipe for target 'arch/arm/boot/dts/omap5-igep0050.dtb' failed
> make[1]: *** [arch/arm/boot/dts/omap5-igep0050.dtb] Error 1
> arch/arm/Makefile:338: recipe for target 'dtbs' failed
> make: *** [dtbs] Error 2
> 
> 
> This is caused by the following commit ...
> 
> commit d0abc07b3d752cbe2a8d315f662c53c772caed0f
> Author: H. Nikolaus Schaller <hns@goldelico.com>
> Date:   Fri Sep 28 17:54:00 2018 +0200
> 
>      ARM: dts: omap5: enable OTG role for DWC3 controller
> 

On top of the breakage caused by this patch, I would also argue
that it is not a bug fix and should not have been included
in the first place.

The dwc3 label was added with commit 4c387984618fe ("ARM: dts: omap5:
Add l4 interconnect hierarchy and ti-sysc data"). Given the size of
that patch, I highly doubt that a backport to 4.4 would work.

Guenter

Re: [PATCH 4.4 000/159] 4.4.203-stable review

[Jon Hunter]

On 23/11/2019 15:46, Guenter Roeck wrote:
> On 11/22/19 6:48 AM, Jon Hunter wrote:
> 
> [ ... ]
> 
>> Error: arch/arm/boot/dts/omap5-board-common.dtsi:636.1-6 Label or path
>> dwc3 not found
>> FATAL ERROR: Syntax error parsing input tree
>> scripts/Makefile.lib:293: recipe for target
>> 'arch/arm/boot/dts/omap5-igep0050.dtb' failed
>> make[1]: *** [arch/arm/boot/dts/omap5-igep0050.dtb] Error 1
>> arch/arm/Makefile:338: recipe for target 'dtbs' failed
>> make: *** [dtbs] Error 2
>>
>>
>> This is caused by the following commit ...
>>
>> commit d0abc07b3d752cbe2a8d315f662c53c772caed0f
>> Author: H. Nikolaus Schaller <hns@goldelico.com>
>> Date:   Fri Sep 28 17:54:00 2018 +0200
>>
>>      ARM: dts: omap5: enable OTG role for DWC3 controller
>>
> 
> On top of the breakage caused by this patch, I would also argue
> that it is not a bug fix and should not have been included
> in the first place.
> 
> The dwc3 label was added with commit 4c387984618fe ("ARM: dts: omap5:
> Add l4 interconnect hierarchy and ti-sysc data"). Given the size of
> that patch, I highly doubt that a backport to 4.4 would work.

FYI ... I am still seeing a build failure because of this with -rc2 ...

Test results for stable-v4.4:
    6 builds:	3 pass, 3 fail
    6 boots:	6 pass, 0 fail
    11 tests:	11 pass, 0 fail

Linux version:	4.4.203-rc2-gdbaac4c54573
Boards tested:	tegra124-jetson-tk1, tegra20-ventana,
                tegra30-cardhu-a04

Cheers
Jon

-- 
nvpublic

Re: [PATCH 4.4 000/159] 4.4.203-stable review

[Greg Kroah-Hartman]

On Sun, Nov 24, 2019 at 08:31:46PM +0000, Jon Hunter wrote:
> 
> On 23/11/2019 15:46, Guenter Roeck wrote:
> > On 11/22/19 6:48 AM, Jon Hunter wrote:
> > 
> > [ ... ]
> > 
> >> Error: arch/arm/boot/dts/omap5-board-common.dtsi:636.1-6 Label or path
> >> dwc3 not found
> >> FATAL ERROR: Syntax error parsing input tree
> >> scripts/Makefile.lib:293: recipe for target
> >> 'arch/arm/boot/dts/omap5-igep0050.dtb' failed
> >> make[1]: *** [arch/arm/boot/dts/omap5-igep0050.dtb] Error 1
> >> arch/arm/Makefile:338: recipe for target 'dtbs' failed
> >> make: *** [dtbs] Error 2
> >>
> >>
> >> This is caused by the following commit ...
> >>
> >> commit d0abc07b3d752cbe2a8d315f662c53c772caed0f
> >> Author: H. Nikolaus Schaller <hns@goldelico.com>
> >> Date:   Fri Sep 28 17:54:00 2018 +0200
> >>
> >>      ARM: dts: omap5: enable OTG role for DWC3 controller
> >>
> > 
> > On top of the breakage caused by this patch, I would also argue
> > that it is not a bug fix and should not have been included
> > in the first place.
> > 
> > The dwc3 label was added with commit 4c387984618fe ("ARM: dts: omap5:
> > Add l4 interconnect hierarchy and ti-sysc data"). Given the size of
> > that patch, I highly doubt that a backport to 4.4 would work.

Good catch, I have now dropped both of these patches and pushed out a
-rc3

> FYI ... I am still seeing a build failure because of this with -rc2 ...

Can you see if -rc3 is also giving you problems?

thanks,

greg k-h

Re: [PATCH 4.4 000/159] 4.4.203-stable review

[Jon Hunter]

On 25/11/2019 09:41, Greg Kroah-Hartman wrote:
> On Sun, Nov 24, 2019 at 08:31:46PM +0000, Jon Hunter wrote:
>>
>> On 23/11/2019 15:46, Guenter Roeck wrote:
>>> On 11/22/19 6:48 AM, Jon Hunter wrote:
>>>
>>> [ ... ]
>>>
>>>> Error: arch/arm/boot/dts/omap5-board-common.dtsi:636.1-6 Label or path
>>>> dwc3 not found
>>>> FATAL ERROR: Syntax error parsing input tree
>>>> scripts/Makefile.lib:293: recipe for target
>>>> 'arch/arm/boot/dts/omap5-igep0050.dtb' failed
>>>> make[1]: *** [arch/arm/boot/dts/omap5-igep0050.dtb] Error 1
>>>> arch/arm/Makefile:338: recipe for target 'dtbs' failed
>>>> make: *** [dtbs] Error 2
>>>>
>>>>
>>>> This is caused by the following commit ...
>>>>
>>>> commit d0abc07b3d752cbe2a8d315f662c53c772caed0f
>>>> Author: H. Nikolaus Schaller <hns@goldelico.com>
>>>> Date:   Fri Sep 28 17:54:00 2018 +0200
>>>>
>>>>      ARM: dts: omap5: enable OTG role for DWC3 controller
>>>>
>>>
>>> On top of the breakage caused by this patch, I would also argue
>>> that it is not a bug fix and should not have been included
>>> in the first place.
>>>
>>> The dwc3 label was added with commit 4c387984618fe ("ARM: dts: omap5:
>>> Add l4 interconnect hierarchy and ti-sysc data"). Given the size of
>>> that patch, I highly doubt that a backport to 4.4 would work.
> 
> Good catch, I have now dropped both of these patches and pushed out a
> -rc3
> 
>> FYI ... I am still seeing a build failure because of this with -rc2 ...
> 
> Can you see if -rc3 is also giving you problems?

Better, but I appear to be seeing some random suspend failures with this
now on one board. I will try to bisect this.

Test results for stable-v4.4:
    6 builds:	6 pass, 0 fail
    12 boots:	12 pass, 0 fail
    19 tests:	18 pass, 1 fail

Linux version:	4.4.203-rc3-g2576206c30b5
Boards tested:	tegra124-jetson-tk1, tegra20-ventana,
                tegra30-cardhu-a04

Cheers
Jon

-- 
nvpublic

Re: [PATCH 4.4 000/159] 4.4.203-stable review

[Guenter Roeck]

On 11/25/19 1:41 AM, Greg Kroah-Hartman wrote:
> On Sun, Nov 24, 2019 at 08:31:46PM +0000, Jon Hunter wrote:
>>
>> On 23/11/2019 15:46, Guenter Roeck wrote:
>>> On 11/22/19 6:48 AM, Jon Hunter wrote:
>>>
>>> [ ... ]
>>>
>>>> Error: arch/arm/boot/dts/omap5-board-common.dtsi:636.1-6 Label or path
>>>> dwc3 not found
>>>> FATAL ERROR: Syntax error parsing input tree
>>>> scripts/Makefile.lib:293: recipe for target
>>>> 'arch/arm/boot/dts/omap5-igep0050.dtb' failed
>>>> make[1]: *** [arch/arm/boot/dts/omap5-igep0050.dtb] Error 1
>>>> arch/arm/Makefile:338: recipe for target 'dtbs' failed
>>>> make: *** [dtbs] Error 2
>>>>
>>>>
>>>> This is caused by the following commit ...
>>>>
>>>> commit d0abc07b3d752cbe2a8d315f662c53c772caed0f
>>>> Author: H. Nikolaus Schaller <hns@goldelico.com>
>>>> Date:   Fri Sep 28 17:54:00 2018 +0200
>>>>
>>>>       ARM: dts: omap5: enable OTG role for DWC3 controller
>>>>
>>>
>>> On top of the breakage caused by this patch, I would also argue
>>> that it is not a bug fix and should not have been included
>>> in the first place.
>>>
>>> The dwc3 label was added with commit 4c387984618fe ("ARM: dts: omap5:
>>> Add l4 interconnect hierarchy and ti-sysc data"). Given the size of
>>> that patch, I highly doubt that a backport to 4.4 would work.
> 
> Good catch, I have now dropped both of these patches and pushed out a
> -rc3
> 
>> FYI ... I am still seeing a build failure because of this with -rc2 ...
> 
> Can you see if -rc3 is also giving you problems?
> 

For v4.4.202-157-g2576206c30b5:

Build results:
	total: 170 pass: 170 fail: 0
Qemu test results:
	total: 324 pass: 324 fail: 0

Guenter

Re: [PATCH 4.4 000/159] 4.4.203-stable review

[Greg Kroah-Hartman]

On Mon, Nov 25, 2019 at 06:08:17AM -0800, Guenter Roeck wrote:
> On 11/25/19 1:41 AM, Greg Kroah-Hartman wrote:
> > On Sun, Nov 24, 2019 at 08:31:46PM +0000, Jon Hunter wrote:
> > > 
> > > On 23/11/2019 15:46, Guenter Roeck wrote:
> > > > On 11/22/19 6:48 AM, Jon Hunter wrote:
> > > > 
> > > > [ ... ]
> > > > 
> > > > > Error: arch/arm/boot/dts/omap5-board-common.dtsi:636.1-6 Label or path
> > > > > dwc3 not found
> > > > > FATAL ERROR: Syntax error parsing input tree
> > > > > scripts/Makefile.lib:293: recipe for target
> > > > > 'arch/arm/boot/dts/omap5-igep0050.dtb' failed
> > > > > make[1]: *** [arch/arm/boot/dts/omap5-igep0050.dtb] Error 1
> > > > > arch/arm/Makefile:338: recipe for target 'dtbs' failed
> > > > > make: *** [dtbs] Error 2
> > > > > 
> > > > > 
> > > > > This is caused by the following commit ...
> > > > > 
> > > > > commit d0abc07b3d752cbe2a8d315f662c53c772caed0f
> > > > > Author: H. Nikolaus Schaller <hns@goldelico.com>
> > > > > Date:   Fri Sep 28 17:54:00 2018 +0200
> > > > > 
> > > > >       ARM: dts: omap5: enable OTG role for DWC3 controller
> > > > > 
> > > > 
> > > > On top of the breakage caused by this patch, I would also argue
> > > > that it is not a bug fix and should not have been included
> > > > in the first place.
> > > > 
> > > > The dwc3 label was added with commit 4c387984618fe ("ARM: dts: omap5:
> > > > Add l4 interconnect hierarchy and ti-sysc data"). Given the size of
> > > > that patch, I highly doubt that a backport to 4.4 would work.
> > 
> > Good catch, I have now dropped both of these patches and pushed out a
> > -rc3
> > 
> > > FYI ... I am still seeing a build failure because of this with -rc2 ...
> > 
> > Can you see if -rc3 is also giving you problems?
> > 
> 
> For v4.4.202-157-g2576206c30b5:
> 
> Build results:
> 	total: 170 pass: 170 fail: 0
> Qemu test results:
> 	total: 324 pass: 324 fail: 0

Thanks for testing, I'll go with this tree now.

greg k-h

Re: [PATCH 4.4 000/159] 4.4.203-stable review

[Greg Kroah-Hartman]

On Mon, Nov 25, 2019 at 01:22:58PM +0000, Jon Hunter wrote:
> 
> On 25/11/2019 09:41, Greg Kroah-Hartman wrote:
> > On Sun, Nov 24, 2019 at 08:31:46PM +0000, Jon Hunter wrote:
> >>
> >> On 23/11/2019 15:46, Guenter Roeck wrote:
> >>> On 11/22/19 6:48 AM, Jon Hunter wrote:
> >>>
> >>> [ ... ]
> >>>
> >>>> Error: arch/arm/boot/dts/omap5-board-common.dtsi:636.1-6 Label or path
> >>>> dwc3 not found
> >>>> FATAL ERROR: Syntax error parsing input tree
> >>>> scripts/Makefile.lib:293: recipe for target
> >>>> 'arch/arm/boot/dts/omap5-igep0050.dtb' failed
> >>>> make[1]: *** [arch/arm/boot/dts/omap5-igep0050.dtb] Error 1
> >>>> arch/arm/Makefile:338: recipe for target 'dtbs' failed
> >>>> make: *** [dtbs] Error 2
> >>>>
> >>>>
> >>>> This is caused by the following commit ...
> >>>>
> >>>> commit d0abc07b3d752cbe2a8d315f662c53c772caed0f
> >>>> Author: H. Nikolaus Schaller <hns@goldelico.com>
> >>>> Date:   Fri Sep 28 17:54:00 2018 +0200
> >>>>
> >>>>      ARM: dts: omap5: enable OTG role for DWC3 controller
> >>>>
> >>>
> >>> On top of the breakage caused by this patch, I would also argue
> >>> that it is not a bug fix and should not have been included
> >>> in the first place.
> >>>
> >>> The dwc3 label was added with commit 4c387984618fe ("ARM: dts: omap5:
> >>> Add l4 interconnect hierarchy and ti-sysc data"). Given the size of
> >>> that patch, I highly doubt that a backport to 4.4 would work.
> > 
> > Good catch, I have now dropped both of these patches and pushed out a
> > -rc3
> > 
> >> FYI ... I am still seeing a build failure because of this with -rc2 ...
> > 
> > Can you see if -rc3 is also giving you problems?
> 
> Better, but I appear to be seeing some random suspend failures with this
> now on one board. I will try to bisect this.
> 
> Test results for stable-v4.4:
>     6 builds:	6 pass, 0 fail
>     12 boots:	12 pass, 0 fail
>     19 tests:	18 pass, 1 fail
> 
> Linux version:	4.4.203-rc3-g2576206c30b5
> Boards tested:	tegra124-jetson-tk1, tegra20-ventana,
>                 tegra30-cardhu-a04

Odd.  If you find anything interesting, please let me know.

thanks for testing,

greg k-h

Re: [PATCH 4.4 000/159] 4.4.203-stable review

[Jon Hunter]

On 25/11/2019 16:03, Greg Kroah-Hartman wrote:
> On Mon, Nov 25, 2019 at 01:22:58PM +0000, Jon Hunter wrote:
>>
>> On 25/11/2019 09:41, Greg Kroah-Hartman wrote:
>>> On Sun, Nov 24, 2019 at 08:31:46PM +0000, Jon Hunter wrote:
>>>>
>>>> On 23/11/2019 15:46, Guenter Roeck wrote:
>>>>> On 11/22/19 6:48 AM, Jon Hunter wrote:
>>>>>
>>>>> [ ... ]
>>>>>
>>>>>> Error: arch/arm/boot/dts/omap5-board-common.dtsi:636.1-6 Label or path
>>>>>> dwc3 not found
>>>>>> FATAL ERROR: Syntax error parsing input tree
>>>>>> scripts/Makefile.lib:293: recipe for target
>>>>>> 'arch/arm/boot/dts/omap5-igep0050.dtb' failed
>>>>>> make[1]: *** [arch/arm/boot/dts/omap5-igep0050.dtb] Error 1
>>>>>> arch/arm/Makefile:338: recipe for target 'dtbs' failed
>>>>>> make: *** [dtbs] Error 2
>>>>>>
>>>>>>
>>>>>> This is caused by the following commit ...
>>>>>>
>>>>>> commit d0abc07b3d752cbe2a8d315f662c53c772caed0f
>>>>>> Author: H. Nikolaus Schaller <hns@goldelico.com>
>>>>>> Date:   Fri Sep 28 17:54:00 2018 +0200
>>>>>>
>>>>>>      ARM: dts: omap5: enable OTG role for DWC3 controller
>>>>>>
>>>>>
>>>>> On top of the breakage caused by this patch, I would also argue
>>>>> that it is not a bug fix and should not have been included
>>>>> in the first place.
>>>>>
>>>>> The dwc3 label was added with commit 4c387984618fe ("ARM: dts: omap5:
>>>>> Add l4 interconnect hierarchy and ti-sysc data"). Given the size of
>>>>> that patch, I highly doubt that a backport to 4.4 would work.
>>>
>>> Good catch, I have now dropped both of these patches and pushed out a
>>> -rc3
>>>
>>>> FYI ... I am still seeing a build failure because of this with -rc2 ...
>>>
>>> Can you see if -rc3 is also giving you problems?
>>
>> Better, but I appear to be seeing some random suspend failures with this
>> now on one board. I will try to bisect this.
>>
>> Test results for stable-v4.4:
>>     6 builds:	6 pass, 0 fail
>>     12 boots:	12 pass, 0 fail
>>     19 tests:	18 pass, 1 fail
>>
>> Linux version:	4.4.203-rc3-g2576206c30b5
>> Boards tested:	tegra124-jetson-tk1, tegra20-ventana,
>>                 tegra30-cardhu-a04
> 
> Odd.  If you find anything interesting, please let me know.

Yes will do. Bisect has not found anything yet, so will keeping looking
to see if this is a false-positive or not.

Cheers Jon

-- 
nvpublic

Re: [PATCH 4.4 000/159] 4.4.203-stable review

[Jon Hunter]

On 25/11/2019 22:45, Jon Hunter wrote:
> 
> On 25/11/2019 16:03, Greg Kroah-Hartman wrote:
>> On Mon, Nov 25, 2019 at 01:22:58PM +0000, Jon Hunter wrote:
>>>
>>> On 25/11/2019 09:41, Greg Kroah-Hartman wrote:
>>>> On Sun, Nov 24, 2019 at 08:31:46PM +0000, Jon Hunter wrote:
>>>>>
>>>>> On 23/11/2019 15:46, Guenter Roeck wrote:
>>>>>> On 11/22/19 6:48 AM, Jon Hunter wrote:
>>>>>>
>>>>>> [ ... ]
>>>>>>
>>>>>>> Error: arch/arm/boot/dts/omap5-board-common.dtsi:636.1-6 Label or path
>>>>>>> dwc3 not found
>>>>>>> FATAL ERROR: Syntax error parsing input tree
>>>>>>> scripts/Makefile.lib:293: recipe for target
>>>>>>> 'arch/arm/boot/dts/omap5-igep0050.dtb' failed
>>>>>>> make[1]: *** [arch/arm/boot/dts/omap5-igep0050.dtb] Error 1
>>>>>>> arch/arm/Makefile:338: recipe for target 'dtbs' failed
>>>>>>> make: *** [dtbs] Error 2
>>>>>>>
>>>>>>>
>>>>>>> This is caused by the following commit ...
>>>>>>>
>>>>>>> commit d0abc07b3d752cbe2a8d315f662c53c772caed0f
>>>>>>> Author: H. Nikolaus Schaller <hns@goldelico.com>
>>>>>>> Date:   Fri Sep 28 17:54:00 2018 +0200
>>>>>>>
>>>>>>>      ARM: dts: omap5: enable OTG role for DWC3 controller
>>>>>>>
>>>>>>
>>>>>> On top of the breakage caused by this patch, I would also argue
>>>>>> that it is not a bug fix and should not have been included
>>>>>> in the first place.
>>>>>>
>>>>>> The dwc3 label was added with commit 4c387984618fe ("ARM: dts: omap5:
>>>>>> Add l4 interconnect hierarchy and ti-sysc data"). Given the size of
>>>>>> that patch, I highly doubt that a backport to 4.4 would work.
>>>>
>>>> Good catch, I have now dropped both of these patches and pushed out a
>>>> -rc3
>>>>
>>>>> FYI ... I am still seeing a build failure because of this with -rc2 ...
>>>>
>>>> Can you see if -rc3 is also giving you problems?
>>>
>>> Better, but I appear to be seeing some random suspend failures with this
>>> now on one board. I will try to bisect this.
>>>
>>> Test results for stable-v4.4:
>>>     6 builds:	6 pass, 0 fail
>>>     12 boots:	12 pass, 0 fail
>>>     19 tests:	18 pass, 1 fail
>>>
>>> Linux version:	4.4.203-rc3-g2576206c30b5
>>> Boards tested:	tegra124-jetson-tk1, tegra20-ventana,
>>>                 tegra30-cardhu-a04
>>
>> Odd.  If you find anything interesting, please let me know.
> 
> Yes will do. Bisect has not found anything yet, so will keeping looking
> to see if this is a false-positive or not.

I have been doing some more testing and it appears that I see
intermittent suspend failures on Tegra124 with linux-4.4.y. Apparently
this issue has always been there and appears to be fixed in v4.5. I am
still trying to find a way to fix this. The changes in v4.5 that appear
to resolve this are too complex for stable (several patches in Tegra clk
drivers). Anyway, ignore this for now, I will see how we can fix or
workaround for linux-4.4.y.

Jon

-- 
nvpublic

Re: [PATCH 4.4 000/159] 4.4.203-stable review

[Greg Kroah-Hartman]

On Thu, Nov 28, 2019 at 09:26:25AM +0000, Jon Hunter wrote:
> 
> On 25/11/2019 22:45, Jon Hunter wrote:
> > 
> > On 25/11/2019 16:03, Greg Kroah-Hartman wrote:
> >> On Mon, Nov 25, 2019 at 01:22:58PM +0000, Jon Hunter wrote:
> >>>
> >>> On 25/11/2019 09:41, Greg Kroah-Hartman wrote:
> >>>> On Sun, Nov 24, 2019 at 08:31:46PM +0000, Jon Hunter wrote:
> >>>>>
> >>>>> On 23/11/2019 15:46, Guenter Roeck wrote:
> >>>>>> On 11/22/19 6:48 AM, Jon Hunter wrote:
> >>>>>>
> >>>>>> [ ... ]
> >>>>>>
> >>>>>>> Error: arch/arm/boot/dts/omap5-board-common.dtsi:636.1-6 Label or path
> >>>>>>> dwc3 not found
> >>>>>>> FATAL ERROR: Syntax error parsing input tree
> >>>>>>> scripts/Makefile.lib:293: recipe for target
> >>>>>>> 'arch/arm/boot/dts/omap5-igep0050.dtb' failed
> >>>>>>> make[1]: *** [arch/arm/boot/dts/omap5-igep0050.dtb] Error 1
> >>>>>>> arch/arm/Makefile:338: recipe for target 'dtbs' failed
> >>>>>>> make: *** [dtbs] Error 2
> >>>>>>>
> >>>>>>>
> >>>>>>> This is caused by the following commit ...
> >>>>>>>
> >>>>>>> commit d0abc07b3d752cbe2a8d315f662c53c772caed0f
> >>>>>>> Author: H. Nikolaus Schaller <hns@goldelico.com>
> >>>>>>> Date:   Fri Sep 28 17:54:00 2018 +0200
> >>>>>>>
> >>>>>>>      ARM: dts: omap5: enable OTG role for DWC3 controller
> >>>>>>>
> >>>>>>
> >>>>>> On top of the breakage caused by this patch, I would also argue
> >>>>>> that it is not a bug fix and should not have been included
> >>>>>> in the first place.
> >>>>>>
> >>>>>> The dwc3 label was added with commit 4c387984618fe ("ARM: dts: omap5:
> >>>>>> Add l4 interconnect hierarchy and ti-sysc data"). Given the size of
> >>>>>> that patch, I highly doubt that a backport to 4.4 would work.
> >>>>
> >>>> Good catch, I have now dropped both of these patches and pushed out a
> >>>> -rc3
> >>>>
> >>>>> FYI ... I am still seeing a build failure because of this with -rc2 ...
> >>>>
> >>>> Can you see if -rc3 is also giving you problems?
> >>>
> >>> Better, but I appear to be seeing some random suspend failures with this
> >>> now on one board. I will try to bisect this.
> >>>
> >>> Test results for stable-v4.4:
> >>>     6 builds:	6 pass, 0 fail
> >>>     12 boots:	12 pass, 0 fail
> >>>     19 tests:	18 pass, 1 fail
> >>>
> >>> Linux version:	4.4.203-rc3-g2576206c30b5
> >>> Boards tested:	tegra124-jetson-tk1, tegra20-ventana,
> >>>                 tegra30-cardhu-a04
> >>
> >> Odd.  If you find anything interesting, please let me know.
> > 
> > Yes will do. Bisect has not found anything yet, so will keeping looking
> > to see if this is a false-positive or not.
> 
> I have been doing some more testing and it appears that I see
> intermittent suspend failures on Tegra124 with linux-4.4.y. Apparently
> this issue has always been there and appears to be fixed in v4.5. I am
> still trying to find a way to fix this. The changes in v4.5 that appear
> to resolve this are too complex for stable (several patches in Tegra clk
> drivers). Anyway, ignore this for now, I will see how we can fix or
> workaround for linux-4.4.y.

Ok, thanks for letting us know and good luck with it.

greg k-h