From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/9] drm/tegra: gem: Properly pin imported buffers Date: Fri, 29 Nov 2019 20:09:28 +0100 Message-ID: <20191129190928.GO624164@phenom.ffwll.local> References: <20191128153741.2380419-1-thierry.reding@gmail.com> <20191128153741.2380419-3-thierry.reding@gmail.com> <20191129091038.GB624164@phenom.ffwll.local> <20191129101537.GB2771912@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20191129101537.GB2771912@ulmo> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: linux-tegra@vger.kernel.org T24gRnJpLCBOb3YgMjksIDIwMTkgYXQgMTE6MTU6MzdBTSArMDEwMCwgVGhpZXJyeSBSZWRpbmcg d3JvdGU6Cj4gT24gRnJpLCBOb3YgMjksIDIwMTkgYXQgMTA6MTA6MzhBTSArMDEwMCwgRGFuaWVs IFZldHRlciB3cm90ZToKPiA+IE9uIFRodSwgTm92IDI4LCAyMDE5IGF0IDA0OjM3OjM0UE0gKzAx MDAsIFRoaWVycnkgUmVkaW5nIHdyb3RlOgo+ID4gPiBGcm9tOiBUaGllcnJ5IFJlZGluZyA8dHJl ZGluZ0BudmlkaWEuY29tPgo+ID4gPiAKPiA+ID4gQnVmZmVycyB0aGF0IGFyZSBpbXBvcnRlZCBm cm9tIGEgRE1BLUJVRiBkb24ndCBoYXZlIHBhZ2VzIGFsbG9jYXRlZCB3aXRoCj4gPiA+IHRoZW0u IEF0IHRoZSBzYW1lIHRpbWUgYW4gU0cgdGFibGUgZm9yIHRoZW0gY2FuJ3QgYmUgZGVyaXZlZCB1 c2luZyB0aGUKPiA+ID4gRE1BIEFQSSBoZWxwZXJzIGJlY2F1c2UgdGhlIG5lY2Vzc2FyeSBpbmZv cm1hdGlvbiBkb2Vzbid0IGV4aXN0LiBIb3dldmVyCj4gPiA+IHRoZXJlJ3MgYWxyZWFkeSBhbiBT RyB0YWJsZSB0aGF0IHdhcyBjcmVhdGVkIGR1cmluZyBpbXBvcnQsIHNvIHRoaXMgY2FuCj4gPiA+ IHNpbXBseSBiZSBkdXBsaWNhdGVkLgo+ID4gPiAKPiA+ID4gU2lnbmVkLW9mZi1ieTogVGhpZXJy eSBSZWRpbmcgPHRyZWRpbmdAbnZpZGlhLmNvbT4KPiA+ID4gLS0tCj4gPiA+ICBkcml2ZXJzL2dw dS9kcm0vdGVncmEvZ2VtLmMgfCA0MyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrCj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgNDMgaW5zZXJ0aW9ucygrKQo+ID4gPiAKPiA+ID4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS90ZWdyYS9nZW0uYyBiL2RyaXZlcnMvZ3B1L2Ry bS90ZWdyYS9nZW0uYwo+ID4gPiBpbmRleCA3NDZkYWUzMmM0ODQuLjZkZmFkNTZlZWUyYiAxMDA2 NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3RlZ3JhL2dlbS5jCj4gPiA+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS90ZWdyYS9nZW0uYwo+ID4gPiBAQCAtMjcsNiArMjcsMjkgQEAgc3RhdGlj IHZvaWQgdGVncmFfYm9fcHV0KHN0cnVjdCBob3N0MXhfYm8gKmJvKQo+ID4gPiAgCWRybV9nZW1f b2JqZWN0X3B1dF91bmxvY2tlZCgmb2JqLT5nZW0pOwo+ID4gPiAgfQo+ID4gPiAgCj4gPiA+ICsv KiBYWFggbW92ZSB0aGlzIGludG8gbGliL3NjYXR0ZXJsaXN0LmM/ICovCj4gPiA+ICtzdGF0aWMg aW50IHNnX2FsbG9jX3RhYmxlX2Zyb21fc2coc3RydWN0IHNnX3RhYmxlICpzZ3QsIHN0cnVjdCBz Y2F0dGVybGlzdCAqc2csCj4gPiA+ICsJCQkJICB1bnNpZ25lZCBpbnQgbmVudHMsIGdmcF90IGdm cF9tYXNrKQo+ID4gPiArewo+ID4gPiArCXN0cnVjdCBzY2F0dGVybGlzdCAqZHN0Owo+ID4gPiAr CXVuc2lnbmVkIGludCBpOwo+ID4gPiArCWludCBlcnI7Cj4gPiA+ICsKPiA+ID4gKwllcnIgPSBz Z19hbGxvY190YWJsZShzZ3QsIG5lbnRzLCBnZnBfbWFzayk7Cj4gPiA+ICsJaWYgKGVyciA8IDAp Cj4gPiA+ICsJCXJldHVybiBlcnI7Cj4gPiA+ICsKPiA+ID4gKwlkc3QgPSBzZ3QtPnNnbDsKPiA+ ID4gKwo+ID4gPiArCWZvciAoaSA9IDA7IGkgPCBuZW50czsgaSsrKSB7Cj4gPiA+ICsJCXNnX3Nl dF9wYWdlKGRzdCwgc2dfcGFnZShzZyksIHNnLT5sZW5ndGgsIDApOwo+ID4gPiArCQlkc3QgPSBz Z19uZXh0KGRzdCk7Cj4gPiA+ICsJCXNnID0gc2dfbmV4dChzZyk7Cj4gPiA+ICsJfQo+ID4gPiAr Cj4gPiA+ICsJcmV0dXJuIDA7Cj4gPiA+ICt9Cj4gPiA+ICsKPiA+ID4gIHN0YXRpYyBzdHJ1Y3Qg c2dfdGFibGUgKnRlZ3JhX2JvX3BpbihzdHJ1Y3QgZGV2aWNlICpkZXYsIHN0cnVjdCBob3N0MXhf Ym8gKmJvLAo+ID4gPiAgCQkJCSAgICAgZG1hX2FkZHJfdCAqcGh5cykKPiA+ID4gIHsKPiA+ID4g QEAgLTUyLDExICs3NSwzMSBAQCBzdGF0aWMgc3RydWN0IHNnX3RhYmxlICp0ZWdyYV9ib19waW4o c3RydWN0IGRldmljZSAqZGV2LCBzdHJ1Y3QgaG9zdDF4X2JvICpibywKPiA+ID4gIAkJcmV0dXJu IEVSUl9QVFIoLUVOT01FTSk7Cj4gPiA+ICAKPiA+ID4gIAlpZiAob2JqLT5wYWdlcykgewo+ID4g PiArCQkvKgo+ID4gPiArCQkgKiBJZiB0aGUgYnVmZmVyIG9iamVjdCB3YXMgYWxsb2NhdGVkIGZy b20gdGhlIGV4cGxpY2l0IElPTU1VCj4gPiA+ICsJCSAqIEFQSSBjb2RlIHBhdGhzLCBjb25zdHJ1 Y3QgYW4gU0cgdGFibGUgZnJvbSB0aGUgcGFnZXMuCj4gPiA+ICsJCSAqLwo+ID4gPiAgCQllcnIg PSBzZ19hbGxvY190YWJsZV9mcm9tX3BhZ2VzKHNndCwgb2JqLT5wYWdlcywgb2JqLT5udW1fcGFn ZXMsCj4gPiA+ICAJCQkJCQkwLCBvYmotPmdlbS5zaXplLCBHRlBfS0VSTkVMKTsKPiA+ID4gIAkJ aWYgKGVyciA8IDApCj4gPiA+ICAJCQlnb3RvIGZyZWU7Cj4gPiA+ICsJfSBlbHNlIGlmIChvYmot PnNndCkgewo+ID4gPiArCQkvKgo+ID4gPiArCQkgKiBJZiB0aGUgYnVmZmVyIG9iamVjdCBhbHJl YWR5IGhhcyBhbiBTRyB0YWJsZSBidXQgbm8gcGFnZXMKPiA+ID4gKwkJICogd2VyZSBhbGxvY2F0 ZWQgZm9yIGl0LCBpdCBtZWFucyB0aGUgYnVmZmVyIHdhcyBpbXBvcnRlZCBhbmQKPiA+ID4gKwkJ ICogdGhlIFNHIHRhYmxlIG5lZWRzIHRvIGJlIGNvcGllZCB0byBhdm9pZCBvdmVyd3JpdGluZyBh bnkKPiA+ID4gKwkJICogb3RoZXIgcG90ZW50aWFsIHVzZXJzIG9mIHRoZSBvcmlnaW5hbCBTRyB0 YWJsZS4KPiA+ID4gKwkJICovCj4gPiA+ICsJCWVyciA9IHNnX2FsbG9jX3RhYmxlX2Zyb21fc2co c2d0LCBvYmotPnNndC0+c2dsLCBvYmotPnNndC0+bmVudHMsCj4gPiA+ICsJCQkJCSAgICAgR0ZQ X0tFUk5FTCk7Cj4gPiAKPiA+IFdoeSBkdXBsaWNhdGUgdGhpcyBpbnN0ZWFkIG9mIGp1c3QgaGFu ZGluZyBvdXQgb2JqLT5zZ3QsIGFuZCB0aGVuIGluIHVucGluCj4gPiBtYWtpbmcgc3VyZSB5b3Ug ZG9uJ3QgcmVsZWFzZSBpdD8gWW91IGNvdWxkIGFsc28gb25seSBtYXAvdW5tYXAgdGhlCj4gPiBk bWFfYnVmIGhlcmUgaW4geW91ciBwaW4vdW5waW4sIGJ1dCB0aGF0J3MgYSBwaWxlIG9mIHdvcmsg cGx1cyB0aGUgbWFwcGluZwo+ID4gaXMgY2FjaGVkIGFueXdheSBzbyB3b24ndCBjaGFuZ2UgYSB0 aGluZy4KPiAKPiBUaGUgcHJvYmxlbSB3aXRoIGp1c3QgaGFuZGluZyBvdXQgb2JqLT5zZ3QgaXMg dGhhdCB0aGVzZSBidWZmZXJzIG1heSBiZQo+IHVzZWQgYnkgc2V2ZXJhbCBvZiB0aGUgaG9zdDF4 IGVuZ2luZXMgaW4gdGhlIHNhbWUgam9iLiBUaGlzIG1lYW5zIHRoYXQKPiB0aGV5IG1heSBlbmQg dXAgZ2V0dGluZyBkbWFfbWFwKCknZWQgYnkgbXVsdGlwbGUgZGV2aWNlcy4gZG1hX21hcF8qKCkK PiBzdG9yZXMgdGhlIERNQSBhZGRyZXNzZXMgZm9yIHRoZSBidWZmZXIgaW4gdGhlIFNHIGVudHJp ZXMsIHNvIHN1YnNlcXVlbnQKPiBjYWxscyB3b3VsZCBlZmZlY3RpdmVseSBvdmVyd3JpdGUgdGhl IGVhcmxpZXIgbWFwcGluZ3MsIHNvIHdlIG5lZWQgYSBuZXcKPiBTRyB0YWJsZSBmb3IgZWFjaCBk ZXZpY2UuCgpTbyBzdHJpY3RseSBzcGVha2luZywgaS5lLiBpZiB5b3UgZG9uJ3Qgd2FudCB0byBj b250cmlidXRlIHRvIHRoZSBsaXZpbmcKbWVzcyB0aGF0J3MgY2FsbGVkIGRtYS1idWYsIHlvdSdy ZSBzdXBwb3NlZCB0byBkbWFfYnVmX2F0dGFjaCBlYWNoIGFuZApldmVyeSBkZXZpY2UgKGRlZmlu aXRlbHkgdGhvc2Ugd2l0aCBkaWZmZXJlbnQgaW9tbXUvZG1hLWFwaSByb3V0aW5nKS4gVGhhdApl bnRpcmUgImxldCBtZSBwZWFrIGJlaGluZCB0aGUgYWJzdHJhY3Rpb24iIHRoaW5nIGlzIGtpbmRh IG5vdCBob3cgdGhpcwp3YXMgbWVhbnQgdG8gYmUgdXNlZC4gQnV0IHRoZSBmaXJzdCBkcm0gcHJp bWUgZHJpdmVycyBkaWQgaXQgcmVhbGx5IGJhZGx5LApwbHVzIGRybV9wcmltZS5jIGlzIHNvbWV3 aGF0IGJhY2t3YXJkcyBpbiBzb21lIHJlZ2FyZHMgYnkgYWx3YXlzIGF0dGFjaGluZwpmb3IgeW91 IHJpZ2h0IGF3YXkgdG8gL3NvbWV0aGluZy8sIGJ1dCBtYXliZSBub3QgdGhlIHJpZ2h0IHRoaW5n LgoKQWRkaW5nIG1vcmUgZG1hLWJ1ZiBpbnRlcmZhY2UgYWJ1c2UgZG9lc24ndCBmZWVsIGxpa2Ug dGhlIHJpZ2h0IHRoaW5nCnJlYWxseS4KCkFsc28sIHlvdSdyZSBub3Qgc3VwcG9zZWQgdG8gY2Fs bCBkbWFfbWFwX3NnIG9uIHRoZSBzZyB0YWJsZXMgeW91IGdldCBmcm9tCmRtYS1idWYsIHRoZXkn cmUgc3VwcG9zZWQgdG8gYmUgbWFwcGVkIGFscmVhZHkuCi1EYW5pZWwKCgo+IAo+IFRoaWVycnkK PiAKPiA+IC1EYW5pZWwKPiA+IAo+ID4gPiArCQlpZiAoZXJyIDwgMCkKPiA+ID4gKwkJCWdvdG8g ZnJlZTsKPiA+ID4gIAl9IGVsc2Ugewo+ID4gPiArCQkvKgo+ID4gPiArCQkgKiBJZiB0aGUgYnVm ZmVyIG9iamVjdCBoYWQgbm8gcGFnZXMgYWxsb2NhdGVkIGFuZCBpZiBpdCB3YXMKPiA+ID4gKwkJ ICogbm90IGltcG9ydGVkLCBpdCBoYWQgdG8gYmUgYWxsb2NhdGVkIHdpdGggdGhlIERNQSBBUEks IHNvCj4gPiA+ICsJCSAqIHRoZSBETUEgQVBJIGhlbHBlciBjYW4gYmUgdXNlZC4KPiA+ID4gKwkJ ICovCj4gPiA+ICAJCWVyciA9IGRtYV9nZXRfc2d0YWJsZShkZXYsIHNndCwgb2JqLT52YWRkciwg b2JqLT5pb3ZhLAo+ID4gPiAgCQkJCSAgICAgIG9iai0+Z2VtLnNpemUpOwo+ID4gPiAgCQlpZiAo ZXJyIDwgMCkKPiA+ID4gLS0gCj4gPiA+IDIuMjMuMAo+ID4gPiAKPiA+ID4gX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+ID4gZHJpLWRldmVsIG1haWxp bmcgbGlzdAo+ID4gPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiA+IGh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCj4gPiAK PiA+IC0tIAo+ID4gRGFuaWVsIFZldHRlcgo+ID4gU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENv cnBvcmF0aW9uCj4gPiBodHRwOi8vYmxvZy5mZndsbC5jaAoKCgotLSAKRGFuaWVsIFZldHRlcgpT b2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs