From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v1 02/26] drm/panel: add backlight support Date: Tue, 3 Dec 2019 08:32:32 +0200 Message-ID: <20191203063232.GB4730@pendragon.ideasonboard.com> References: <20191202193230.21310-1-sam@ravnborg.org> <20191202193230.21310-3-sam@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20191202193230.21310-3-sam@ravnborg.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sam Ravnborg Cc: Neil Armstrong , David Airlie , dri-devel@lists.freedesktop.org, Thierry Reding , linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Tomi Valkeinen , NXP Linux Team , Jagan Teki , Jitao Shi , Pengutronix Kernel Team , linux-mediatek@lists.infradead.org, Abhinav Kumar , linux-tegra@vger.kernel.org, Maxime Ripard , Sean Paul , linux-arm-kernel@lists.infradead.org, Purism Kernel Team , linux-renesas-soc@vger.kernel.org, Boris Brezillon List-Id: linux-tegra@vger.kernel.org SGkgU2FtLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBNb24sIERlYyAwMiwgMjAxOSBh dCAwODozMjowNlBNICswMTAwLCBTYW0gUmF2bmJvcmcgd3JvdGU6Cj4gUGFuZWxzIG9mdGVuIHN1 cHBvcnRzIGJhY2tsaWdodCBhcyBzcGVjaWZpZWQgaW4gYSBkZXZpY2UgdHJlZS4KPiBVcGRhdGUg dGhlIGRybV9wYW5lbCBpbmZyYXN0cnVjdHVyZSB0byBzdXBwb3J0IHRoaXMgdG8KPiBzaW1wbGlm eSB0aGUgZHJpdmVycy4KPiAKPiBXaXRoIHRoaXMgdGhlIHBhbmVsIGRyaXZlciBqdXN0IG5lZWRz IHRvIGFkZCB0aGUgZm9sbG93aW5nIHRvIHRoZQo+IHByb2JlKCkgZnVuY3Rpb246Cj4gCj4gICAg IGVyciA9IGRybV9wYW5lbF9vZl9iYWNrbGlnaHQocGFuZWwpOwo+ICAgICBpZiAoZXJyKQo+ICAg ICAgICAgICAgIHJldHVybiBlcnI7Cj4gCj4gVGhlbiBkcm1fcGFuZWwgd2lsbCBoYW5kbGUgYWxs IHRoZSByZXN0Lgo+IAo+IHYyOgo+IC0gRHJvcCB0ZXN0IG9mIENPTkZJR19EUk1fUEFORUwgaW4g aGVhZGVyLWZpbGUgKExhdXJlbnQpCj4gLSBkbyBub3QgZW5hYmxlIGJhY2tsaWdodCBpZiAtPmVu YWJsZSgpIHJldHVybnMgYW4gZXJyb3IKPiAKPiBTaWduZWQtb2ZmLWJ5OiBTYW0gUmF2bmJvcmcg PHNhbUByYXZuYm9yZy5vcmc+Cj4gQ2M6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmto b3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IE1heGltZSBSaXBhcmQgPG1heGltZS5yaXBhcmRA Ym9vdGxpbi5jb20+Cj4gQ2M6IFNlYW4gUGF1bCA8c2VhbkBwb29ybHkucnVuPgo+IENjOiBUaGll cnJ5IFJlZGluZyA8dGhpZXJyeS5yZWRpbmdAZ21haWwuY29tPgo+IENjOiBTYW0gUmF2bmJvcmcg PHNhbUByYXZuYm9yZy5vcmc+Cj4gQ2M6IERhdmlkIEFpcmxpZSA8YWlybGllZEBsaW51eC5pZT4K PiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPgo+IC0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vZHJtX3BhbmVsLmMgfCA0OSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr Ky0tCj4gIGluY2x1ZGUvZHJtL2RybV9wYW5lbC5oICAgICB8IDIzICsrKysrKysrKysrKysrKysr Cj4gIDIgZmlsZXMgY2hhbmdlZCwgNzAgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiAK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9wYW5lbC5jIGIvZHJpdmVycy9ncHUv ZHJtL2RybV9wYW5lbC5jCj4gaW5kZXggMmQ1OWNkZDA1ZTUwLi4zNTYwOWM5MGU0NjcgMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9wYW5lbC5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2RybV9wYW5lbC5jCj4gQEAgLTIxLDYgKzIxLDcgQEAKPiAgICogREVBTElOR1MgSU4gVEhF IFNPRlRXQVJFLgo+ICAgKi8KPiAgCj4gKyNpbmNsdWRlIDxsaW51eC9iYWNrbGlnaHQuaD4KPiAg I2luY2x1ZGUgPGxpbnV4L2Vyci5oPgo+ICAjaW5jbHVkZSA8bGludXgvbW9kdWxlLmg+Cj4gIAo+ IEBAIC0xOTYsMTMgKzE5NywxOCBAQCBFWFBPUlRfU1lNQk9MKGRybV9wYW5lbF91bnByZXBhcmUp Owo+ICAgKi8KPiAgaW50IGRybV9wYW5lbF9lbmFibGUoc3RydWN0IGRybV9wYW5lbCAqcGFuZWwp Cj4gIHsKPiArCWludCByZXQgPSAwOwo+ICsKPiAgCWlmICghcGFuZWwpCj4gIAkJcmV0dXJuIC1F SU5WQUw7Cj4gIAo+ICAJaWYgKHBhbmVsLT5mdW5jcyAmJiBwYW5lbC0+ZnVuY3MtPmVuYWJsZSkK PiAtCQlyZXR1cm4gcGFuZWwtPmZ1bmNzLT5lbmFibGUocGFuZWwpOwo+ICsJCXJldCA9IHBhbmVs LT5mdW5jcy0+ZW5hYmxlKHBhbmVsKTsKPiAgCj4gLQlyZXR1cm4gMDsKPiArCWlmIChyZXQgPj0g MCkKCgpJJ2Qgd3JpdGUKCglpZiAocGFuZWwtPmZ1bmNzICYmIHBhbmVsLT5mdW5jcy0+ZW5hYmxl KSB7CgkJcmV0ID0gcGFuZWwtPmZ1bmNzLT5lbmFibGUocGFuZWwpOwoJCWlmIChyZXQgPCAwKQoJ CQlyZXR1cm4gcmV0OwoJfQoKYW5kIHRoZW4gaGFuZGxlIHRoZSBiYWNrbGlnaHQgd2l0aCBvbmUg bGVzcyBpbmRlbnRhdGlvbiBsZXZlbC4KCgo+ICsJCWJhY2tsaWdodF9lbmFibGUocGFuZWwtPmJh Y2tsaWdodCk7CgpXaGF0IGlzIGJhY2tsaWdodF9lbmFibGUoKSByZXR1cm5zIGFuIGVycm9yID8g U2hvdWxkIHdlIGF0IGxlYXN0IGxvZwp0aGF0ID8KCj4gKwo+ICsJcmV0dXJuIHJldDsKPiAgfQo+ ICBFWFBPUlRfU1lNQk9MKGRybV9wYW5lbF9lbmFibGUpOwo+ICAKPiBAQCAtMjIxLDYgKzIyNyw4 IEBAIGludCBkcm1fcGFuZWxfZGlzYWJsZShzdHJ1Y3QgZHJtX3BhbmVsICpwYW5lbCkKPiAgCWlm ICghcGFuZWwpCj4gIAkJcmV0dXJuIC1FSU5WQUw7Cj4gIAo+ICsJYmFja2xpZ2h0X2Rpc2FibGUo cGFuZWwtPmJhY2tsaWdodCk7Cj4gKwo+ICAJaWYgKHBhbmVsLT5mdW5jcyAmJiBwYW5lbC0+ZnVu Y3MtPmRpc2FibGUpCj4gIAkJcmV0dXJuIHBhbmVsLT5mdW5jcy0+ZGlzYWJsZShwYW5lbCk7Cj4g IAo+IEBAIC0yODksNiArMjk3LDQzIEBAIHN0cnVjdCBkcm1fcGFuZWwgKm9mX2RybV9maW5kX3Bh bmVsKGNvbnN0IHN0cnVjdCBkZXZpY2Vfbm9kZSAqbnApCj4gIEVYUE9SVF9TWU1CT0wob2ZfZHJt X2ZpbmRfcGFuZWwpOwo+ICAjZW5kaWYKPiAgCj4gKyNpZmRlZiBDT05GSUdfQkFDS0xJR0hUX0NM QVNTX0RFVklDRQo+ICsvKioKPiArICogZHJtX3BhbmVsX29mX2JhY2tsaWdodCAtIHVzZSBiYWNr bGlnaHQgZGV2aWNlIG5vZGUgZm9yIGJhY2tsaWdodAo+ICsgKiBAcGFuZWw6IERSTSBwYW5lbAo+ ICsgKgo+ICsgKiBVc2UgdGhpcyBmdW5jdGlvbiB0byBlbmFibGUgYmFja2xpZ2h0IGhhbmRsaW5n IGlmIHlvdXIgcGFuZWwKPiArICogdXNlcyBkZXZpY2UgdHJlZSBhbmQgaGFzIGEgYmFja2xpZ2h0 IGhhbmRsZS4KCnMvaGFuZGxlL3BoYW5kbGUvCgo+ICsgKgo+ICsgKiBXaGVuIHBhbmVsIGlzIGVu YWJsZWQgYmFja2xpZ2h0IHdpbGwgYmUgZW5hYmxlZCBhZnRlciBhCgpzL3BhbmVsL3RoZSBwYW5l bC8KCj4gKyAqIHN1Y2Nlc3NmdWxsIGNhbGwgdG8gJmRybV9wYW5lbF9mdW5jcy5lbmFibGUoKQo+ ICsgKgo+ICsgKiBXaGVuIHBhbmVsIGlzIGRpc2FibGVkIGJhY2tsaWdodCB3aWxsIGJlIGRpc2Fi bGVkIGJlZm9yZSB0aGUKClNhbWUgaGVyZS4KCj4gKyAqIGNhbGwgdG8gJmRybV9wYW5lbF9mdW5j cy5kaXNhYmxlKCkuCj4gKyAqCj4gKyAqIEEgdHlwaWNhbCBpbXBsZW1lbnRhdGlvbiBmb3IgYSBw YW5lbCBkcml2ZXIgc3VwcG9ydGluZyBkZXZpY2UgdHJlZQo+ICsgKiB3aWxsIGNhbGwgdGhpcyBm dW5jdGlvbiBhbmQgdGhlbiBiYWNrbGlnaHQganVzdCB3b3Jrcy4KCkhvdyBhYm91dAoKIndpbGwg Y2FsbCB0aGlzIGZ1bmN0aW9uIGF0IHByb2JlIHRpbWUuIEJhY2tsaWdodCB3aWxsIHRoZW4gYmUg aGFuZGxlZAp0cmFuc3BhcmVudGx5IHdpdGhvdXQgcmVxdWlyaW5nIGFueSBpbnRlcnZlbnRpb24g ZnJvbSB0aGUgZHJpdmVyIGF0CnJ1bnRpbWUuIgoKPiArICoKPiArICogUmV0dXJuOiAwIG9uIHN1 Y2Nlc3Mgb3IgYSBuZWdhdGl2ZSBlcnJvciBjb2RlIG9uIGZhaWx1cmUuCj4gKyAqLwo+ICtpbnQg ZHJtX3BhbmVsX29mX2JhY2tsaWdodChzdHJ1Y3QgZHJtX3BhbmVsICpwYW5lbCkKPiArewo+ICsJ c3RydWN0IGJhY2tsaWdodF9kZXZpY2UgKmJhY2tsaWdodDsKPiArCj4gKwlpZiAoIXBhbmVsIHx8 ICFwYW5lbC0+ZGV2KQo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsKPiArCWJhY2tsaWdodCA9IGRl dm1fb2ZfZmluZF9iYWNrbGlnaHQocGFuZWwtPmRldik7Cj4gKwo+ICsJaWYgKElTX0VSUihiYWNr bGlnaHQpKQo+ICsgICAgICAgICAgICAgICAgcmV0dXJuIFBUUl9FUlIoYmFja2xpZ2h0KTsKPiAr Cj4gKwlwYW5lbC0+YmFja2xpZ2h0ID0gYmFja2xpZ2h0Owo+ICsJcmV0dXJuIDA7Cj4gK30KPiAr RVhQT1JUX1NZTUJPTChkcm1fcGFuZWxfb2ZfYmFja2xpZ2h0KTsKPiArI2VuZGlmCj4gKwo+ICBN T0RVTEVfQVVUSE9SKCJUaGllcnJ5IFJlZGluZyA8dHJlZGluZ0BudmlkaWEuY29tPiIpOwo+ICBN T0RVTEVfREVTQ1JJUFRJT04oIkRSTSBwYW5lbCBpbmZyYXN0cnVjdHVyZSIpOwo+ICBNT0RVTEVf TElDRU5TRSgiR1BMIGFuZCBhZGRpdGlvbmFsIHJpZ2h0cyIpOwo+IGRpZmYgLS1naXQgYS9pbmNs dWRlL2RybS9kcm1fcGFuZWwuaCBiL2luY2x1ZGUvZHJtL2RybV9wYW5lbC5oCj4gaW5kZXggY2U4 ZGE2NDAyMmI0Li5kMzBjOTg1NjczODQgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9kcm0vZHJtX3Bh bmVsLmgKPiArKysgYi9pbmNsdWRlL2RybS9kcm1fcGFuZWwuaAo+IEBAIC0yOCw2ICsyOCw3IEBA Cj4gICNpbmNsdWRlIDxsaW51eC9lcnJuby5oPgo+ICAjaW5jbHVkZSA8bGludXgvbGlzdC5oPgo+ ICAKPiArc3RydWN0IGJhY2tsaWdodF9kZXZpY2U7Cj4gIHN0cnVjdCBkZXZpY2Vfbm9kZTsKPiAg c3RydWN0IGRybV9jb25uZWN0b3I7Cj4gIHN0cnVjdCBkcm1fZGV2aWNlOwo+IEBAIC01OSw2ICs2 MCwxMCBAQCBzdHJ1Y3QgZGlzcGxheV90aW1pbmc7Cj4gICAqCj4gICAqIFRvIHNhdmUgcG93ZXIg d2hlbiBubyB2aWRlbyBkYXRhIGlzIHRyYW5zbWl0dGVkLCBhIGRyaXZlciBjYW4gcG93ZXIgZG93 bgo+ICAgKiB0aGUgcGFuZWwuIFRoaXMgaXMgdGhlIGpvYiBvZiB0aGUgLnVucHJlcGFyZSgpIGZ1 bmN0aW9uLgo+ICsgKgo+ICsgKiBCYWNrbGlnaHQgY2FuIGJlIGhhbmRsZWQgYXV0b21hdGljYWxs eSBpZiBjb25maWd1cmVkIHVzaW5nCj4gKyAqIGRybV9wYW5lbF9vZl9iYWNrbGlnaHQoKS4gVGhl biB0aGUgZHJpdmVyIGRvIG5vdCBuZWVkIHRvIGltcGxlbWVudCB0aGUKCnMvZG8gbm90L2RvZXMg bm90LwoKPiArICogZnVuY3Rpb25hbGl0eSB0byBlbmFibGUvZGlzYWJsZSBiYWNrbGlnaHQuCj4g ICAqLwo+ICBzdHJ1Y3QgZHJtX3BhbmVsX2Z1bmNzIHsKPiAgCS8qKgo+IEBAIC0xMzIsNiArMTM3 LDE1IEBAIHN0cnVjdCBkcm1fcGFuZWwgewo+ICAJICovCj4gIAlzdHJ1Y3QgZGV2aWNlICpkZXY7 Cj4gIAo+ICsJLyoqCj4gKwkgKiBAYmFja2xpZ2h0Ogo+ICsJICoKPiArCSAqIEJhY2tsaWdodCBk ZXZpY2UsIHVzZWQgdG8gdHVybiBvbiBiYWNrbGlnaHQgYWZ0ZXIKPiArCSAqIHRoZSBjYWxsIHRv IGVuYWJsZSgpLCBhbmQgdG8gdHVybiBvZmYKPiArCSAqIGJhY2tsaWdodCBiZWZvcmUgY2FsbCB0 byBkaXNhYmxlKCkuCgpzL2JlZm9yZSBjYWxsL2JlZm9yZSB0aGUgY2FsbC8KCm9yIG1heWJlIHNp bXBsZXIKCgpzL2JlZm9yZSBjYWxsIHRvIGRpc2FibGUoKS9iZWZvcmUgZGlzYWJsZSgpLwoKKGFu ZCAnYWZ0ZXIgZW5hYmxlKCknIGFib3ZlIGluIHRoYXQgY2FzZSkuCgpTaG91bGQgeW91IG1lbnRp b24gdGhhdCB0aGlzIGZpZWxkIHNoYWxsIG5vdCBiZSBzZXQgZGlyZWN0bHkgYnkgZHJpdmVycywK YnV0IGlzIHNldCBieSBkcm1fcGFuZWxfb2ZfYmFja2xpZ2h0KCkgaW5zdGVhZCA/CgpZb3UgY2Fu IGFsc28gcmVmbG93IHRoZSB0ZXh0IHRvIHJlYWNoIHRoZSA4MCBjb2x1bW5zIGxpbWl0IDotKQoK PiArCSAqLwo+ICsJc3RydWN0IGJhY2tsaWdodF9kZXZpY2UgKmJhY2tsaWdodDsKPiArCj4gIAkv KioKPiAgCSAqIEBmdW5jczoKPiAgCSAqCj4gQEAgLTE4Myw0ICsxOTcsMTMgQEAgc3RhdGljIGlu bGluZSBzdHJ1Y3QgZHJtX3BhbmVsICpvZl9kcm1fZmluZF9wYW5lbChjb25zdCBzdHJ1Y3QgZGV2 aWNlX25vZGUgKm5wKQo+ICB9Cj4gICNlbmRpZgo+ICAKPiArI2lmIElTX0VOQUJMRUQoQ09ORklH X0JBQ0tMSUdIVF9DTEFTU19ERVZJQ0UpCj4gK2ludCBkcm1fcGFuZWxfb2ZfYmFja2xpZ2h0KHN0 cnVjdCBkcm1fcGFuZWwgKnBhbmVsKTsKPiArI2Vsc2UKPiArc3RhdGljIGlubGluZSBpbnQgZHJt X3BhbmVsX29mX2JhY2tsaWdodChzdHJ1Y3QgZHJtX3BhbmVsICpwYW5lbCkKPiArewo+ICsJcmV0 dXJuIC1FSU5WQUw7CgpTaG91bGRuJ3QgeW91IHJldHVybiAwIGluc3RlYWQgPyBPdGhlcndpc2Ug cGFuZWwgZHJpdmVyIHRoYXQgY2FuIHN1cHBvcnQKYmFja2xpZ2h0IHdpbGwgYWxsIGZhaWwgdG8g cHJvYmUgaWYgQ09ORklHX0JBQ0tMSUdIVF9DTEFTU19ERVZJQ0UgaXMKZGlzYWJsZWQuCgo+ICt9 Cj4gKyNlbmRpZgo+ICsKPiAgI2VuZGlmCgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs