From: Peter De Schrijver <pdeschrijver@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Jon Hunter <jonathanh@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] ARM: tegra: Fix restoration of PLLM when exiting suspend
Date: Wed, 11 Dec 2019 10:50:16 +0200 [thread overview]
Message-ID: <20191211085016.GW28289@pdeschrijver-desktop.Nvidia.com> (raw)
In-Reply-To: <1fe9cd2d-50a2-aae5-95fa-0329acce4c4c@gmail.com>
On Tue, Dec 10, 2019 at 11:29:42PM +0300, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
>
>
> 10.12.2019 22:28, Dmitry Osipenko пишет:
> > Hello Jon,
> >
> > PLLM's enable-status could be defined either by PMC or CaR. Thus at
> > first you need to check whether PMC overrides CaR's enable and then
> > judge the enable state based on PMC or CaR state respectively.
> >
>
> Actually, now I think that it doesn't make sense to check PMC WB0 state
> at all. IIUC, PLLM's state of the WB0 register defines whether Boot ROM
> should enable PLLM on resume from suspend. Thus it will be correct to
> check only the CaR's enable-state of PLLM.
>
> I'm not sure what's the idea of WB0 overriding, maybe to resume faster.
> Peter, could you please clarify that?
I don't know why these overriding bits exist. The code for them was in
the downstream driver so I implemented the same in the upstream driver
:)
Peter.
next prev parent reply other threads:[~2019-12-11 8:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 10:37 [PATCH] ARM: tegra: Fix restoration of PLLM when exiting suspend Jon Hunter
2019-12-10 12:09 ` Thierry Reding
2019-12-10 14:29 ` Jon Hunter
2019-12-10 14:32 ` Jon Hunter
2019-12-10 19:28 ` Dmitry Osipenko
2019-12-10 20:29 ` Dmitry Osipenko
2019-12-11 8:50 ` Peter De Schrijver [this message]
2019-12-12 22:18 ` Dmitry Osipenko
2019-12-17 14:19 ` Jon Hunter
2019-12-17 14:28 ` Dmitry Osipenko
[not found] ` <57264acd-2623-9e9f-53c6-3b4cd3991315-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-06-12 15:20 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191211085016.GW28289@pdeschrijver-desktop.Nvidia.com \
--to=pdeschrijver@nvidia.com \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox