From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [RFC PATCH v1 0/5] Add Tegra driver for video capture Date: Fri, 31 Jan 2020 18:03:51 +0100 Message-ID: <20200131170351.GA3444092@ulmo> References: <1580235801-4129-1-git-send-email-skomatineni@nvidia.com> <20200130154246.GA2904678@ulmo> <8654e6fd-c403-6e68-e5cf-09297b5d8b5d@xs4all.nl> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5vNYLRcllDrimb99" Return-path: Content-Disposition: inline In-Reply-To: <8654e6fd-c403-6e68-e5cf-09297b5d8b5d@xs4all.nl> Sender: linux-clk-owner@vger.kernel.org To: Hans Verkuil Cc: Sowjanya Komatineni , jonathanh@nvidia.com, frankc@nvidia.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-tegra@vger.kernel.org --5vNYLRcllDrimb99 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 31, 2020 at 03:29:52PM +0100, Hans Verkuil wrote: > On 1/30/20 4:42 PM, Thierry Reding wrote: > > On Thu, Jan 30, 2020 at 03:41:50PM +0100, Hans Verkuil wrote: > >> Hi Sowjanya, > >> > >> On 1/28/20 7:23 PM, Sowjanya Komatineni wrote: > >>> This series adds Tegra210 VI and CSI driver for built-in test pattern > >>> generator (TPG) capture. > >>> > >>> Tegra210 supports max 6 channels on VI and 6 ports on CSI where each > >>> CSI port is one-to-one mapped to VI channel for video capture. > >>> > >>> This series has TPG support only where it creates hard media links > >>> between CSI subdevice and VI video device without device graphs. > >>> > >>> v4l2-compliance results are available below the patch diff. > >>> > >>> [v0]: Includes, > >>> - Adds CSI TPG clock to Tegra210 clock driver > >>> - Host1x video driver with VI and CSI clients. > >>> - Support for Tegra210 only. > >>> - VI CSI TPG support with hard media links in driver. > >>> - Video formats supported by Tegra210 VI > >>> - CSI TPG supported video formats > >> > >> I'm trying to compile this patch series using the media_tree master > >> branch (https://git.linuxtv.org//media_tree.git), but it fails: > >> > >> drivers/staging/media/tegra/tegra-channel.c: In function =E2=80=98tegr= a_channel_queue_setup=E2=80=99: > >> drivers/staging/media/tegra/tegra-channel.c:71:15: warning: unused var= iable =E2=80=98count=E2=80=99 [-Wunused-variable] > >> 71 | unsigned int count =3D *nbuffers; > >> | ^~~~~ > >> drivers/staging/media/tegra/tegra-channel.c: In function =E2=80=98tegr= a_channel_init=E2=80=99: > >> drivers/staging/media/tegra/tegra-channel.c:518:55: error: =E2=80=98st= ruct host1x_client=E2=80=99 has no member named =E2=80=98host=E2=80=99 > >> 518 | struct tegra_camera *cam =3D dev_get_drvdata(vi->client.host); > >> | ^ > >> make[4]: *** [scripts/Makefile.build:265: drivers/staging/media/tegra/= tegra-channel.o] Error 1 > >> make[4]: *** Waiting for unfinished jobs.... > >> drivers/staging/media/tegra/tegra-vi.c: In function =E2=80=98tegra_vi_= tpg_graph_init=E2=80=99: > >> drivers/staging/media/tegra/tegra-vi.c:157:55: error: =E2=80=98struct = host1x_client=E2=80=99 has no member named =E2=80=98host=E2=80=99 > >> 157 | struct tegra_camera *cam =3D dev_get_drvdata(vi->client.host); > >> | ^ > >> drivers/staging/media/tegra/tegra-vi.c: In function =E2=80=98tegra_vi_= init=E2=80=99: > >> drivers/staging/media/tegra/tegra-csi.c: In function =E2=80=98tegra_cs= i_init=E2=80=99: > >> drivers/staging/media/tegra/tegra-vi.c:213:51: error: =E2=80=98struct = host1x_client=E2=80=99 has no member named =E2=80=98host=E2=80=99 > >> 213 | struct tegra_camera *cam =3D dev_get_drvdata(client->host); > >> | ^~ > >> drivers/staging/media/tegra/tegra-csi.c:259:51: error: =E2=80=98struct= host1x_client=E2=80=99 has no member named =E2=80=98host=E2=80=99 > >> 259 | struct tegra_camera *cam =3D dev_get_drvdata(client->host); > >> | ^~ > >> drivers/staging/media/tegra/tegra-vi.c: In function =E2=80=98tegra_vi_= exit=E2=80=99: > >> drivers/staging/media/tegra/tegra-vi.c:246:51: error: =E2=80=98struct = host1x_client=E2=80=99 has no member named =E2=80=98host=E2=80=99 > >> 246 | struct tegra_camera *cam =3D dev_get_drvdata(client->host); > >> | ^~ > >> drivers/staging/media/tegra/tegra-csi.c: In function =E2=80=98tegra_cs= i_exit=E2=80=99: > >> drivers/staging/media/tegra/tegra-csi.c:286:51: error: =E2=80=98struct= host1x_client=E2=80=99 has no member named =E2=80=98host=E2=80=99 > >> 286 | struct tegra_camera *cam =3D dev_get_drvdata(client->host); > >> | ^~ > >> > >> And indeed, struct host1x_client as defined in include/linux/host1x.h = doesn't > >> have a 'host' field. > >> > >> Does this series depend on another patch that's not yet in mainline? > >=20 > > Sowjanya's been working on top of linux-next, so, yes, this patch > > depends on a change that's been merged into the DRM tree for v5.6-rc1. > >=20 > > Thierry > >=20 >=20 > Is there a specific linux-next tag that works? I tried next-20200131 but = that > failed to boot. Same problem with the mainline repo since the host1x patc= hes > were merged yesterday. It compiles fine, but the boot just stops. Or am I > missing some kernel config that is now important to have? linux-next and mainline are currently regressing on Tegra210 (and some Tegra124) boards. I just sent out a series that fixes the regression for me: http://patchwork.ozlabs.org/project/linux-tegra/list/?series=3D156215 Please test if this works for you. If so, I'll send this to Dave as soon as possible. Thierry --5vNYLRcllDrimb99 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl40XfcACgkQ3SOs138+ s6GDmRAAgJOr7xCKB+TlGwZKa3pkGAekUaHfnLt4Dck14FCS4/nKcKtnfl2BhC6S vDFUljkoNey/1GrYDgW7CXJqkHce4E88HAO9kevpUOp77WYIQ6POh11X4Bvra/KT tGqjepiQ2MTVZP6J0XDD8XOYevyNmjbQxG8jEBwrHetZ3S8+ptCVEbFm29MHTcSI A4VHFRBObnxiuk3ITVx0UX98TbMy/2PElfD8OaCEq/r6qgl11WzukKxk1VMd8DAb lT6zg2ndwDwq2uK7lIIPg3hSPyRg5bxa5MVpUlb9UA+pwGD04x5P2lxvYIOFs/wl +FLMEiM352WunWcOOJBIYLokppzNPHN9ItKDMTZS6nDQi87EV6vqAY/NvOOhK3QL 8Inuj+EHMtxajemhBFmqN1KU2gGGy+SDmYjbWXqLmLcrSbY48fNn5L6n/FdtSWGa UTDePIgG7u1tAJVnpySXc3GM9ch4JAgt37ww3Z8Z8orIdo7BowD/yko+VcIVJuH5 lvvfu6zcNZOUhBTeSHd45an+twZdpdSIPdaXHNDcQUSWNIE+42lSeXFBMNMN/qGe AK3axSiGjfCsD/CAT/wBtlUftBxTFenfstGd82HMpxxfG//E8FpD/t/vzE2WM3z6 75Ns1wysRwLAR9Rc9uY+zgSQT8iDv8OHDkVIpN16F+L9bKkFk4Y= =VUdt -----END PGP SIGNATURE----- --5vNYLRcllDrimb99--