linux-tegra.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: "Laxman Dewangan" <ldewangan@nvidia.com>,
	"Vinod Koul" <vkoul@kernel.org>,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v8 19/19] dmaengine: tegra-apb: Improve error message about DMA underflow
Date: Sun,  9 Feb 2020 19:33:56 +0300	[thread overview]
Message-ID: <20200209163356.6439-20-digetx@gmail.com> (raw)
In-Reply-To: <20200209163356.6439-1-digetx@gmail.com>

Technically it is possible that DMA could be misconfigured in a way that
cyclic DMA transfer is processed slower than it takes to complete the
cycle and in this case the DMA is getting aborted with a not very
informative message about the problem, let's improve it.

Suggested-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/dma/tegra20-apb-dma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
index 3e0373b89195..1a9b37c102ba 100644
--- a/drivers/dma/tegra20-apb-dma.c
+++ b/drivers/dma/tegra20-apb-dma.c
@@ -566,7 +566,7 @@ static bool handle_continuous_head_request(struct tegra_dma_channel *tdc,
 	if (!hsgreq->configured) {
 		tegra_dma_stop(tdc);
 		pm_runtime_put(tdc->tdma->dev);
-		dev_err(tdc2dev(tdc), "Error in DMA transfer, aborting DMA\n");
+		dev_err(tdc2dev(tdc), "DMA transfer underflow, aborting DMA\n");
 		tegra_dma_abort_all(tdc);
 		return false;
 	}
-- 
2.24.0

  parent reply	other threads:[~2020-02-09 16:33 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-09 16:33 [PATCH v8 00/19] NVIDIA Tegra APB DMA driver fixes and improvements Dmitry Osipenko
2020-02-09 16:33 ` [PATCH v8 01/19] dmaengine: tegra-apb: Fix use-after-free Dmitry Osipenko
2020-02-09 16:33 ` [PATCH v8 02/19] dmaengine: tegra-apb: Prevent race conditions of tasklet vs free list Dmitry Osipenko
2020-02-09 16:33 ` [PATCH v8 03/19] dmaengine: tegra-apb: Implement synchronization hook Dmitry Osipenko
2020-02-09 16:33 ` [PATCH v8 04/19] dmaengine: tegra-apb: Prevent race conditions on channel's freeing Dmitry Osipenko
2020-02-09 16:33 ` [PATCH v8 05/19] dmaengine: tegra-apb: Clean up tasklet releasing Dmitry Osipenko
2020-02-09 16:33 ` [PATCH v8 06/19] dmaengine: tegra-apb: Use devm_platform_ioremap_resource Dmitry Osipenko
2020-02-09 16:33 ` [PATCH v8 08/19] dmaengine: tegra-apb: Fix coding style problems Dmitry Osipenko
2020-02-09 16:33 ` [PATCH v8 09/19] dmaengine: tegra-apb: Remove unneeded initialization of tdc->config_init Dmitry Osipenko
2020-02-09 16:33 ` [PATCH v8 10/19] dmaengine: tegra-apb: Remove assumptions about unavailable runtime PM Dmitry Osipenko
2020-02-09 16:33 ` [PATCH v8 12/19] dmaengine: tegra-apb: Keep clock enabled only during of DMA transfer Dmitry Osipenko
     [not found]   ` <20200209163356.6439-13-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-02-14 14:15     ` Jon Hunter
     [not found] ` <20200209163356.6439-1-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-02-09 16:33   ` [PATCH v8 07/19] dmaengine: tegra-apb: Use devm_request_irq Dmitry Osipenko
2020-02-09 16:33   ` [PATCH v8 11/19] dmaengine: tegra-apb: Remove duplicated pending_sg_req checks Dmitry Osipenko
     [not found]     ` <20200209163356.6439-12-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-02-14 14:13       ` Jon Hunter
2020-02-09 16:33   ` [PATCH v8 13/19] dmaengine: tegra-apb: Clean up suspend-resume Dmitry Osipenko
2020-02-09 16:33   ` [PATCH v8 14/19] dmaengine: tegra-apb: Add missing of_dma_controller_free Dmitry Osipenko
2020-02-09 16:33   ` [PATCH v8 15/19] dmaengine: tegra-apb: Allow to compile as a loadable kernel module Dmitry Osipenko
2020-02-09 16:33   ` [PATCH v8 16/19] dmaengine: tegra-apb: Remove MODULE_ALIAS Dmitry Osipenko
2020-02-09 16:33   ` [PATCH v8 17/19] dmaengine: tegra-apb: Support COMPILE_TEST Dmitry Osipenko
2020-02-25  6:32   ` [PATCH v8 00/19] NVIDIA Tegra APB DMA driver fixes and improvements Vinod Koul
2020-02-25  7:05     ` Dmitry Osipenko
2020-02-09 16:33 ` [PATCH v8 18/19] dmaengine: tegra-apb: Remove unused function argument Dmitry Osipenko
     [not found]   ` <20200209163356.6439-19-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-02-14 14:16     ` Jon Hunter
     [not found]       ` <d9a1bd6a-bd26-36ad-7d94-57801a2aa616-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-02-14 16:54         ` Dmitry Osipenko
     [not found]           ` <392ccaf4-3cc9-e8af-130c-fa068cc56527-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-02-17 11:15             ` Jon Hunter
     [not found]               ` <f9ea6be9-71d6-0119-eade-fe06bbbcbd5b-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-02-17 14:56                 ` Dmitry Osipenko
2020-02-09 16:33 ` Dmitry Osipenko [this message]
     [not found]   ` <20200209163356.6439-20-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-02-14 14:16     ` [PATCH v8 19/19] dmaengine: tegra-apb: Improve error message about DMA underflow Jon Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200209163356.6439-20-digetx@gmail.com \
    --to=digetx@gmail.com \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=ldewangan@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mirq-linux@rere.qmqm.pl \
    --cc=thierry.reding@gmail.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).