Re: [PATCH 5.4 000/344] 5.4.22-stable review

Re: [PATCH 5.4 000/344] 5.4.22-stable review

[Jon Hunter]

On 21/02/2020 07:36, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.4.22 release.
> There are 344 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Sun, 23 Feb 2020 07:19:49 +0000.
> Anything received after that time might be too late.
> 
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.22-rc1.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> and the diffstat can be found below.
> 
> thanks,
> 
> greg k-h
> 
> -------------
> Pseudo-Shortlog of commits:

...

> Tero Kristo <t-kristo-l0cyMroinI0@public.gmane.org>
>     ARM: OMAP2+: pdata-quirks: add PRM data for reset support


The above commit is generating the following build error on ARM systems ...

dvs/git/dirty/git-master_l4t-upstream/kernel/arch/arm/mach-omap2/pdata-quirks.c:27:10: fatal error: linux/platform_data/ti-prm.h: No such file or directory
 #include <linux/platform_data/ti-prm.h>
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Cheers
Jon

-- 
nvpublic

Re: [PATCH 5.4 000/344] 5.4.22-stable review

[Naresh Kamboju]

On Fri, 21 Feb 2020 at 15:34, Jon Hunter <jonathanh@nvidia.com> wrote:
>
>
> On 21/02/2020 07:36, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.4.22 release.
> > There are 344 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Sun, 23 Feb 2020 07:19:49 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> >       https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.22-rc1.gz
> > or in the git tree and branch at:
> >       git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
> >
> > -------------
> > Pseudo-Shortlog of commits:
>
> ...
>
> > Tero Kristo <t-kristo@ti.com>
> >     ARM: OMAP2+: pdata-quirks: add PRM data for reset support
>
>
> The above commit is generating the following build error on ARM systems ...
>
> dvs/git/dirty/git-master_l4t-upstream/kernel/arch/arm/mach-omap2/pdata-quirks.c:27:10: fatal error: linux/platform_data/ti-prm.h: No such file or directory
>  #include <linux/platform_data/ti-prm.h>
>           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

build error:

../arch/arm/mach-omap2/pdata-quirks.c:27:10: fatal error:
linux/platform_data/ti-prm.h: No such file or directory
   27 | #include <linux/platform_data/ti-prm.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [../scripts/Makefile.build:265:
arch/arm/mach-omap2/pdata-quirks.o] Error 1

With these below three patches, it applies cleanly and builds.
But I'm not sure these are not expected to get into stable rc 5.4 branch.

3e99cb214f03 ("soc: ti: add initial PRM driver with reset control support")
c5117a78dd88 ("soc: ti: omap-prm: poll for reset complete during de-assert")
d30cd83f6853 ("soc: ti: omap-prm: add support for denying idle for
reset clockdomain")

However, it's only patch
d30cd83f6853 ("soc: ti: omap-prm: add support for denying idle for
reset clockdomain")
that introduces file linux/platform_data/ti-prm.h

Re: [PATCH 5.4 000/344] 5.4.22-stable review

[Tero Kristo]

On 21/02/2020 13:17, Naresh Kamboju wrote:
> On Fri, 21 Feb 2020 at 15:34, Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> wrote:
>>
>>
>> On 21/02/2020 07:36, Greg Kroah-Hartman wrote:
>>> This is the start of the stable review cycle for the 5.4.22 release.
>>> There are 344 patches in this series, all will be posted as a response
>>> to this one.  If anyone has any issues with these being applied, please
>>> let me know.
>>>
>>> Responses should be made by Sun, 23 Feb 2020 07:19:49 +0000.
>>> Anything received after that time might be too late.
>>>
>>> The whole patch series can be found in one patch at:
>>>        https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.22-rc1.gz
>>> or in the git tree and branch at:
>>>        git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
>>> and the diffstat can be found below.
>>>
>>> thanks,
>>>
>>> greg k-h
>>>
>>> -------------
>>> Pseudo-Shortlog of commits:
>>
>> ...
>>
>>> Tero Kristo <t-kristo-l0cyMroinI0@public.gmane.org>
>>>      ARM: OMAP2+: pdata-quirks: add PRM data for reset support
>>
>>
>> The above commit is generating the following build error on ARM systems ...
>>
>> dvs/git/dirty/git-master_l4t-upstream/kernel/arch/arm/mach-omap2/pdata-quirks.c:27:10: fatal error: linux/platform_data/ti-prm.h: No such file or directory
>>   #include <linux/platform_data/ti-prm.h>
>>            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> build error:
> 
> ../arch/arm/mach-omap2/pdata-quirks.c:27:10: fatal error:
> linux/platform_data/ti-prm.h: No such file or directory
>     27 | #include <linux/platform_data/ti-prm.h>
>        |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> make[2]: *** [../scripts/Makefile.build:265:
> arch/arm/mach-omap2/pdata-quirks.o] Error 1
> 
> With these below three patches, it applies cleanly and builds.
> But I'm not sure these are not expected to get into stable rc 5.4 branch.

Yeah, without PRM driver the pdata-quirk patch should not have been 
picked up. I wonder why it ended up in stable. Tony, any ideas?

-Tero

> 
> 3e99cb214f03 ("soc: ti: add initial PRM driver with reset control support")
> c5117a78dd88 ("soc: ti: omap-prm: poll for reset complete during de-assert")
> d30cd83f6853 ("soc: ti: omap-prm: add support for denying idle for
> reset clockdomain")
> 
> However, it's only patch
> d30cd83f6853 ("soc: ti: omap-prm: add support for denying idle for
> reset clockdomain")
> that introduces file linux/platform_data/ti-prm.h
> 
> --
> Linaro LKFT
> https://lkft.linaro.org
> 

Re: [PATCH 5.4 000/344] 5.4.22-stable review

[Greg Kroah-Hartman]

On Fri, Feb 21, 2020 at 01:57:20PM +0200, Tero Kristo wrote:
> On 21/02/2020 13:17, Naresh Kamboju wrote:
> > On Fri, 21 Feb 2020 at 15:34, Jon Hunter <jonathanh@nvidia.com> wrote:
> > > 
> > > 
> > > On 21/02/2020 07:36, Greg Kroah-Hartman wrote:
> > > > This is the start of the stable review cycle for the 5.4.22 release.
> > > > There are 344 patches in this series, all will be posted as a response
> > > > to this one.  If anyone has any issues with these being applied, please
> > > > let me know.
> > > > 
> > > > Responses should be made by Sun, 23 Feb 2020 07:19:49 +0000.
> > > > Anything received after that time might be too late.
> > > > 
> > > > The whole patch series can be found in one patch at:
> > > >        https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.22-rc1.gz
> > > > or in the git tree and branch at:
> > > >        git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> > > > and the diffstat can be found below.
> > > > 
> > > > thanks,
> > > > 
> > > > greg k-h
> > > > 
> > > > -------------
> > > > Pseudo-Shortlog of commits:
> > > 
> > > ...
> > > 
> > > > Tero Kristo <t-kristo@ti.com>
> > > >      ARM: OMAP2+: pdata-quirks: add PRM data for reset support
> > > 
> > > 
> > > The above commit is generating the following build error on ARM systems ...
> > > 
> > > dvs/git/dirty/git-master_l4t-upstream/kernel/arch/arm/mach-omap2/pdata-quirks.c:27:10: fatal error: linux/platform_data/ti-prm.h: No such file or directory
> > >   #include <linux/platform_data/ti-prm.h>
> > >            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > 
> > build error:
> > 
> > ../arch/arm/mach-omap2/pdata-quirks.c:27:10: fatal error:
> > linux/platform_data/ti-prm.h: No such file or directory
> >     27 | #include <linux/platform_data/ti-prm.h>
> >        |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > compilation terminated.
> > make[2]: *** [../scripts/Makefile.build:265:
> > arch/arm/mach-omap2/pdata-quirks.o] Error 1
> > 
> > With these below three patches, it applies cleanly and builds.
> > But I'm not sure these are not expected to get into stable rc 5.4 branch.
> 
> Yeah, without PRM driver the pdata-quirk patch should not have been picked
> up. I wonder why it ended up in stable. Tony, any ideas?

I've dropped the offending patch now, sorry about that.

greg k-h

Re: [PATCH 5.4 000/344] 5.4.22-stable review

[Jon Hunter]

On 23/02/2020 17:26, Greg Kroah-Hartman wrote:

...

> I've dropped the offending patch now, sorry about that.
> 
> greg k-h


Thanks. I know that it is already out but FWIW, looks good to me ...


Test results for stable-v5.4:
    13 builds:	13 pass, 0 fail
    22 boots:	22 pass, 0 fail
    40 tests:	40 pass, 0 fail

Linux version:	5.4.22-gf22dcb31727e
Boards tested:	tegra124-jetson-tk1, tegra186-p2771-0000,
                tegra194-p2972-0000, tegra20-ventana,
                tegra210-p2371-2180, tegra210-p3450-0000,
                tegra30-cardhu-a04

Cheers
Jon

-- 
nvpublic