From: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Thierry Reding"
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Jonathan Hunter"
<jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"Peter De Schrijver"
<pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"Rafael J. Wysocki" <rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org>,
"Daniel Lezcano"
<daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"Michał Mirosław"
<mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org>,
"Jasper Korten" <jja2000-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"David Heidelberg" <david-W22tF5X+A20@public.gmane.org>,
"Peter Geis" <pgwipeout-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Nicolas Chauvet"
<kwizart-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v11 11/17] arm: tegra20/30: cpuidle: Remove unnecessary memory barrier
Date: Tue, 25 Feb 2020 01:40:51 +0300 [thread overview]
Message-ID: <20200224224057.21877-12-digetx@gmail.com> (raw)
In-Reply-To: <20200224224057.21877-1-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
There is no good justification for smp_rmb() after returning from LP2
because there are no memory operations that require SMP synchronization.
Thus remove the confusing barrier.
Acked-by: Peter De Schrijver <pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Tested-by: Peter Geis <pgwipeout-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Tested-by: Jasper Korten <jja2000-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Tested-by: David Heidelberg <david-W22tF5X+A20@public.gmane.org>
Tested-by: Nicolas Chauvet <kwizart-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Acked-by: Daniel Lezcano <daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Signed-off-by: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
arch/arm/mach-tegra/cpuidle-tegra20.c | 2 --
arch/arm/mach-tegra/cpuidle-tegra30.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/arch/arm/mach-tegra/cpuidle-tegra20.c b/arch/arm/mach-tegra/cpuidle-tegra20.c
index 8cdffdf7acd7..6db380515a6a 100644
--- a/arch/arm/mach-tegra/cpuidle-tegra20.c
+++ b/arch/arm/mach-tegra/cpuidle-tegra20.c
@@ -197,8 +197,6 @@ static int tegra20_idle_lp2_coupled(struct cpuidle_device *dev,
local_fiq_enable();
- smp_rmb();
-
return entered_lp2 ? index : 0;
}
#endif
diff --git a/arch/arm/mach-tegra/cpuidle-tegra30.c b/arch/arm/mach-tegra/cpuidle-tegra30.c
index a4f0add46a27..80ae64bcdf50 100644
--- a/arch/arm/mach-tegra/cpuidle-tegra30.c
+++ b/arch/arm/mach-tegra/cpuidle-tegra30.c
@@ -113,8 +113,6 @@ static int tegra30_idle_lp2(struct cpuidle_device *dev,
local_fiq_enable();
- smp_rmb();
-
return (entered_lp2) ? index : 0;
}
#endif
--
2.24.0
next prev parent reply other threads:[~2020-02-24 22:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 22:40 [PATCH v11 00/17] Consolidate and improve NVIDIA Tegra CPUIDLE driver(s) Dmitry Osipenko
2020-02-24 22:40 ` [PATCH v11 02/17] ARM: tegra: Add tegra_pm_park_secondary_cpu() Dmitry Osipenko
2020-02-24 22:40 ` [PATCH v11 06/17] ARM: tegra: Expose PM functions required for new cpuidle driver Dmitry Osipenko
2020-02-24 22:40 ` [PATCH v11 07/17] ARM: tegra: Rename some of the newly exposed PM functions Dmitry Osipenko
2020-02-24 22:40 ` [PATCH v11 08/17] ARM: tegra: Make outer_disable() open-coded Dmitry Osipenko
[not found] ` <20200224224057.21877-1-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-02-24 22:40 ` [PATCH v11 01/17] ARM: tegra: Compile sleep-tegra20/30.S unconditionally Dmitry Osipenko
2020-02-24 22:40 ` [PATCH v11 03/17] ARM: tegra: Remove pen-locking from cpuidle-tegra20 Dmitry Osipenko
2020-02-24 22:40 ` [PATCH v11 04/17] ARM: tegra: Change tegra_set_cpu_in_lp2() type to void Dmitry Osipenko
2020-02-24 22:40 ` [PATCH v11 05/17] ARM: tegra: Propagate error from tegra_idle_lp2_last() Dmitry Osipenko
2020-02-24 22:40 ` [PATCH v11 09/17] arm: tegra20: cpuidle: Handle case where secondary CPU hangs on entering LP2 Dmitry Osipenko
2020-02-24 22:40 ` [PATCH v11 10/17] arm: tegra20: cpuidle: Make abort_flag atomic Dmitry Osipenko
2020-02-24 22:40 ` Dmitry Osipenko [this message]
2020-02-24 22:40 ` [PATCH v11 12/17] cpuidle: Refactor and move out NVIDIA Tegra20 driver into drivers/cpuidle Dmitry Osipenko
[not found] ` <20200224224057.21877-13-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-02-27 9:20 ` Daniel Lezcano
2020-02-24 22:40 ` [PATCH v11 13/17] cpuidle: tegra: Squash Tegra30 driver into the common driver Dmitry Osipenko
2020-02-24 22:40 ` [PATCH v11 14/17] cpuidle: tegra: Squash Tegra114 " Dmitry Osipenko
[not found] ` <20200224224057.21877-15-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-02-27 9:21 ` Daniel Lezcano
[not found] ` <dcf45352-8ea3-6273-b4e8-0142f5d5e9f2-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2020-02-27 16:45 ` Dmitry Osipenko
2020-02-24 22:40 ` [PATCH v11 15/17] cpuidle: tegra: Disable CC6 state if LP2 unavailable Dmitry Osipenko
2020-02-24 22:40 ` [PATCH v11 17/17] ARM: tegra: Enable Tegra cpuidle driver in tegra_defconfig Dmitry Osipenko
2020-02-24 22:40 ` [PATCH v11 16/17] ARM: multi_v7_defconfig: Enable Tegra cpuidle driver Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224224057.21877-12-digetx@gmail.com \
--to=digetx-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=david-W22tF5X+A20@public.gmane.org \
--cc=jja2000-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=kwizart-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org \
--cc=pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=pgwipeout-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).