linux-tegra.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann-l3A5Bk7waGM@public.gmane.org>
To: airlied-cv59FeDIM0c@public.gmane.org,
	daniel-/w4YWyX8dFk@public.gmane.org,
	sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org,
	abrodkin-HKixBCOQz3hWk0Htik3J/w@public.gmane.org,
	bbrezillon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	nicolas.ferre-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org,
	alexandre.belloni-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org,
	ludovic.desroches-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org,
	maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
	mripard-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	jingoohan1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	inki.dae-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
	jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
	sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
	kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
	kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	stefan-XLVq0VzYD2Y@public.gmane.org,
	alison.wang-3arQi8VN3Tc@public.gmane.org,
	patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	xinliang.liu-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	zourongrong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	john.stultz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	kong.kongxinwei-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
	puck.chen-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
	linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
	p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
	shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
	kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
	festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-imx-3arQi8VN3Tc@public.gmane.org,
	paul-icTtO2rgO2OTuSrc4Mpeew@public.gmane.org,
	ck.hu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org
Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	Thomas Zimmermann <tzimmermann-l3A5Bk7waGM@public.gmane.org>
Subject: [PATCH 06/22] drm/hisilicon/kirin: Use simple encoder
Date: Thu,  5 Mar 2020 16:59:34 +0100	[thread overview]
Message-ID: <20200305155950.2705-7-tzimmermann@suse.de> (raw)
In-Reply-To: <20200305155950.2705-1-tzimmermann-l3A5Bk7waGM@public.gmane.org>

The kirin driver uses an empty implementation for its encoder. Replace
the code with the generic simple encoder.

Signed-off-by: Thomas Zimmermann <tzimmermann-l3A5Bk7waGM@public.gmane.org>
---
 drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
index f31068d74b18..08c1ab542c03 100644
--- a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
+++ b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
@@ -25,6 +25,7 @@
 #include <drm/drm_of.h>
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
+#include <drm/drm_simple_kms_helper.h>
 
 #include "dw_dsi_reg.h"
 
@@ -696,10 +697,6 @@ static const struct drm_encoder_helper_funcs dw_encoder_helper_funcs = {
 	.disable	= dsi_encoder_disable
 };
 
-static const struct drm_encoder_funcs dw_encoder_funcs = {
-	.destroy = drm_encoder_cleanup,
-};
-
 static int dw_drm_encoder_init(struct device *dev,
 			       struct drm_device *drm_dev,
 			       struct drm_encoder *encoder)
@@ -713,8 +710,7 @@ static int dw_drm_encoder_init(struct device *dev,
 	}
 
 	encoder->possible_crtcs = crtc_mask;
-	ret = drm_encoder_init(drm_dev, encoder, &dw_encoder_funcs,
-			       DRM_MODE_ENCODER_DSI, NULL);
+	ret = drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_DSI);
 	if (ret) {
 		DRM_ERROR("failed to init dsi encoder\n");
 		return ret;
-- 
2.25.1

  parent reply	other threads:[~2020-03-05 15:59 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-05 15:59 [PATCH 00/22] drm: Convert drivers to drm_simple_encoder_init() Thomas Zimmermann
     [not found] ` <20200305155950.2705-1-tzimmermann-l3A5Bk7waGM@public.gmane.org>
2020-03-05 15:59   ` [PATCH 01/22] drm/arc: Use simple encoder Thomas Zimmermann
     [not found]     ` <20200305155950.2705-2-tzimmermann-l3A5Bk7waGM@public.gmane.org>
2020-03-05 23:48       ` kbuild test robot
2020-03-06 21:18       ` Sam Ravnborg
     [not found]         ` <20200306211802.GA17369-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>
2020-03-09  7:55           ` Thomas Zimmermann
2020-03-05 15:59   ` [PATCH 02/22] drm/atmel-hlcdc: " Thomas Zimmermann
     [not found]     ` <20200305155950.2705-3-tzimmermann-l3A5Bk7waGM@public.gmane.org>
2020-03-06  0:32       ` kbuild test robot
2020-03-06 21:26       ` Sam Ravnborg
2020-03-05 15:59   ` [PATCH 04/22] drm/fsl-dcu: " Thomas Zimmermann
2020-03-06  0:02     ` kbuild test robot
2020-03-05 15:59   ` [PATCH 05/22] drm/gma500: " Thomas Zimmermann
     [not found]     ` <20200305155950.2705-6-tzimmermann-l3A5Bk7waGM@public.gmane.org>
2020-03-06  0:44       ` kbuild test robot
2020-03-06 21:35       ` Sam Ravnborg
     [not found]         ` <20200306213519.GD17369-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>
2020-03-09  7:32           ` Thomas Zimmermann
2020-03-05 15:59   ` Thomas Zimmermann [this message]
     [not found]     ` <20200305155950.2705-7-tzimmermann-l3A5Bk7waGM@public.gmane.org>
2020-03-06  6:16       ` [PATCH 06/22] drm/hisilicon/kirin: " kbuild test robot
2020-03-05 15:59   ` [PATCH 07/22] drm/i2c/tda998x: " Thomas Zimmermann
     [not found]     ` <20200305155950.2705-8-tzimmermann-l3A5Bk7waGM@public.gmane.org>
2020-03-06  7:30       ` kbuild test robot
2020-03-07 15:40       ` kbuild test robot
2020-03-05 15:59   ` [PATCH 09/22] drm/ingenic: " Thomas Zimmermann
2020-03-05 15:59   ` [PATCH 12/22] drm/rockchip: " Thomas Zimmermann
     [not found]     ` <20200305155950.2705-13-tzimmermann-l3A5Bk7waGM@public.gmane.org>
2020-03-05 23:59       ` kbuild test robot
2020-03-06 10:05       ` kbuild test robot
2020-03-05 15:59   ` [PATCH 14/22] drm/sun4i: " Thomas Zimmermann
     [not found]     ` <20200305155950.2705-15-tzimmermann-l3A5Bk7waGM@public.gmane.org>
2020-03-06 11:12       ` kbuild test robot
2020-03-05 15:59   ` [PATCH 19/22] drm/virtgpu: " Thomas Zimmermann
     [not found]     ` <20200305155950.2705-20-tzimmermann-l3A5Bk7waGM@public.gmane.org>
2020-03-07 15:40       ` kbuild test robot
2020-03-06 14:22   ` [PATCH 00/22] drm: Convert drivers to drm_simple_encoder_init() Laurent Pinchart
     [not found]     ` <20200306142212.GF4878-N3hz7ZxfLydczECFQUw77jytWr6r+dGw0E9HWUfgJXw@public.gmane.org>
2020-03-06 15:18       ` Thomas Zimmermann
     [not found]         ` <bccc380a-8925-81a7-34fe-5a1744a766d0-l3A5Bk7waGM@public.gmane.org>
2020-03-07 20:08           ` Sam Ravnborg
     [not found]             ` <20200307200813.GA15363-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>
2020-03-07 20:34               ` Laurent Pinchart
     [not found]                 ` <20200307203445.GC5021-N3hz7ZxfLydczECFQUw77jytWr6r+dGw0E9HWUfgJXw@public.gmane.org>
2020-03-07 20:51                   ` Sam Ravnborg
2020-03-09  7:24               ` Thomas Zimmermann
2020-03-05 15:59 ` [PATCH 03/22] drm/exynos: Use simple encoder Thomas Zimmermann
     [not found]   ` <20200305155950.2705-4-tzimmermann-l3A5Bk7waGM@public.gmane.org>
2020-03-06  0:55     ` kbuild test robot
2020-03-06  5:14     ` kbuild test robot
2020-03-06 21:28     ` Sam Ravnborg
2020-03-05 15:59 ` [PATCH 08/22] drm/imx: " Thomas Zimmermann
2020-03-05 15:59 ` [PATCH 10/22] drm/mediatek: " Thomas Zimmermann
     [not found]   ` <20200305155950.2705-11-tzimmermann-l3A5Bk7waGM@public.gmane.org>
2020-03-07 21:26     ` Matthias Brugger
2020-03-10  2:37     ` CK Hu
2020-03-05 15:59 ` [PATCH 11/22] drm/rcar-du: " Thomas Zimmermann
     [not found]   ` <20200305155950.2705-12-tzimmermann-l3A5Bk7waGM@public.gmane.org>
2020-03-06  8:43     ` kbuild test robot
2020-03-05 15:59 ` [PATCH 13/22] drm/shmobile: " Thomas Zimmermann
2020-03-05 15:59 ` [PATCH 15/22] drm/tegra: " Thomas Zimmermann
2020-03-06 12:38   ` kbuild test robot
2020-03-05 15:59 ` [PATCH 16/22] drm/tidss: " Thomas Zimmermann
     [not found]   ` <20200305155950.2705-17-tzimmermann-l3A5Bk7waGM@public.gmane.org>
2020-03-06 16:02     ` Jyri Sarha
2020-03-05 15:59 ` [PATCH 17/22] drm/tilcdc: " Thomas Zimmermann
     [not found]   ` <20200305155950.2705-18-tzimmermann-l3A5Bk7waGM@public.gmane.org>
2020-03-06 16:03     ` Jyri Sarha
2020-03-05 15:59 ` [PATCH 18/22] drm/vc4: " Thomas Zimmermann
     [not found]   ` <20200305155950.2705-19-tzimmermann-l3A5Bk7waGM@public.gmane.org>
2020-03-05 17:03     ` Eric Anholt
2020-03-06 13:54     ` kbuild test robot
2020-03-05 15:59 ` [PATCH 20/22] drm/vkms: " Thomas Zimmermann
     [not found]   ` <20200305155950.2705-21-tzimmermann-l3A5Bk7waGM@public.gmane.org>
2020-03-06  0:24     ` kbuild test robot
2020-03-07 13:59     ` kbuild test robot
2020-03-24 11:59     ` Rodrigo Siqueira
2020-03-31  9:20       ` Thomas Zimmermann
     [not found]       ` <20200324115905.dp5jqzbmvhbmk2rn-TAvD023jEQEN+BqQ9rBEUg@public.gmane.org>
2020-04-01  7:17         ` Thomas Zimmermann
2020-03-05 15:59 ` [PATCH 21/22] drm/writeback: " Thomas Zimmermann
     [not found]   ` <20200305155950.2705-22-tzimmermann-l3A5Bk7waGM@public.gmane.org>
2020-03-06  0:54     ` kbuild test robot
2020-03-06  1:17     ` kbuild test robot
2020-03-06 14:54   ` kbuild test robot
2020-03-05 15:59 ` [PATCH 22/22] drm/zte: " Thomas Zimmermann
2020-03-06 10:56 ` [PATCH 00/22] drm: Convert drivers to drm_simple_encoder_init() Daniel Vetter
     [not found]   ` <20200306105659.GY2363188-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2020-03-06 15:10     ` Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200305155950.2705-7-tzimmermann@suse.de \
    --to=tzimmermann-l3a5bk7wagm@public.gmane.org \
    --cc=abrodkin-HKixBCOQz3hWk0Htik3J/w@public.gmane.org \
    --cc=airlied-cv59FeDIM0c@public.gmane.org \
    --cc=alexandre.belloni-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org \
    --cc=alison.wang-3arQi8VN3Tc@public.gmane.org \
    --cc=bbrezillon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=ck.hu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
    --cc=daniel-/w4YWyX8dFk@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=inki.dae-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=jingoohan1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=john.stultz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=kong.kongxinwei-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org \
    --cc=krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \
    --cc=linux-imx-3arQi8VN3Tc@public.gmane.org \
    --cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=ludovic.desroches-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org \
    --cc=maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=mripard-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=nicolas.ferre-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org \
    --cc=p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=paul-icTtO2rgO2OTuSrc4Mpeew@public.gmane.org \
    --cc=puck.chen-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org \
    --cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org \
    --cc=shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=stefan-XLVq0VzYD2Y@public.gmane.org \
    --cc=sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=xinliang.liu-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=zourongrong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).