From: Mark Brown <broonie@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Jon Hunter <jonathanh@nvidia.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH] regulator: pwm: Don't warn on probe deferral
Date: Fri, 6 Mar 2020 12:35:30 +0000 [thread overview]
Message-ID: <20200306123530.GA4114@sirena.org.uk> (raw)
In-Reply-To: <20200306075129.mzs22yjitkmgrthh@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 712 bytes --]
On Fri, Mar 06, 2020 at 08:51:29AM +0100, Uwe Kleine-König wrote:
> I wonder if we should do something like:
> ret = some_call(some, args);
> if (ret) {
> if (emit_errmsg_for_err(ret))
> dev_err(dev, "some_call failed: %pE\n", ERR_PTR(ret));
> return ret;
> }
> and have emit_errmsg_for_err return true if ret != -EPROBE_DEFER or some
> kernel parameter is given.
There was some effort in the past to have a dev_probe_err() or something
which could have a similar implementation but that didn't end up going
anywhere I think. I do prefer the debug level log since it's much
easier to have the information there without having to ask for it, that
design would've supported that.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-03-06 12:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 14:40 [PATCH] regulator: pwm: Don't warn on probe deferral Jon Hunter
[not found] ` <20200224144048.6587-1-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-02-24 15:12 ` Thierry Reding
2020-02-24 16:58 ` Mark Brown
[not found] ` <20200224165859.GJ6215-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2020-02-26 16:17 ` Uwe Kleine-König
[not found] ` <20200226161757.idpzbs3jmayt7ya6-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2020-02-26 16:39 ` Mark Brown
[not found] ` <20200226163905.GH4136-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2020-03-06 7:51 ` Uwe Kleine-König
2020-03-06 12:35 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200306123530.GA4114@sirena.org.uk \
--to=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).