From: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
MyungJoo Ham
<myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Kyungmin Park
<kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Jonathan Hunter
<jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Michael Turquette
<mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
Stephen Boyd <sboyd-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v1 3/5] PM / devfreq: tegra20: Use clk_round_rate_unboundly()
Date: Tue, 31 Mar 2020 02:16:15 +0300 [thread overview]
Message-ID: <20200330231617.17079-4-digetx@gmail.com> (raw)
In-Reply-To: <20200330231617.17079-1-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
The clk_round_rate() doesn't work for us properly if clock rate is bounded
by a min/max rate that is requested by some other clk-user because we're
building devfreq's OPP table based on the rounding.
In particular this becomes a problem if display driver is probed earlier
than devfreq, and thus, display adds a memory bandwidth request using
interconnect API, which results in a minimum clock-rate being set for
the memory clk. In a result, the lowest devfreq OPP rate is getting
limited to the minimum rate imposed by the display driver.
Let's use new clk_round_rate_unboundly() that resolves the problem by
rounding clock rate without taking into account min/max limits imposed by
active clk users.
Signed-off-by: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
drivers/devfreq/tegra20-devfreq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/devfreq/tegra20-devfreq.c b/drivers/devfreq/tegra20-devfreq.c
index ff82bac9ee4e..1bb10ef11dfe 100644
--- a/drivers/devfreq/tegra20-devfreq.c
+++ b/drivers/devfreq/tegra20-devfreq.c
@@ -149,10 +149,10 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
tegra->regs = mc->regs;
- max_rate = clk_round_rate(tegra->emc_clock, ULONG_MAX);
+ max_rate = clk_round_rate_unboundly(tegra->emc_clock, ULONG_MAX);
for (rate = 0; rate <= max_rate; rate++) {
- rate = clk_round_rate(tegra->emc_clock, rate);
+ rate = clk_round_rate_unboundly(tegra->emc_clock, rate);
err = dev_pm_opp_add(&pdev->dev, rate, 0);
if (err) {
--
2.25.1
next prev parent reply other threads:[~2020-03-30 23:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 23:16 [PATCH v1 0/5] NVIDIA Tegra devfreq drivers improvements Dmitry Osipenko
2020-03-30 23:16 ` [PATCH v1 1/5] PM / devfreq: tegra: Add Dmitry as a maintainer Dmitry Osipenko
[not found] ` <20200330231617.17079-2-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-03-31 23:13 ` Chanwoo Choi
[not found] ` <db4883d4-18b7-238a-798b-ad45aad978fc-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2020-04-01 18:52 ` Dmitry Osipenko
[not found] ` <20200330231617.17079-1-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-03-30 23:16 ` [PATCH v1 2/5] clk: Introduce clk_round_rate_unboundly() Dmitry Osipenko
[not found] ` <20200330231617.17079-3-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-04-02 0:33 ` Michał Mirosław
2020-04-02 14:21 ` Dmitry Osipenko
2020-05-27 5:55 ` Stephen Boyd
[not found] ` <159055894944.88029.2029223648098859689-n1Xw8LXHxjTHt/MElyovVYaSKrA+ACpX0E9HWUfgJXw@public.gmane.org>
2020-05-27 17:57 ` Dmitry Osipenko
[not found] ` <3fcac59c-7a37-d4af-9d12-710d7af05845-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-05-28 0:38 ` Stephen Boyd
2020-05-27 5:57 ` Stephen Boyd
2020-03-30 23:16 ` Dmitry Osipenko [this message]
[not found] ` <20200330231617.17079-4-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-03-31 23:22 ` [PATCH v1 3/5] PM / devfreq: tegra20: Use clk_round_rate_unboundly() Chanwoo Choi
2020-03-31 23:23 ` Chanwoo Choi
2020-03-30 23:16 ` [PATCH v1 5/5] PM / devfreq: tegra30: Make CPUFreq notifier to take into account boosting Dmitry Osipenko
2020-03-31 23:29 ` Chanwoo Choi
[not found] ` <afcc9f80-c102-da42-8f7f-9b66417a9d4d-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2020-04-01 18:53 ` Dmitry Osipenko
2020-03-30 23:16 ` [PATCH v1 4/5] PM / devfreq: tegra30: Use clk_round_rate_unboundly() Dmitry Osipenko
2020-03-31 23:22 ` Chanwoo Choi
[not found] ` <147b571a-bae1-8a58-942c-579a5297299b-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2020-03-31 23:23 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330231617.17079-4-digetx@gmail.com \
--to=digetx-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=sboyd-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).