From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH] dt-bindings: Fix dtc warnings on reg and ranges in examples Date: Thu, 9 Apr 2020 19:15:28 -0700 Message-ID: <20200410021528.GY20625@builder.lan> References: <20200409202458.24509-1-robh@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20200409202458.24509-1-robh@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Maxime Ripard , Chen-Yu Tsai , Nuno S? , Jean Delvare , Guenter Roeck , Thierry Reding , Jonathan Hunter , Lee Jones , "David S. Miller" , Matt Mackall , Herbert Xu , Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Mark Brown , linux-hwmon@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-msm@vg List-Id: linux-tegra@vger.kernel.org On Thu 09 Apr 13:24 PDT 2020, Rob Herring wrote: > A recent update to dtc and changes to the default warnings introduced > some new warnings in the DT binding examples: > > Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.example.dts:23.13-61: > Warning (dma_ranges_format): /example-0/dram-controller@1c01000:dma-ranges: "dma-ranges" property has invalid length (12 bytes) (parent #address-cells == 1, child #address-cells == 2, #size-cells == 1) > Documentation/devicetree/bindings/hwmon/adi,axi-fan-control.example.dts:17.22-28.11: > Warning (unit_address_vs_reg): /example-0/fpga-axi@0: node has a unit name, but no reg or ranges property > Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.example.dts:34.13-54: > Warning (dma_ranges_format): /example-0/memory-controller@2c00000:dma-ranges: "dma-ranges" property has invalid length (24 bytes) (parent #address-cells == 1, child #address-cells == 2, #size-cells == 2) > Documentation/devicetree/bindings/mfd/st,stpmic1.example.dts:19.15-79.11: > Warning (unit_address_vs_reg): /example-0/i2c@0: node has a unit name, but no reg or ranges property > Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.example.dts:28.23-31.15: > Warning (unit_address_vs_reg): /example-0/mdio@37000000/switch@10: node has a unit name, but no reg or ranges property > Documentation/devicetree/bindings/rng/brcm,bcm2835.example.dts:17.5-21.11: > Warning (unit_address_vs_reg): /example-0/rng: node has a reg or ranges property, but no unit name > Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.example.dts:20.20-43.11: > Warning (unit_address_vs_reg): /example-0/soc@0: node has a unit name, but no reg or ranges property > Documentation/devicetree/bindings/usb/ingenic,musb.example.dts:18.28-21.11: > Warning (unit_address_vs_reg): /example-0/usb-phy@0: node has a unit name, but no reg or ranges property > > Cc: Maxime Ripard > Cc: Chen-Yu Tsai > Cc: "Nuno Sá" > Cc: Jean Delvare > Cc: Guenter Roeck > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: Lee Jones > Cc: Bjorn Andersson > Cc: "David S. Miller" > Cc: Matt Mackall > Cc: Herbert Xu > Cc: Nicolas Saenz Julienne > Cc: Florian Fainelli > Cc: Ray Jui > Cc: Scott Branden > Cc: bcm-kernel-feedback-list@broadcom.com > Cc: Mark Brown > Cc: linux-hwmon@vger.kernel.org > Cc: linux-tegra@vger.kernel.org > Cc: linux-arm-msm@vger.kernel.org > Cc: netdev@vger.kernel.org > Cc: linux-crypto@vger.kernel.org > Cc: linux-rpi-kernel@lists.infradead.org > Cc: linux-spi@vger.kernel.org > Cc: linux-usb@vger.kernel.org > Signed-off-by: Rob Herring Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > Will take this via the DT tree. > > Rob > > .../arm/sunxi/allwinner,sun4i-a10-mbus.yaml | 6 +++ > .../bindings/hwmon/adi,axi-fan-control.yaml | 2 +- > .../nvidia,tegra186-mc.yaml | 41 +++++++++++-------- > .../devicetree/bindings/mfd/st,stpmic1.yaml | 2 +- > .../bindings/net/qcom,ipq8064-mdio.yaml | 1 + > .../devicetree/bindings/rng/brcm,bcm2835.yaml | 2 +- > .../bindings/spi/qcom,spi-qcom-qspi.yaml | 2 +- > .../devicetree/bindings/usb/ingenic,musb.yaml | 2 +- > 8 files changed, 35 insertions(+), 23 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml > index aa0738b4d534..e713a6fe4cf7 100644 > --- a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml > +++ b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml > @@ -42,6 +42,10 @@ properties: > description: > See section 2.3.9 of the DeviceTree Specification. > > + '#address-cells': true > + > + '#size-cells': true > + > required: > - "#interconnect-cells" > - compatible > @@ -59,6 +63,8 @@ examples: > compatible = "allwinner,sun5i-a13-mbus"; > reg = <0x01c01000 0x1000>; > clocks = <&ccu CLK_MBUS>; > + #address-cells = <1>; > + #size-cells = <1>; > dma-ranges = <0x00000000 0x40000000 0x20000000>; > #interconnect-cells = <1>; > }; > diff --git a/Documentation/devicetree/bindings/hwmon/adi,axi-fan-control.yaml b/Documentation/devicetree/bindings/hwmon/adi,axi-fan-control.yaml > index 57a240d2d026..29bb2c778c59 100644 > --- a/Documentation/devicetree/bindings/hwmon/adi,axi-fan-control.yaml > +++ b/Documentation/devicetree/bindings/hwmon/adi,axi-fan-control.yaml > @@ -47,7 +47,7 @@ required: > > examples: > - | > - fpga_axi: fpga-axi@0 { > + fpga_axi: fpga-axi { > #address-cells = <0x2>; > #size-cells = <0x1>; > > diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml > index 12516bd89cf9..611bda38d187 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml > +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml > @@ -97,30 +97,35 @@ examples: > #include > #include > > - memory-controller@2c00000 { > - compatible = "nvidia,tegra186-mc"; > - reg = <0x0 0x02c00000 0x0 0xb0000>; > - interrupts = ; > - > + bus { > #address-cells = <2>; > #size-cells = <2>; > > - ranges = <0x0 0x02c00000 0x02c00000 0x0 0xb0000>; > + memory-controller@2c00000 { > + compatible = "nvidia,tegra186-mc"; > + reg = <0x0 0x02c00000 0x0 0xb0000>; > + interrupts = ; > + > + #address-cells = <2>; > + #size-cells = <2>; > + > + ranges = <0x0 0x02c00000 0x0 0x02c00000 0x0 0xb0000>; > > - /* > - * Memory clients have access to all 40 bits that the memory > - * controller can address. > - */ > - dma-ranges = <0x0 0x0 0x0 0x0 0x100 0x0>; > + /* > + * Memory clients have access to all 40 bits that the memory > + * controller can address. > + */ > + dma-ranges = <0x0 0x0 0x0 0x0 0x100 0x0>; > > - external-memory-controller@2c60000 { > - compatible = "nvidia,tegra186-emc"; > - reg = <0x0 0x02c60000 0x0 0x50000>; > - interrupts = ; > - clocks = <&bpmp TEGRA186_CLK_EMC>; > - clock-names = "emc"; > + external-memory-controller@2c60000 { > + compatible = "nvidia,tegra186-emc"; > + reg = <0x0 0x02c60000 0x0 0x50000>; > + interrupts = ; > + clocks = <&bpmp TEGRA186_CLK_EMC>; > + clock-names = "emc"; > > - nvidia,bpmp = <&bpmp>; > + nvidia,bpmp = <&bpmp>; > + }; > }; > }; > > diff --git a/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml b/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml > index d9ad9260e348..f88d13d70441 100644 > --- a/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml > +++ b/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml > @@ -274,7 +274,7 @@ examples: > - | > #include > #include > - i2c@0 { > + i2c { > #address-cells = <1>; > #size-cells = <0>; > pmic@33 { > diff --git a/Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.yaml b/Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.yaml > index b9f90081046f..67df3fe861ee 100644 > --- a/Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.yaml > +++ b/Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.yaml > @@ -48,6 +48,7 @@ examples: > > switch@10 { > compatible = "qca,qca8337"; > + reg = <0x10>; > /* ... */ > }; > }; > diff --git a/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml b/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml > index 89ab67f20a7f..c147900f9041 100644 > --- a/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml > +++ b/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml > @@ -39,7 +39,7 @@ additionalProperties: false > > examples: > - | > - rng { > + rng@7e104000 { > compatible = "brcm,bcm2835-rng"; > reg = <0x7e104000 0x10>; > interrupts = <2 29>; > diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml > index 0cf470eaf2a0..5c16cf59ca00 100644 > --- a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml > +++ b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml > @@ -61,7 +61,7 @@ examples: > #include > #include > > - soc: soc@0 { > + soc: soc { > #address-cells = <2>; > #size-cells = <2>; > > diff --git a/Documentation/devicetree/bindings/usb/ingenic,musb.yaml b/Documentation/devicetree/bindings/usb/ingenic,musb.yaml > index 1d6877875077..c2d2ee43ba67 100644 > --- a/Documentation/devicetree/bindings/usb/ingenic,musb.yaml > +++ b/Documentation/devicetree/bindings/usb/ingenic,musb.yaml > @@ -56,7 +56,7 @@ additionalProperties: false > examples: > - | > #include > - usb_phy: usb-phy@0 { > + usb_phy: usb-phy { > compatible = "usb-nop-xceiv"; > #phy-cells = <0>; > }; > -- > 2.20.1 >