Re: [PATCH] memory: tegra: Fix KCONFIG variables for Tegra186 and Tegra194

[Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1175 bytes --]

On Sun, Jul 12, 2020 at 11:33:47AM +0100, Jon Hunter wrote:
> Commit a127e690b051 ("memory: tegra: Add support for the Tegra194 memory
> controller") and commit 4e04b88633ae ("memory: tegra: Only include
> support for enabled SoCs") incorrectly added the KCONFIG variables
> CONFIG_ARCH_TEGRA186_SOC and CONFIG_ARCH_TEGRA194_SOC to the Tegra EMC
> driver. These KCONFIG variables do not exist and prevent the EMC driver
> from being probed on Tegra186 and Tegra194. These KCONFIG variable
> names are simply missing one underscore and so fix this by adding the
> necessary underscore to the variable names.
> 
> Signed-off-by: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
>  drivers/memory/tegra/tegra186-emc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

I wonder why we didn't catch that earlier. I assume the EMC frequency
scaling tests just don't run on these SoC generations with existing
kernels, then?

Oddly enough, I also vaguely recall testing EMC frequency scaling on
both SoC generations, so I wonder where things went wrong. Anyway, this
is obviously correct, so I've applied it.

Thanks,
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]