From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: thierry.reding@gmail.com, joro@8bytes.org, krzk@kernel.org,
vdumpa@nvidia.com, jonathanh@nvidia.com,
linux-tegra@vger.kernel.org, iommu@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] iommu/tegra-smmu: Add PCI support
Date: Wed, 30 Sep 2020 00:12:14 -0700 [thread overview]
Message-ID: <20200930071213.GA13876@Asurada-Nvidia> (raw)
In-Reply-To: <84f05ebd-1123-5dfb-94fe-62564a21706f@gmail.com>
On Wed, Sep 30, 2020 at 09:01:09AM +0300, Dmitry Osipenko wrote:
> 30.09.2020 08:34, Nicolin Chen пишет:
> > On Wed, Sep 30, 2020 at 08:10:35AM +0300, Dmitry Osipenko wrote:
> >> 30.09.2020 03:30, Nicolin Chen пишет:
> >>> void tegra_smmu_remove(struct tegra_smmu *smmu)
> >>> {
> >>> + bus_set_iommu(&platform_bus_type, NULL);
> >>
> >> Why only platform_bus? Is this really needed at all?
> >
> > I see qcom_iommu.c file set to NULL in remove(), Probably should
> > have added pci_bus_type too though.
> >
> > Or are you sure that there's no need at all?
> >
>
> It wasn't here before this patch and platform_bus is unrelated to the
> topic of this patch. But it probably should be there.
>
> On the other hand, the tegra_smmu_remove() is unused and maybe it could
> be better to get rid of this unused function at all.
I will drop this line then, since no one is calling it. And maybe
we can submit a clean up patch later.
prev parent reply other threads:[~2020-09-30 7:17 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 0:30 [PATCH v2 0/3] iommu/tegra-smmu: Add PCI support Nicolin Chen
2020-09-30 0:30 ` [PATCH v2 1/3] memory: tegra: Add helper function tegra_get_memory_controller Nicolin Chen
2020-09-30 5:12 ` Dmitry Osipenko
2020-09-30 5:44 ` Nicolin Chen
2020-09-30 6:32 ` Dmitry Osipenko
2020-09-30 6:38 ` Nicolin Chen
2020-09-30 7:31 ` Dmitry Osipenko
2020-09-30 7:21 ` Krzysztof Kozlowski
2020-09-30 7:25 ` Nicolin Chen
2020-09-30 7:50 ` Krzysztof Kozlowski
2020-09-30 0:30 ` [PATCH v2 2/3] iommu/tegra-smmu: Rework .probe_device and .attach_dev Nicolin Chen
2020-09-30 5:10 ` Dmitry Osipenko
2020-09-30 5:20 ` Dmitry Osipenko
2020-09-30 5:50 ` Nicolin Chen
2020-09-30 6:34 ` Nicolin Chen
2020-09-30 5:11 ` Dmitry Osipenko
2020-09-30 5:49 ` Nicolin Chen
2020-09-30 6:10 ` Dmitry Osipenko
2020-09-30 6:13 ` Nicolin Chen
2020-09-30 6:33 ` Dmitry Osipenko
2020-09-30 5:24 ` Dmitry Osipenko
2020-09-30 5:39 ` Nicolin Chen
2020-09-30 5:48 ` Dmitry Osipenko
2020-09-30 5:39 ` Dmitry Osipenko
2020-09-30 5:41 ` Nicolin Chen
2020-09-30 5:59 ` Dmitry Osipenko
2020-09-30 6:19 ` Nicolin Chen
2020-09-30 0:30 ` [PATCH v2 3/3] iommu/tegra-smmu: Add PCI support Nicolin Chen
2020-09-30 5:10 ` Dmitry Osipenko
2020-09-30 5:28 ` Nicolin Chen
2020-09-30 5:10 ` Dmitry Osipenko
2020-09-30 5:29 ` Nicolin Chen
2020-09-30 5:58 ` Dmitry Osipenko
2020-09-30 7:16 ` Nicolin Chen
2020-09-30 5:10 ` Dmitry Osipenko
2020-09-30 5:34 ` Nicolin Chen
2020-09-30 6:01 ` Dmitry Osipenko
2020-09-30 7:12 ` Nicolin Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930071213.GA13876@Asurada-Nvidia \
--to=nicoleotsuka@gmail.com \
--cc=digetx@gmail.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vdumpa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox