* [PATCH v1 0/6] Nexus 7 and A500 device-tree improvements
@ 2020-10-25 22:38 Dmitry Osipenko
2020-10-25 22:38 ` [PATCH v1 1/6] ARM: tegra: acer-a500: Correct thermal zone names Dmitry Osipenko
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: Dmitry Osipenko @ 2020-10-25 22:38 UTC (permalink / raw)
To: Thierry Reding, Jonathan Hunter; +Cc: linux-tegra
This small series improves device-trees of Nexus 7 and A500 devices by
correcting old and adding new DT properties.
Dmitry Osipenko (6):
ARM: tegra: acer-a500: Correct thermal zone names
ARM: tegra: acer-a500: Add power-supply to lvds-encoder node
ARM: tegra: nexus7: Correct thermal zone names
ARM: tegra: nexus7: Improve CPU passive-cooling threshold
ARM: tegra: nexus7: Add power-supply to lvds-encoder node
ARM: tegra: nexus7: Rename gpio-hog nodes
arch/arm/boot/dts/tegra20-acer-a500-picasso.dts | 5 +++--
.../dts/tegra30-asus-nexus7-grouper-common.dtsi | 15 ++++++++-------
.../tegra30-asus-nexus7-grouper-maxim-pmic.dtsi | 2 +-
.../arm/boot/dts/tegra30-asus-nexus7-tilapia.dtsi | 2 +-
4 files changed, 13 insertions(+), 11 deletions(-)
--
2.27.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v1 1/6] ARM: tegra: acer-a500: Correct thermal zone names
2020-10-25 22:38 [PATCH v1 0/6] Nexus 7 and A500 device-tree improvements Dmitry Osipenko
@ 2020-10-25 22:38 ` Dmitry Osipenko
2020-10-25 22:38 ` [PATCH v1 2/6] ARM: tegra: acer-a500: Add power-supply to lvds-encoder node Dmitry Osipenko
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Dmitry Osipenko @ 2020-10-25 22:38 UTC (permalink / raw)
To: Thierry Reding, Jonathan Hunter; +Cc: linux-tegra
Rename thermal zones in order fix dt_binding_check warning telling that
names do not match the expected pattern.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
arch/arm/boot/dts/tegra20-acer-a500-picasso.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/tegra20-acer-a500-picasso.dts b/arch/arm/boot/dts/tegra20-acer-a500-picasso.dts
index a0b829738e8f..372cc1b17eaf 100644
--- a/arch/arm/boot/dts/tegra20-acer-a500-picasso.dts
+++ b/arch/arm/boot/dts/tegra20-acer-a500-picasso.dts
@@ -1020,14 +1020,14 @@ sound {
};
thermal-zones {
- nct1008-local {
+ skin-thermal {
polling-delay-passive = <1000>; /* milliseconds */
polling-delay = <0>; /* milliseconds */
thermal-sensors = <&nct1008 0>;
};
- nct1008-remote {
+ cpu-thermal {
polling-delay-passive = <1000>; /* milliseconds */
polling-delay = <5000>; /* milliseconds */
--
2.27.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v1 2/6] ARM: tegra: acer-a500: Add power-supply to lvds-encoder node
2020-10-25 22:38 [PATCH v1 0/6] Nexus 7 and A500 device-tree improvements Dmitry Osipenko
2020-10-25 22:38 ` [PATCH v1 1/6] ARM: tegra: acer-a500: Correct thermal zone names Dmitry Osipenko
@ 2020-10-25 22:38 ` Dmitry Osipenko
2020-10-25 22:38 ` [PATCH v1 3/6] ARM: tegra: nexus7: Correct thermal zone names Dmitry Osipenko
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Dmitry Osipenko @ 2020-10-25 22:38 UTC (permalink / raw)
To: Thierry Reding, Jonathan Hunter; +Cc: linux-tegra
The lvds-encoder binding now supports power-supply property, let's specify
it in the device-tree for completeness.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
arch/arm/boot/dts/tegra20-acer-a500-picasso.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/tegra20-acer-a500-picasso.dts b/arch/arm/boot/dts/tegra20-acer-a500-picasso.dts
index 372cc1b17eaf..dd6fb134ee39 100644
--- a/arch/arm/boot/dts/tegra20-acer-a500-picasso.dts
+++ b/arch/arm/boot/dts/tegra20-acer-a500-picasso.dts
@@ -907,6 +907,7 @@ lvds-encoder {
compatible = "ti,sn75lvds83", "lvds-encoder";
powerdown-gpios = <&gpio TEGRA_GPIO(B, 2) GPIO_ACTIVE_LOW>;
+ power-supply = <&vdd_3v3_sys>;
ports {
#address-cells = <1>;
--
2.27.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v1 3/6] ARM: tegra: nexus7: Correct thermal zone names
2020-10-25 22:38 [PATCH v1 0/6] Nexus 7 and A500 device-tree improvements Dmitry Osipenko
2020-10-25 22:38 ` [PATCH v1 1/6] ARM: tegra: acer-a500: Correct thermal zone names Dmitry Osipenko
2020-10-25 22:38 ` [PATCH v1 2/6] ARM: tegra: acer-a500: Add power-supply to lvds-encoder node Dmitry Osipenko
@ 2020-10-25 22:38 ` Dmitry Osipenko
2020-10-25 22:38 ` [PATCH v1 4/6] ARM: tegra: nexus7: Improve CPU passive-cooling threshold Dmitry Osipenko
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Dmitry Osipenko @ 2020-10-25 22:38 UTC (permalink / raw)
To: Thierry Reding, Jonathan Hunter; +Cc: linux-tegra
Rename thermal zones in order fix dt_binding_check warning telling that
names do not match the expected pattern.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi b/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
index 88ca03f57b3b..fa6bbec7cbc4 100644
--- a/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
+++ b/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
@@ -1240,14 +1240,14 @@ sound {
};
thermal-zones {
- nct72-local {
+ skin-thermal {
polling-delay-passive = <1000>; /* milliseconds */
polling-delay = <0>; /* milliseconds */
thermal-sensors = <&nct72 0>;
};
- nct72-remote {
+ cpu-thermal {
polling-delay-passive = <1000>; /* milliseconds */
polling-delay = <5000>; /* milliseconds */
--
2.27.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v1 4/6] ARM: tegra: nexus7: Improve CPU passive-cooling threshold
2020-10-25 22:38 [PATCH v1 0/6] Nexus 7 and A500 device-tree improvements Dmitry Osipenko
` (2 preceding siblings ...)
2020-10-25 22:38 ` [PATCH v1 3/6] ARM: tegra: nexus7: Correct thermal zone names Dmitry Osipenko
@ 2020-10-25 22:38 ` Dmitry Osipenko
2020-10-25 22:38 ` [PATCH v1 5/6] ARM: tegra: nexus7: Add power-supply to lvds-encoder node Dmitry Osipenko
2020-10-25 22:38 ` [PATCH v1 6/6] ARM: tegra: nexus7: Rename gpio-hog nodes Dmitry Osipenko
5 siblings, 0 replies; 7+ messages in thread
From: Dmitry Osipenko @ 2020-10-25 22:38 UTC (permalink / raw)
To: Thierry Reding, Jonathan Hunter; +Cc: linux-tegra
The current CPU thermal limit is a bit inappropriate for Nexus 7 once
device is getting used on a daily bases. For example, currently it's may
be impossible to watch a hardware accelerated 720p video without hitting
a severe CPU throttling, which ruins user experience. This patch improves
the thermal throttling thresholds.
In my experience setting CPU thermal threshold to 57C provides the most
reasonable result, where device is a bit warm under constant load and
not getting overly hot, in the same time performance is okay. Let's bump
the passive-cooling threshold from 50C to 57C and also lower the thermal
hysteresis to 0.2C in order to make throttling more reactive.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi b/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
index fa6bbec7cbc4..8d49860b135b 100644
--- a/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
+++ b/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
@@ -1255,9 +1255,9 @@ cpu-thermal {
trips {
trip0: cpu-alert0 {
- /* start throttling at 50C */
- temperature = <50000>;
- hysteresis = <3000>;
+ /* throttle at 57C until temperature drops to 56.8C */
+ temperature = <57000>;
+ hysteresis = <200>;
type = "passive";
};
--
2.27.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v1 5/6] ARM: tegra: nexus7: Add power-supply to lvds-encoder node
2020-10-25 22:38 [PATCH v1 0/6] Nexus 7 and A500 device-tree improvements Dmitry Osipenko
` (3 preceding siblings ...)
2020-10-25 22:38 ` [PATCH v1 4/6] ARM: tegra: nexus7: Improve CPU passive-cooling threshold Dmitry Osipenko
@ 2020-10-25 22:38 ` Dmitry Osipenko
2020-10-25 22:38 ` [PATCH v1 6/6] ARM: tegra: nexus7: Rename gpio-hog nodes Dmitry Osipenko
5 siblings, 0 replies; 7+ messages in thread
From: Dmitry Osipenko @ 2020-10-25 22:38 UTC (permalink / raw)
To: Thierry Reding, Jonathan Hunter; +Cc: linux-tegra
The lvds-encoder binding now supports power-supply property, let's specify
it in the device-tree for completeness.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi b/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
index 8d49860b135b..f8a531350998 100644
--- a/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
+++ b/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
@@ -1145,6 +1145,7 @@ lvds-encoder {
compatible = "ti,sn75lvds83", "lvds-encoder";
powerdown-gpios = <&gpio TEGRA_GPIO(N, 6) GPIO_ACTIVE_LOW>;
+ power-supply = <&vdd_3v3_sys>;
ports {
#address-cells = <1>;
--
2.27.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v1 6/6] ARM: tegra: nexus7: Rename gpio-hog nodes
2020-10-25 22:38 [PATCH v1 0/6] Nexus 7 and A500 device-tree improvements Dmitry Osipenko
` (4 preceding siblings ...)
2020-10-25 22:38 ` [PATCH v1 5/6] ARM: tegra: nexus7: Add power-supply to lvds-encoder node Dmitry Osipenko
@ 2020-10-25 22:38 ` Dmitry Osipenko
5 siblings, 0 replies; 7+ messages in thread
From: Dmitry Osipenko @ 2020-10-25 22:38 UTC (permalink / raw)
To: Thierry Reding, Jonathan Hunter; +Cc: linux-tegra
Devicetree schema now requires gpio-hog nodes to have a certain naming
pattern, like a -hog suffix. This patch fixes dtbs_check warnings about
the names.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 4 ++--
arch/arm/boot/dts/tegra30-asus-nexus7-grouper-maxim-pmic.dtsi | 2 +-
arch/arm/boot/dts/tegra30-asus-nexus7-tilapia.dtsi | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi b/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
index f8a531350998..8def1d2e34f9 100644
--- a/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
+++ b/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
@@ -75,7 +75,7 @@ lcd_output: endpoint {
};
gpio@6000d000 {
- init-mode {
+ init-mode-hog {
gpio-hog;
gpios = <TEGRA_GPIO(DD, 7) GPIO_ACTIVE_HIGH>,
<TEGRA_GPIO(CC, 6) GPIO_ACTIVE_HIGH>,
@@ -83,7 +83,7 @@ init-mode {
output-low;
};
- init-low-power-mode {
+ init-low-power-mode-hog {
gpio-hog;
gpios = <TEGRA_GPIO(I, 6) GPIO_ACTIVE_HIGH>;
input;
diff --git a/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-maxim-pmic.dtsi b/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-maxim-pmic.dtsi
index b25b3fa90ac6..17b6682ffce8 100644
--- a/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-maxim-pmic.dtsi
+++ b/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-maxim-pmic.dtsi
@@ -29,7 +29,7 @@ gpio4 {
};
};
- cpu-pwr-req {
+ cpu-pwr-req-hog {
gpio-hog;
gpios = <6 GPIO_ACTIVE_HIGH>;
input;
diff --git a/arch/arm/boot/dts/tegra30-asus-nexus7-tilapia.dtsi b/arch/arm/boot/dts/tegra30-asus-nexus7-tilapia.dtsi
index e3da89f1941a..a681ad51fddd 100644
--- a/arch/arm/boot/dts/tegra30-asus-nexus7-tilapia.dtsi
+++ b/arch/arm/boot/dts/tegra30-asus-nexus7-tilapia.dtsi
@@ -23,7 +23,7 @@ panel-timing {
};
gpio@6000d000 {
- init-mode-3g {
+ init-mode-3g-hog {
gpio-hog;
gpios = <TEGRA_GPIO(D, 2) GPIO_ACTIVE_HIGH>,
<TEGRA_GPIO(C, 6) GPIO_ACTIVE_HIGH>,
--
2.27.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-10-25 22:40 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-25 22:38 [PATCH v1 0/6] Nexus 7 and A500 device-tree improvements Dmitry Osipenko
2020-10-25 22:38 ` [PATCH v1 1/6] ARM: tegra: acer-a500: Correct thermal zone names Dmitry Osipenko
2020-10-25 22:38 ` [PATCH v1 2/6] ARM: tegra: acer-a500: Add power-supply to lvds-encoder node Dmitry Osipenko
2020-10-25 22:38 ` [PATCH v1 3/6] ARM: tegra: nexus7: Correct thermal zone names Dmitry Osipenko
2020-10-25 22:38 ` [PATCH v1 4/6] ARM: tegra: nexus7: Improve CPU passive-cooling threshold Dmitry Osipenko
2020-10-25 22:38 ` [PATCH v1 5/6] ARM: tegra: nexus7: Add power-supply to lvds-encoder node Dmitry Osipenko
2020-10-25 22:38 ` [PATCH v1 6/6] ARM: tegra: nexus7: Rename gpio-hog nodes Dmitry Osipenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).