From: Krzysztof Kozlowski <krzk@kernel.org>
To: Yu Kuai <yukuai3@huawei.com>
Cc: thierry.reding@gmail.com, jonathanh@nvidia.com,
mperttunen@nvidia.com, tomeu.vizoso@collabora.com,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
yi.zhang@huawei.com, zhangxiaoxu5@huawei.com
Subject: Re: [PATCH V3] memory: tegra: add missing put_device() call in error path of tegra_emc_probe()
Date: Tue, 10 Nov 2020 16:21:07 +0100 [thread overview]
Message-ID: <20201110152107.GA6203@kozik-lap> (raw)
In-Reply-To: <20201110013311.2499003-1-yukuai3@huawei.com>
On Tue, Nov 10, 2020 at 09:33:11AM +0800, Yu Kuai wrote:
> The reference to device obtained with of_find_device_by_node() should
> be dropped. Thus add jump target to fix the exception handling for this
> function implementation.
>
> Fixes: 73a7f0a90641("memory: tegra: Add EMC (external memory controller) driver")
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
> ---
> drivers/memory/tegra/tegra124-emc.c | 21 +++++++++++++++------
> 1 file changed, 15 insertions(+), 6 deletions(-)
I think you missed my previous comment about the issue being fixed
already. Are you sure you rebased this on top of latest next?
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-11-10 15:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 10:53 [PATCH] memory: tegra: add missing put_devcie() call in tegra_emc_probe() Yu Kuai
2020-11-02 18:52 ` Krzysztof Kozlowski
2020-11-09 13:28 ` [PATCH V2] memory: tegra: add missing put_devcie() call in error path of tegra_emc_probe() Yu Kuai
2020-11-09 16:41 ` Krzysztof Kozlowski
2020-11-10 1:33 ` [PATCH V3] memory: tegra: add missing put_device() " Yu Kuai
2020-11-10 15:21 ` Krzysztof Kozlowski [this message]
2020-11-11 1:11 ` yukuai (C)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110152107.GA6203@kozik-lap \
--to=krzk@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=tomeu.vizoso@collabora.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
--cc=zhangxiaoxu5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).